From patchwork Tue Nov 12 18:10:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 842723 Delivered-To: patch@linaro.org Received: by 2002:a5d:6307:0:b0:381:e71e:8f7b with SMTP id i7csp3719370wru; Tue, 12 Nov 2024 10:19:04 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU6f0MPybkL66DoRMrPuhZ7aTWLGcAH5SM56tfBTGt2r3h/xmQzHYEcNLkmLqUsPVFmIQpvZQ==@linaro.org X-Google-Smtp-Source: AGHT+IGvqh4Ytx8erFsmTe1RTtpuQJAz8dO49BxylTQpNL0UThJqOctIaxK4tGvK8EvyvKx4Itgx X-Received: by 2002:a05:620a:2908:b0:7b0:6e8:94fd with SMTP id af79cd13be357-7b352750235mr15665185a.0.1731435544256; Tue, 12 Nov 2024 10:19:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731435544; cv=none; d=google.com; s=arc-20240605; b=O0+TigP9Q8xZVWP/4iWJ25G4wfCO8eXqWa6mIMBYTrcws6534TrISyCXerv38pR4Gj sDw+R69AdlREx/Gr/69m1U+mb7Rb+0CA/qi0vNghlcRiCOpXyS2Pvdm7r58LL2YhJGb/ aAEqFKXejmMniyi1wVcnBbQyfyGk8HzWFv0GBbaG4wkNn0rcOG6w+hTz9+8STk9Jv2Ya qmg0iGa6h6+79eaoGfgbVczxganeW7cIADDm4jWdyI2spHnS1bnBM7VvwPLLrjYmAsp0 DCqnZQP92rdkkxiKdWhnr1OVU7bfRLdfH038lm/EoDhiDbJkWIdIh3pxlq3+eDTTm951 x3Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oH/SQSX4OUP5TxQrfvghzIartXS3npm2RFGdjSdA9Ng=; fh=qmVcbpKGT2NGruxhf8fgQHnlhHRaRjD5ibgD08FHYfA=; b=gPW/aHBbIxPPMkh+S7ILgn6BR2f96I/WgQNoLjIlYj6734DDXf4WkanNvBnz8jWoK2 DHUlKL4MI6WdtM80KhpX0BoFcL38WR2s9X1BGJbSRll4xkJ1IdBpaOq1qssCpiFkHPI1 VCc1BPdFDTCbr+BQ9BJ8epd6HIGTK93V3G+rwL/13uV92p4j4I0UeF0dZ9YgmmyI358g kdB37z8aj8yg55nh7+wWaE14yDh+3g4NEvZKPSVrAYmKYHzbtDR8lDLtwI/CFfcjCXAI hNQkHxpaOo1iRzf0gPHijmPx45U/O/XSbK4berQ936k8DFC3bLzYlcRlr6CfOdDF8c03 3c9Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BsBqowxg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b32ad21d5fsi1384919985a.627.2024.11.12.10.19.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2024 10:19:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BsBqowxg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAvMI-0004zV-FF; Tue, 12 Nov 2024 13:11:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAvM9-0004xu-O2 for qemu-devel@nongnu.org; Tue, 12 Nov 2024 13:11:14 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAvM7-0001t7-KW for qemu-devel@nongnu.org; Tue, 12 Nov 2024 13:11:12 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-431688d5127so47752925e9.0 for ; Tue, 12 Nov 2024 10:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731435068; x=1732039868; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oH/SQSX4OUP5TxQrfvghzIartXS3npm2RFGdjSdA9Ng=; b=BsBqowxgsurXN+MW6A3LRV+KZr5BOOdjPGZucOjzunOoUzzFfggFvN7yKNzSwsnej2 jxdN/eIYLa3CgaDZHa/TMjgpN1bFfsxI933n5lCbRGMEHivZWxxjsLnEsxS31Lcq+pLb 7mBbZPbm8QijRukU32EyHrwrMX3Kfv95I8JJpSqir2Qt0n58AXnlq5M96SPEPfkUO2gu TnIib27NBNKlzng0Kzb42CkNtlIdVDJrQc+526oo7eVa9/0wi18uNB9TYT5BS5pSYQYH fGJ1oyY1FPhzZv7QDEwkIerWu31gpIITRYW1SLFKq7PVMJvyISezcsGBVYk3NKq/FFib TepA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731435068; x=1732039868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oH/SQSX4OUP5TxQrfvghzIartXS3npm2RFGdjSdA9Ng=; b=HeakYu8Ii0R75PDPv7vFcDPyb3AIRzzxqcUdSRw/kCaU6xlq0V8w9g9QL8t07oooca RIUHq2f1PIDBz5gLE2wZ819K7TL2tVDWP9UbNfaYjzusReDkixNmbmHJ6UafCLJKJ05i DboUnOlqIMBfjDk6vdk9Ie13Y6JUGIPI7tpUka5+dwrGvui0N5um8n70eZ0zmHwesAsm 7x5BHPw2JcupCgwSOUgGFpVTxLGDJ3rSvLHhmv1rnL+mFqa/dia8Kz0LFZdl4Cc7zyPU /o3WvkCKaLERvMlIRNO4waMg4WdwQK5iLwrtqQ2+P6w2vAy5AWB54ZBOiDnHIHfcXdgw hTRQ== X-Gm-Message-State: AOJu0YzC6ANSVdkehh2UqUUtO8w6coOWZjGn9/D0FzjiMdqlbFoG0ZPO 61FLALHSEmVoqJ8bmodXM7ke1UHRvBVmz9JM8CBi8S1GGkfXDGfSNQ9eFY9/cYt64jAg8bRnYtf h X-Received: by 2002:a05:600c:510a:b0:42f:7c9e:1f96 with SMTP id 5b1f17b1804b1-432b74fdee3mr147919705e9.1.1731435068020; Tue, 12 Nov 2024 10:11:08 -0800 (PST) Received: from localhost.localdomain (cnf78-h01-176-184-27-250.dsl.sta.abo.bbox.fr. [176.184.27.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed97e46bsm15765702f8f.30.2024.11.12.10.11.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Nov 2024 10:11:07 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Richard Henderson , Peter Maydell , Anton Johansson , Jason Wang , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , Alistair Francis , Paolo Bonzini , Gustavo Romero , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH 03/20] hw/net/xilinx_ethlite: Remove unuseful debug logs Date: Tue, 12 Nov 2024 19:10:27 +0100 Message-ID: <20241112181044.92193-4-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112181044.92193-1-philmd@linaro.org> References: <20241112181044.92193-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias --- hw/net/xilinx_ethlite.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index bb330a233f..2b52597f03 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -32,7 +32,6 @@ #include "net/net.h" #include "trace.h" -#define D(x) #define R_TX_BUF0 0 #define R_TX_LEN0 (0x07f4 / 4) #define R_TX_GIE0 (0x07f8 / 4) @@ -100,7 +99,6 @@ eth_read(void *opaque, hwaddr addr, unsigned int size) case R_RX_CTRL1: case R_RX_CTRL0: r = s->regs[addr]; - D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr * 4, r)); break; default: @@ -126,13 +124,10 @@ eth_write(void *opaque, hwaddr addr, if (addr == R_TX_CTRL1) base = 0x800 / 4; - D(qemu_log("%s addr=" HWADDR_FMT_plx " val=%x\n", - __func__, addr * 4, value)); if ((value & (CTRL_P | CTRL_S)) == CTRL_S) { qemu_send_packet(qemu_get_queue(s->nic), (void *) &s->regs[base], s->regs[base + R_TX_LEN0]); - D(qemu_log("eth_tx %d\n", s->regs[base + R_TX_LEN0])); if (s->regs[base + R_TX_CTRL0] & CTRL_I) eth_pulse_irq(s); } else if ((value & (CTRL_P | CTRL_S)) == (CTRL_P | CTRL_S)) { @@ -156,8 +151,6 @@ eth_write(void *opaque, hwaddr addr, case R_TX_LEN0: case R_TX_LEN1: case R_TX_GIE0: - D(qemu_log("%s addr=" HWADDR_FMT_plx " val=%x\n", - __func__, addr * 4, value)); s->regs[addr] = value; break; @@ -203,7 +196,6 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size) return -1; } - D(qemu_log("%s %zd rxbase=%x\n", __func__, size, rxbase)); if (size > (R_MAX - R_RX_BUF0 - rxbase) * 4) { trace_ethlite_pkt_size_too_big(size); return -1;