From patchwork Tue Nov 12 18:10:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 842704 Delivered-To: patch@linaro.org Received: by 2002:a5d:6307:0:b0:381:e71e:8f7b with SMTP id i7csp3715681wru; Tue, 12 Nov 2024 10:12:01 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW3jav4yCd3kpPwJK+49yOsZ9FxLs6HX/7gVUBofv/0nd4KQrTXFzTjL+k/RUq0JLhpR1PTMg==@linaro.org X-Google-Smtp-Source: AGHT+IHIlo3zqd/y9kV/sNcJNeT2cHfO4ir9o7SZr48eGsLmEaWI9FFiYftgybsVp91lgpVv380l X-Received: by 2002:a05:622a:1350:b0:460:bba4:1efd with SMTP id d75a77b69052e-463093f20a3mr273744641cf.35.1731435120715; Tue, 12 Nov 2024 10:12:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731435120; cv=none; d=google.com; s=arc-20240605; b=Xbtbq/mFYqVTJtslYVbALBRBZJCMOGp9JrK3WkthFx4KOR7Au3iwH2ozkvvxEoyFm6 vBp0qkgddLUB6wDDhDCUjWRAQENuk+hJnZhINtVi9sL4dbS+0w62ITpHjrG6Sioc8X2+ xMS4ZutQsCxeEYjtS7LidiQv71l7JYODzCMOYdyQ3qUVL8RCZd5jRwAhuNuxXvFZWUK4 QTXBM6M97LrAy4OITBkuV7eRl3lezkJPLd6ZEF215VRf+b1FCz/BJsDERU1xqyPgtseA wrTwChxTK/5OaVOiJt+01Gf2g7If5DGE96Hu61USMUghXTch0MKNJnkwlGW5zltsQ8CM g22w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dxalhuJA3V9Mf8DxAADrs85j1mYwG4uCtR+wwxiXnFU=; fh=qmVcbpKGT2NGruxhf8fgQHnlhHRaRjD5ibgD08FHYfA=; b=gKtWZmxZEqX0OsnEw0M8/NETG5IBRqRM3gcQ97Ca1fsdoA8Mypn7nhf8mmnYl2gg0v DykhB0SMFXU3i3VrjTVsUAivpbZoQgVZoxn3BXaFU2AHmLRHMYjOgMmf2ZWKmJvTEL4X e3SQX6QBdiqOUQ/j/XA1Bm0B8rI7j8uMstPmRUcirm1f+D9hmfMzWNNO/MTH4J9BgsNV ZxTCqSvvrs4D20HcGt7Pi8vLBpYLiSVyFEMz0xbWqd+isYyPWBEnQ+pb/86Ghkhm3XHM vTXhLU20jK0yYQRc7He28cdXAghVEtNJzvbcRlIdacyNrnIneB4l5etBAxOzQTMbcZSF fzVQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lJ9Cm2iS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-462ff40fb15si15069291cf.84.2024.11.12.10.12.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Nov 2024 10:12:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lJ9Cm2iS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAvLy-0004v4-3l; Tue, 12 Nov 2024 13:11:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAvLv-0004ua-4K for qemu-devel@nongnu.org; Tue, 12 Nov 2024 13:11:00 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAvLt-0001rt-LU for qemu-devel@nongnu.org; Tue, 12 Nov 2024 13:10:58 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-431481433bdso52753045e9.3 for ; Tue, 12 Nov 2024 10:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731435056; x=1732039856; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dxalhuJA3V9Mf8DxAADrs85j1mYwG4uCtR+wwxiXnFU=; b=lJ9Cm2iSSpxyAnKMuBy2DLAaFLsRlBMED2NZzfuO6wzTcf390IK9pOi003279rU3dd xoSiRnZDmMeC6INBC0WySIbN5vQfmpDBg0u55uV0/mZgWLxrnPkcoq/oxSygcKT0MaB5 Fw8VTOfkN+8duGSHY4lvXINHnTWz89srKQQZadJ5Xrz3CY6+/tkFhamiR5mTHxeKSZuj 6L/A925S3s9mPJlZa2P1+hs0dBrNqp43UzyyCxEJB4FMTORAoajKhSBEgqgZxPPn6SWL ooRCYm3LImHma2WaxPU+0p+ACNkhPOXdfDvts5Yj9Qr9BiKe75VB8a0Lo40/mdS5iZCr N/gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731435056; x=1732039856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dxalhuJA3V9Mf8DxAADrs85j1mYwG4uCtR+wwxiXnFU=; b=N9cjj8Ra/r2tLCYcHKa9vZLJx7eKnYBcUQoQYZgl1TsPEcbEAzp2hh8OnY9bTfoycA Sc/F6d0iao+faz62+oLXyB3+Gb3a6kKfZ0S7yqX3goqLQdLvzHu4vCjdyuRo2KU+gD3/ ENowNVyPoLgchS8JQeHSIVF3zDHOeRRYIdQEyjG1Z5vY6Gkne+chjZpRpS484CzuainK kaVxKyVMHrgsX/XdB1UwheQ12RbfTht/dFMlAxHZJgyhkg8mhSZqBvwwsycuu9qXoecf OBW7kQgXTWM7NY7AqjbLMKfVPQovQJUk9HX+Ka8uqdzfHH5FvDe00dK2cgBXMQPmaiGJ 3wmw== X-Gm-Message-State: AOJu0Yz8BdyD/559CGQj2Po6iJ/QeFFWjspWXBzY4XlMSCvsCzz4KwiK gNjkiBaKLnqeJHNuVdUQsfFaew7mPo1xc2dJXKHuw5TPRDuHrvTiLh2abSUYjKc6333AyRghOVs X X-Received: by 2002:a05:6000:184c:b0:37d:238:5a84 with SMTP id ffacd0b85a97d-3820df71a37mr43757f8f.15.1731435055659; Tue, 12 Nov 2024 10:10:55 -0800 (PST) Received: from localhost.localdomain (cnf78-h01-176-184-27-250.dsl.sta.abo.bbox.fr. [176.184.27.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381fbf416c6sm7670380f8f.54.2024.11.12.10.10.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Nov 2024 10:10:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Richard Henderson , Peter Maydell , Anton Johansson , Jason Wang , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Thomas Huth , Alistair Francis , Paolo Bonzini , Gustavo Romero , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH 01/20] hw/microblaze: Restrict MemoryRegionOps are implemented as 32-bit Date: Tue, 12 Nov 2024 19:10:25 +0100 Message-ID: <20241112181044.92193-2-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112181044.92193-1-philmd@linaro.org> References: <20241112181044.92193-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org All these MemoryRegionOps read() and write() handlers are implemented expecting 32-bit accesses. Clarify that setting .impl.min/max_access_size fields. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anton Johansson --- hw/char/xilinx_uartlite.c | 4 ++++ hw/intc/xilinx_intc.c | 4 ++++ hw/net/xilinx_ethlite.c | 4 ++++ hw/timer/xilinx_timer.c | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index f325084f8b..3022b3d8ef 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite.c @@ -170,6 +170,10 @@ static const MemoryRegionOps uart_ops = { .read = uart_read, .write = uart_write, .endianness = DEVICE_NATIVE_ENDIAN, + .impl = { + .min_access_size = 4, + .max_access_size = 4, + }, .valid = { .min_access_size = 1, .max_access_size = 4 diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 6e5012e66e..8fb6b4f1a5 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw/intc/xilinx_intc.c @@ -144,6 +144,10 @@ static const MemoryRegionOps pic_ops = { .read = pic_read, .write = pic_write, .endianness = DEVICE_NATIVE_ENDIAN, + .impl = { + .min_access_size = 4, + .max_access_size = 4, + }, .valid = { .min_access_size = 4, .max_access_size = 4 diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index bd81290808..e84b4cdd35 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -170,6 +170,10 @@ static const MemoryRegionOps eth_ops = { .read = eth_read, .write = eth_write, .endianness = DEVICE_NATIVE_ENDIAN, + .impl = { + .min_access_size = 4, + .max_access_size = 4, + }, .valid = { .min_access_size = 4, .max_access_size = 4 diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c index 32a9df69e0..383fc8b3c8 100644 --- a/hw/timer/xilinx_timer.c +++ b/hw/timer/xilinx_timer.c @@ -193,6 +193,10 @@ static const MemoryRegionOps timer_ops = { .read = timer_read, .write = timer_write, .endianness = DEVICE_NATIVE_ENDIAN, + .impl = { + .min_access_size = 4, + .max_access_size = 4, + }, .valid = { .min_access_size = 4, .max_access_size = 4