From patchwork Wed Oct 9 03:17:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 833938 Delivered-To: patch@linaro.org Received: by 2002:adf:a1d9:0:b0:367:895a:4699 with SMTP id v25csp606067wrv; Tue, 8 Oct 2024 20:25:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUH0g/zNTL2doV8vOa+l4rmN4Igt7O1YNfidROUCDlkf9ugH1pdjUUEMF29iqenfMvMRRnAYQ==@linaro.org X-Google-Smtp-Source: AGHT+IFxBDt2O+0Ou7m7OXdNn8aRva6nVoB7yIU5UKjLEqNT4k7g/3cmJI1RMW9JRLvoPbJSyPSD X-Received: by 2002:a05:622a:1a86:b0:458:4bf3:7c5e with SMTP id d75a77b69052e-45fb0e6eb40mr22510431cf.49.1728444315528; Tue, 08 Oct 2024 20:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728444315; cv=none; d=google.com; s=arc-20240605; b=A/ekV3R3YWcSXJ9g88VX8fL/agh/Z1rrco9TIr5cOt8SVVcsyT4wHB6573ZOPlWeOE JqADYtcgQ6u0e1eWWgCgp0Rnr6RirenDg5GFJ6ib3TTL7hp2fi9tlgdCpD2EktQyFqZ5 P17FACm/ODKyAPco5nncaQuf+jPHxFt+nJWwSkXCs5cTlMziGKmmyMrLg9Znm2Q2n9Qz g8KxZ/j4OaPdPd8zW8m3ej4hSLHiZQUFmgy2dWhhKZNWwDT9ZCi8w5r73CfLs4qBdi4h n40kpaCkNxyuHo+oWyUhR9DlAEuUdOAgUd9xRrAESz+Z8dDpTGFcekf0FgP83EbqRpju Lw/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:from:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to; bh=1V0iwns42NhC4Ne9hVW3j5HCZ3gaWUBzlN7RaGXZyac=; fh=4Dgx8jc1gJCFDIGNl8iT3gucG+cuHYR9XmJ7yDXtNzA=; b=STBalVIMHDgiu/ZqI9sFKCe5jEN/r664TuS/JgQm5gs7fyvqmSqmBhtOk92+3h+3Ci NxA0dsAOSdfkxwWz8a+AhkYlT7GAi1nJNh0wnrxAuUbsXRPA8gecnzS5CwpjWaagp2rA mdzjglMir/R2U8Z/9RnbUKegPwOv6RDHmY0Le3EMeLeFeSFuzAYoFkmOt7Yjxi6TIv7H htdxWfmqRlBGdBAYGVWDb2wSSVSez5pCd1CV3bYxGz0uA5XnIDVA0QkgIDLdqHNVBoRc ChGlZfRXV0qLZZhiyzTHwcUMZsVjntTC/bikhA7rzjD3mB07emY4YlZj4nNaZSxjDudR 9oHg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45f0960a0d0si12034851cf.498.2024.10.08.20.25.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Oct 2024 20:25:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1syNJr-0004p3-OZ; Tue, 08 Oct 2024 23:24:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syNJn-0004iN-4y; Tue, 08 Oct 2024 23:24:55 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syNJl-0004ix-2o; Tue, 08 Oct 2024 23:24:54 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XNdXy335Zz6K9F9; Wed, 9 Oct 2024 11:24:34 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id 14727140A34; Wed, 9 Oct 2024 11:24:51 +0800 (CST) Received: from 00293818-MRGF.huawei.com (10.126.173.89) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 9 Oct 2024 05:24:31 +0200 To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V4 16/33] hw/acpi: Make _MAT method optional Date: Wed, 9 Oct 2024 04:17:58 +0100 Message-ID: <20241009031815.250096-17-salil.mehta@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241009031815.250096-1-salil.mehta@huawei.com> References: <20241009031815.250096-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.173.89] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To frapeml500007.china.huawei.com (7.182.85.172) Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta X-Patchwork-Original-From: Salil Mehta via From: Salil Mehta Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Jean-Philippe Brucker The GICC interface on arm64 vCPUs is statically defined in the MADT, and doesn't require a _MAT entry. Although the GICC is indicated as present by the MADT entry, it can only be used from vCPU sysregs, which aren't accessible until hot-add. Signed-off-by: Jean-Philippe Brucker Reviewed-by: Gavin Shan Signed-off-by: Salil Mehta --- hw/acpi/cpu.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c index 5cb60ca8bc..2d6afcfff7 100644 --- a/hw/acpi/cpu.c +++ b/hw/acpi/cpu.c @@ -671,10 +671,13 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, aml_append(dev, method); /* build _MAT object */ - build_madt_cpu(i, arch_ids, madt_buf, true); /* set enabled flag */ - aml_append(dev, aml_name_decl("_MAT", + if (build_madt_cpu) { + build_madt_cpu(i, arch_ids, madt_buf, + true); /* set enabled flag */ + aml_append(dev, aml_name_decl("_MAT", aml_buffer(madt_buf->len, (uint8_t *)madt_buf->data))); - g_array_free(madt_buf, true); + g_array_free(madt_buf, true); + } if (CPU(arch_ids->cpus[i].cpu) != first_cpu) { method = aml_method("_EJ0", 1, AML_NOTSERIALIZED);