From patchwork Tue Oct 1 16:39:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 831900 Delivered-To: patch@linaro.org Received: by 2002:a5d:43d2:0:b0:367:895a:4699 with SMTP id v18csp384791wrr; Tue, 1 Oct 2024 09:43:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXDaPTVR4JxPF6+hk3bhInhr+VozMBCFydnZ6VVRAt8AUpLgii7XbRwQjpKglb0+Q0lpKf02A==@linaro.org X-Google-Smtp-Source: AGHT+IGqXnPAswYJX89/UyV4zmFtbW1bWnKJUSjhpU3j5wRhDsuOvA3In/qg0BV54CxGsZxgWkfg X-Received: by 2002:a05:6214:3282:b0:6cb:3a53:c549 with SMTP id 6a1803df08f44-6cb819b0c73mr1175126d6.1.1727801030976; Tue, 01 Oct 2024 09:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727801030; cv=none; d=google.com; s=arc-20240605; b=eSu67v7QZm4SR0D+K4oK9ZPebtPy8Ma54x/zdfEsvbopBmW8qijRPGlC4NvyJtMt49 tneBRXhMO3To+ELSZeOC+xJtUoQJ4YGnCXubtI91qEl3v/UsHzDmtEwRwN2vYUGyNM7W IvZEAI3GMFhC/9wDh2mXT9LvPWbJ85V6ZFum4UgpT2VL+AOuvxsoz0Du4tcMs6/g9t/0 HnIckj7X9DLnWt4mnZuUuxb1A2PkNKWZbKTkjnnYVC32XyPgJvE4EWpx7ZWYjC4Vk5rB L+Wd/7g1SJbLoj+IPR2Fizz8UbVHUH7WIXkG4rtVZv+JxMOkBDCPaw2nD6oD3W+7RtJB W3lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=pLjR9+4ntpVFrMa71G4Zk/cNxT8KcG7e1lT6CH4TPlo=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=EpOq+diU3jWjpdR8FNT5TYnvvmJfIi76iIIDqjUucdVRh8Y2DYzbE8z+0p0IVyYLvp EPjvbH4naOeUneEEKMQ2XAWUzYqw65kuXSIRHk/nXO8RDqVnnEiZeGdNvQrl7Xf+IYxh QfolIxk1DdgASb/PAieXCAG/6BRtQPQlv7mItN3CP1B/dS+Xx5NBUguqG8ruJAjWcK7/ 7z53rUe1BLiNm5SsrC1a6R3ipmQ2jVeAy7ogboW3GzxhCfVGtm4e+64XH7mu+G4OXYel mN0x/UhIZ+wZPntz1shncNZACgnzWxop+ZH8V/U06SAYTN92ZpXUmFTfGxfmZuL3WcxA JvSA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="N4nA6XN/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb3b6d3976si110240206d6.614.2024.10.01.09.43.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Oct 2024 09:43:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="N4nA6XN/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svfuw-00060f-AX; Tue, 01 Oct 2024 12:40:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svfuh-0005c9-OW for qemu-devel@nongnu.org; Tue, 01 Oct 2024 12:39:52 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svfub-000699-0p for qemu-devel@nongnu.org; Tue, 01 Oct 2024 12:39:51 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-37ccfbbd467so3442489f8f.0 for ; Tue, 01 Oct 2024 09:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727800783; x=1728405583; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pLjR9+4ntpVFrMa71G4Zk/cNxT8KcG7e1lT6CH4TPlo=; b=N4nA6XN/UK97XslqFp55a6hdZOc9P5yZmihDtsnQd1CSN2rPcxej5Rk4p0UcZxC5gg v7am2wJ62HFbw8ZXon7a0DLrCXFDw0iMCy5ywoNU7j8EPFyXDzzs4OkUlJOpL+/HANrG oZqqRsFxfYnWgnJjEtQ3EIm7KEqnozI9BRi0AvWTEaMkyCZ5nJAuF2maaRrmQz5SiBzO HqLBT10WtZ3ZDDRr+AUTxgHmLqVjc31JqzfxXL+Xm3e9N9QJhrzNYB2+fSkQKt7FGT3j Sri98p2lTtnAkLWcPd7G6JZCGOTlpgEWVNjRPNPAAPgk3XQUeybH2PxOMBkoyRKPwf5Y IWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727800783; x=1728405583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pLjR9+4ntpVFrMa71G4Zk/cNxT8KcG7e1lT6CH4TPlo=; b=cSJwu3MAEmp6uRo3Zfq7cysG/Eac5zRL3LfcDDHN6YWZStf1SrtmATGL+TsCdXmo8k 2Rm6IcRklaDM9p+rUi2+wUVXIsNJh4wim+ajNKxaDBfSvPFS+X7WyEkgObIEdhqxzhA/ kBA2HiX/FgfxAAU1m57OsqzvlsZqSRmp+g3Y7WGN1uQ+wrLf7ba33o0b92fQShJbqg2P eyxVAe/NNxwsUYl23dZsj7iuhx6/4CdR7Uffzp589TCcB3yAdy5jvQkGSp/Jbr9Uh5JR +WKNzsQx2N+use06lEtgbyflAUuIPf8T2vDujzG4pEdysWZoFquobiEfXaNjqJnOP05G ff0g== X-Gm-Message-State: AOJu0YyJMZTbV+PZ33XWGiTdKvmGwakOUsNj92vIUJAO4CeqgvVKNqEb aPp8bLinVo6Zwh43FsjIgsKuMS4R1XWx882wnHensHAWKnfKTPrZSf3OOkFx40hMhn9YY+LO3Q3 R X-Received: by 2002:a5d:4d4e:0:b0:35f:d70:6193 with SMTP id ffacd0b85a97d-37cfba06961mr129699f8f.41.1727800783499; Tue, 01 Oct 2024 09:39:43 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd56e6547sm12243771f8f.58.2024.10.01.09.39.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 09:39:43 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 43/54] hw/sd: Remove omap2_mmc device Date: Tue, 1 Oct 2024 17:39:07 +0100 Message-Id: <20241001163918.1275441-44-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241001163918.1275441-1-peter.maydell@linaro.org> References: <20241001163918.1275441-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Remove the OMAP2 specific code from omap_mmc.c. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-id: 20240903160751.4100218-42-peter.maydell@linaro.org --- include/hw/arm/omap.h | 5 ---- hw/sd/omap_mmc.c | 63 ------------------------------------------- 2 files changed, 68 deletions(-) diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index 67bb83dff5d..b0bd1e6f540 100644 --- a/include/hw/arm/omap.h +++ b/include/hw/arm/omap.h @@ -797,12 +797,7 @@ struct omap_mmc_s *omap_mmc_init(hwaddr base, MemoryRegion *sysmem, BlockBackend *blk, qemu_irq irq, qemu_irq dma[], omap_clk clk); -struct omap_mmc_s *omap2_mmc_init(struct omap_target_agent_s *ta, - BlockBackend *blk, qemu_irq irq, qemu_irq dma[], - omap_clk fclk, omap_clk iclk); void omap_mmc_reset(struct omap_mmc_s *s); -void omap_mmc_handlers(struct omap_mmc_s *s, qemu_irq ro, qemu_irq cover); -void omap_mmc_enable(struct omap_mmc_s *s, int enable); /* omap_i2c.c */ I2CBus *omap_i2c_bus(DeviceState *omap_i2c); diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c index edd3cf2a1eb..91e9a3f1c6a 100644 --- a/hw/sd/omap_mmc.c +++ b/hw/sd/omap_mmc.c @@ -573,24 +573,6 @@ static const MemoryRegionOps omap_mmc_ops = { .endianness = DEVICE_NATIVE_ENDIAN, }; -static void omap_mmc_cover_cb(void *opaque, int line, int level) -{ - struct omap_mmc_s *host = opaque; - - if (!host->cdet_state && level) { - host->status |= 0x0002; - omap_mmc_interrupts_update(host); - if (host->cdet_wakeup) { - /* TODO: Assert wake-up */ - } - } - - if (host->cdet_state != level) { - qemu_set_irq(host->coverswitch, level); - host->cdet_state = level; - } -} - struct omap_mmc_s *omap_mmc_init(hwaddr base, MemoryRegion *sysmem, BlockBackend *blk, @@ -617,48 +599,3 @@ struct omap_mmc_s *omap_mmc_init(hwaddr base, return s; } - -struct omap_mmc_s *omap2_mmc_init(struct omap_target_agent_s *ta, - BlockBackend *blk, qemu_irq irq, qemu_irq dma[], - omap_clk fclk, omap_clk iclk) -{ - struct omap_mmc_s *s = g_new0(struct omap_mmc_s, 1); - - s->irq = irq; - s->dma = dma; - s->clk = fclk; - s->lines = 4; - s->rev = 2; - - memory_region_init_io(&s->iomem, NULL, &omap_mmc_ops, s, "omap.mmc", - omap_l4_region_size(ta, 0)); - omap_l4_attach(ta, 0, &s->iomem); - - /* Instantiate the storage */ - s->card = sd_init(blk, false); - if (s->card == NULL) { - exit(1); - } - - s->cdet = qemu_allocate_irq(omap_mmc_cover_cb, s, 0); - sd_set_cb(s->card, NULL, s->cdet); - - omap_mmc_reset(s); - - return s; -} - -void omap_mmc_handlers(struct omap_mmc_s *s, qemu_irq ro, qemu_irq cover) -{ - if (s->cdet) { - sd_set_cb(s->card, ro, s->cdet); - s->coverswitch = cover; - qemu_set_irq(cover, s->cdet_state); - } else - sd_set_cb(s->card, ro, cover); -} - -void omap_mmc_enable(struct omap_mmc_s *s, int enable) -{ - sd_enable(s->card, enable); -}