From patchwork Wed Sep 25 11:10:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830455 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685313wrz; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXuCWux0iBT/aDInH2tvr2T2zsgbMn9V/7pP6bMXDTrnxunWGyz4dzrHY2k1vlWI8sFtzVS9A==@linaro.org X-Google-Smtp-Source: AGHT+IFlCvh8exmdd5p0fRQX0VMZ0Qnm3D/ayY6YHntKxIuRkzkUSDD3f+UAvqobHfjF9Fq7aCUF X-Received: by 2002:a05:620a:1996:b0:7a9:a810:9930 with SMTP id af79cd13be357-7ace7402f62mr356079985a.23.1727262881280; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262881; cv=none; d=google.com; s=arc-20240605; b=gsipNN0ONrGBZ7qX8GDIFf1qnljoY+HejoHDbKFnK/BWD+Qsc7wIxuAHNBBahpkNPR 3FDR7CPPITOeT8SeROI0ilUKR7pajGUnf1289xG9zQs0TJLuTzj/6X5oZZKMq/DT2WIh 3vmCgrw/erLrPxQfHQb7q4XtR+tlrKMJ6ylSf1W0lZyGDDJszeDdrLfEXagooRF7w1BS XBNIo//uU9bpFaNjGG8LCJF6+heUBqZRyG71uy/It/+qqFquUnqz9GKoeCn+mldJGR1T DXuTEYdsdaBfTuxfs28k4OJszAdhAUUTm/h8m9eNa0uSLX3J/RUh7kb6dgAsRusNuAns S21g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vyo/LNnRGhGjQKrTujAh2NlkCB5//86Ns8KFFI34pWI=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=QTv90WktdKsHuMnV8CqftBethqqgbzHUGYNPFQqiS7HQ+rMNCDABCMDKDm521nKvE0 pzxcFsPv9ZKeoFwcyL3cI2mK3uCApsjrEy3NhNDlKBiOSnt3i80SpJAuGwYU+8EEVle2 +eVxT9/qSoZYNzw8WRqe53UFnoplLbRDD4PiRailxUoiinoc64Wv95V8/m47zj3eFN7s qK6iXYVO02D2GmvkTohrPmzNsEoo55C013iyeIGej46EuoYKsXGthi9K0a+ryionq9n9 +zB7fAnVnIP5gQl2zbjXe8mwTke3w3WI0c6knzeie9IYWwdhBr5ntR8C2Rvvf8NXN+jy Z/Bw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UnvHQGl6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde646bf3si373801885a.725.2024.09.25.04.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UnvHQGl6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxi-0002qv-M1; Wed, 25 Sep 2024 07:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwX-0005yR-6T for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwV-0003xk-K9 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vyo/LNnRGhGjQKrTujAh2NlkCB5//86Ns8KFFI34pWI=; b=UnvHQGl6cUnta7lbJ9H36jrEBQg7o0USmKJAuLVHXklGYnhkGRH+tOrYw7EAV84F4yRBEW 9oiV6gBS0VwV8tUgLznKLeZjN4LrG4CiN8R0tuO8EU6VqH8r2AiSHZpDpoa5z7tco8o7RQ S36utVO0nhLEGbccdo+9cKBSED5F7+4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-B50DJvwZMZq296UnqNY2dQ-1; Wed, 25 Sep 2024 07:12:18 -0400 X-MC-Unique: B50DJvwZMZq296UnqNY2dQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8BBFC1977034; Wed, 25 Sep 2024 11:12:17 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE74A1956094; Wed, 25 Sep 2024 11:12:15 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 39/44] qobject: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:20 +0200 Message-ID: <20240925111029.24082-40-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-32-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- qobject/qnum.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qobject/qnum.c b/qobject/qnum.c index 2138b563a9..dd8ea49565 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -86,7 +86,6 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) } g_assert_not_reached(); - return false; } /** @@ -124,7 +123,6 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) } g_assert_not_reached(); - return false; } /** @@ -157,7 +155,6 @@ double qnum_get_double(QNum *qn) } g_assert_not_reached(); - return 0.0; } char *qnum_to_string(QNum *qn) @@ -173,7 +170,6 @@ char *qnum_to_string(QNum *qn) } g_assert_not_reached(); - return NULL; } /**