From patchwork Wed Sep 25 11:10:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830460 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685427wrz; Wed, 25 Sep 2024 04:14:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX7lZTICVvcLl/LCU6v1G7tytBphxFWImQoAq57Qc7ZsdI1rpnKJ5c0K2VH25+CyL0Wq7UOaw==@linaro.org X-Google-Smtp-Source: AGHT+IHJTfwB23mwPSShH+GY+r425krh4VzUncdd9uqHz+zHKfSCxbdxchD5db4d8U6aNAz53Ner X-Received: by 2002:a05:620a:2912:b0:79e:ffc6:c435 with SMTP id af79cd13be357-7ace746bcfamr334830085a.63.1727262896080; Wed, 25 Sep 2024 04:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262896; cv=none; d=google.com; s=arc-20240605; b=UqcpjzaAenMpx1U/sKWt2xydvWqVfAiCiTBIyUxl12/2tSRzV/dh25a3CFf++J9wOQ E5m+uH0I0pclRd6dvjWEuDiHM6mkVy3jMDttd+5MqIND1+CvndQsaj/q3kQ3Z6mTZNPb 5CSkH5rr3mahAY4l0MN34nxdZ7GPmmoiorIqXMkUx0VXbpFYPEOVvUDK0WksQZOda3ER Mkeg80G68ge472/WPmEPJF4Z2GKgp+umwTCAzSOkLZah0qSc9EOqCzL+hiImvnBBDJbB g21s+wSrmE1Jl1J5MhIIFQYvHitZVAGphXohkqIgRxQvSkDEyL6k6nVwRuCX+GKGU8Mk p3HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6/D/bPRFDYn7e9OOx5Rf9mgT3BrXmKOcHZORCuS7GII=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=D4XnyZ9hXYRM6toBRuZ0LCPrFlAa1sekElUFOe//dJfRCQozoP0IJcH9EPIjgR9sQe l9CEWaQqKGcj4ehynJ2pSAh/ZaOgv5irYcypsc9y41ch0aR/mSZoOOP1rbJnvtQn+YC1 8/NEDxU/bepBEmZJ4TKcPQepw58hgeMZVZFp1+vNdrQM+8XXQXFuE4h+VQ6MYj6wey3h o2AuEBcOqfmLCTmQzbqxWwcwNXoyZQFNFBixNfUh2jKpUUz+jnS01acdgeohiwpDnV5v hBWHM8gzeRtceiiIypWa4eILfZAcWX8Rg6UMMEkpYCak1yW82ePicOuT8rWfVzUSWFkR dz6g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dtrY0VSV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62e887si410629585a.563.2024.09.25.04.14.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dtrY0VSV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwf-0006Q4-Vx; Wed, 25 Sep 2024 07:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwT-0005hn-NW for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwS-0003wL-5P for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/D/bPRFDYn7e9OOx5Rf9mgT3BrXmKOcHZORCuS7GII=; b=dtrY0VSVqP8+yYpERPiV5hShVGETuAKm2NNUaWwZiCzbUkfE2Vif2XaQk8/QnpH3w0tBcP Lrszx75D7orbyynM3Kc88UeaTjd+vGf9K29OyXlasdji5VaeXWVuMNpjj/R1iZ6oHW1igY VAbqphWIf61u5ddFpbCz6wzWXs2usAY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-NYFunm4iMpC61fgE1iq5AQ-1; Wed, 25 Sep 2024 07:12:16 -0400 X-MC-Unique: NYFunm4iMpC61fgE1iq5AQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A473193EF47; Wed, 25 Sep 2024 11:12:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32739195609D; Wed, 25 Sep 2024 11:12:12 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 38/44] migration: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:19 +0200 Message-ID: <20240925111029.24082-39-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-ID: <20240919044641.386068-31-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- migration/dirtyrate.c | 1 - migration/postcopy-ram.c | 7 ------- migration/ram.c | 2 -- 3 files changed, 10 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index c03b13b624..5478d58de3 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -229,7 +229,6 @@ static int time_unit_to_power(TimeUnit time_unit) return -3; default: g_assert_not_reached(); - return 0; } } diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index f431bbc0d4..0fe9d83d44 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1412,40 +1412,34 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { g_assert_not_reached(); - return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_wake_shared(struct PostCopyFD *pcfd, @@ -1453,7 +1447,6 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, RAMBlock *rb) { g_assert_not_reached(); - return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 0aa5d34743..81eda2736a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1766,13 +1766,11 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { g_assert_not_reached(); - return false; } int ram_write_tracking_start(void) { g_assert_not_reached(); - return -1; } void ram_write_tracking_stop(void)