From patchwork Wed Sep 25 11:10:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830468 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686177wrz; Wed, 25 Sep 2024 04:16:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV6kRd21C5+AGWaWMTARHSJpxxNxDzCSUVBp0D9L6uffKD+2g7M9C2oulRfcEy+mJ4ZN8I3Pg==@linaro.org X-Google-Smtp-Source: AGHT+IEPuQu4rdLGi98Tfq2tTvepzgNKsF0vP5IFJCIaWEjIVjZIJCEK5QCDA5XM2bqlUb8dbL1O X-Received: by 2002:a05:622a:14c:b0:44f:f83d:469f with SMTP id d75a77b69052e-45b5dedea72mr28772911cf.14.1727262995580; Wed, 25 Sep 2024 04:16:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262995; cv=none; d=google.com; s=arc-20240605; b=fZVBvm8XBWtRPeCPz2ub+Lw0NkTSwi8972x2cNdTG8A0l3AX5T0ND97iZo6m+wRh2N iwP4Hp3fOc/Bj9lpy4pw9TnGni1+k/MKhgGWRpx7mfpdngQNtVwnYP2NgA+JpeRgAaNM bgezm8iFAIlW1YcVgQN/xrcf9Wpx9IDLRUXS5Vp1k89dGBwKFQ1Hdwa0ZDjkTZkxHNkb I2qsRUSQxsurWVce17F4OTNaps6WFnBKiDc8KNBfjNu/8c+cfUySkGfIAGWUE5y4pl9p ykBPfMCiMU4reoXJ/zJjb2t22cejLKow7AJ4nTPbsLohEEIbcD9dm8YvOvAoz1/OxQe6 hMNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/hiFZFF8hncyDRf8D3JNk/9vZTYM/dpbNvOPLfGO2Lc=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=I0joWERceWON+kR5PNYcp2nvPK4EMn11qR/4CORed7Bm0dhRSw1fYDZJF5kuC0ZUCU R9wwmIKUCk91ykKwGmQOzgCY/dp1kBI7Yq9wPysDJvP164OffCMNhO48xlB5ngihYTvZ F/1s3v7TlmUDKmB1NwHDe+nJkFfjyF1T/auMsj+2MhqRSxDZ1TiHJbMO+F2iIaq8AYcz bu9ORCeCvLI2ttH7yj8yfDbawissxYUKnbIZdcaBNVC8+JOMpeUQeO5M/1o4pk9W2AZ5 IoXk+IzLU5DZU7cN4dBsgMi8ZhjcTrY70/XODD3uZUXuup1c3WSsvgSaZx6JRia4dZby XDqg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eo/iEryQ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526fe17bsi35950101cf.583.2024.09.25.04.16.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eo/iEryQ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxu-0004Jg-Dy; Wed, 25 Sep 2024 07:13:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwP-0005Lm-Dy for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwN-0003uQ-Vb for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/hiFZFF8hncyDRf8D3JNk/9vZTYM/dpbNvOPLfGO2Lc=; b=eo/iEryQbrDCCi+8X26dqThv51IIhJuELVXboKB847gst1xEYzPtEf0f//nNHSo59b6HbY IJfFk8FeedMf03LQs+tuNRnq2yZLdZDNbW5djfNH2zGBem8fSXIegmIVLtYmRRA/HsbNTu M5CJ2w7WBcuFjZweF7nh1nW76fElqGc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-V0vj0oYUPJmBobGw0GdNCw-1; Wed, 25 Sep 2024 07:12:13 -0400 X-MC-Unique: V0vj0oYUPJmBobGw0GdNCw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E8471944D69; Wed, 25 Sep 2024 11:12:12 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5D9441956094; Wed, 25 Sep 2024 11:12:09 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 37/44] hw/ppc: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:18 +0200 Message-ID: <20240925111029.24082-38-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-30-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index e6fa5580c0..fde4619412 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) break; default: g_assert_not_reached(); - return; } } diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 38ac1cb786..4dbf8e2e2e 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, * that don't support them */ g_assert_not_reached(); - return; } if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) {