From patchwork Wed Sep 25 11:10:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830447 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684981wrz; Wed, 25 Sep 2024 04:13:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXpfe0eYb89uME3Lh5ksGioIldooSSDEdzJtCppSWwMCBiw5GiFNWjms0CpR4sEmyIp30QlvQ==@linaro.org X-Google-Smtp-Source: AGHT+IGeEoavgdPDO6O6WCbdxJX/YvdRQ/aJiYxgYjUP3ILRDEwJDhmElEkH3tB9sEAk5pw+LCLo X-Received: by 2002:a05:620a:d8e:b0:7a9:be2f:651a with SMTP id af79cd13be357-7ace73e2becmr390117985a.2.1727262835401; Wed, 25 Sep 2024 04:13:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262835; cv=none; d=google.com; s=arc-20240605; b=QZaRJdmu4hjpIXPiHdiFZfLfZXAjhK2FE9IV2bZoBsRBbFk9U8v9MZ8yJxss/hvUhl rXNuh+jt6l8fJ6ekp2fTQ+kWQ91F4D1CwUfB+81hqVOORbp1avfvPU9QWL8DeHwSOEd/ kKxXiNI4fko+mKgqL6G4eZc9zxDOB4reBpf3/wDbiFM9zqQLC+3Lid+8p9uieuiVFAZ4 8FACM0r2ZRYYGjJU3GWqNLGVupsIh405ldWik4WgFKRmRSWeA4OIutrTnr4+QHtp2vou Su7gTrACspoObLR3Hc2lPAZhuKdX8FKiSzy4dJM5z76/+dHIXFzhvvIbtxT6CEEsnUA8 EDHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8LsBFPRu54OFkPpjDHCv9iByYs2suDLcoK9INDup2jI=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=YKi+XRmbpStMcHO9JBwvMXhU/zTmaYDrG9n4Pc6fFfEiAr8aFR/NhVklr0Vm/UL2gm 3LtW1nwLoDm2kywriCoi5bV9o2uUz3Jj8j4LcnIalXT/gG5pgb+zSIeRQkREbnk0EmDk TocHlsFAzKuuX4Cn1Jismn6Q+MqrSK5UxHGnFs/T4CZcIpBQhoh4QhGdwwxeCNxR+u6U j0fVmqkXC0PTRvmX+JjdqMKJpDKtRJtikC2V6valLT4m75n72h9C3IztuKR2X77LQ1ku jz62TLSkApoheCCgrNd04zWnXKwxKrn+XRUJcTdwpMg0f0i+a0/2B6jLuFmht+qmHmpG qNpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YxgrZbuv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5cdc7csi375547185a.260.2024.09.25.04.13.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YxgrZbuv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxN-0000jG-Ab; Wed, 25 Sep 2024 07:13:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwM-00057h-Fi for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwK-0003tO-GT for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LsBFPRu54OFkPpjDHCv9iByYs2suDLcoK9INDup2jI=; b=YxgrZbuvpfDPOI4QdCCSKCNDlQPQzY40UQWYdWincSLdxOwsZAy5ec1RXqkCJvqQ629zUm FTgBLdBD7qhjBbNXrwTbTT8UQS93pPl1ZhUWLwB5WxxiUB0HBK9NHkS3OwgcyThaUVJRZ5 VL0hQJJMNMRJYvUpTrQAd63cWUGxQLo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-wwPKFfxKM6SpATKX0K3E6Q-1; Wed, 25 Sep 2024 07:12:10 -0400 X-MC-Unique: wwPKFfxKM6SpATKX0K3E6Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E0CA193E8F5; Wed, 25 Sep 2024 11:12:09 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0F7931956094; Wed, 25 Sep 2024 11:12:06 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 36/44] hw/pci: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:17 +0200 Message-ID: <20240925111029.24082-37-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-29-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index c6950e21bd..3397d0c82e 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -47,13 +47,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { g_assert_not_reached(); - return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { g_assert_not_reached(); - return 0; } /* Required by ahci.c */