From patchwork Wed Sep 25 11:10:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830462 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685810wrz; Wed, 25 Sep 2024 04:15:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVOZg6F4lW47UosR1zaCl9sy3RbMdGKT6IwKRQqKDq+JrrHlxcZRjaCXhGhP2zLblcE3J9rxg==@linaro.org X-Google-Smtp-Source: AGHT+IHGs4hE/e6NPVZLMhctS9VApdK7qvFiSmUDO9WMmKg0e/Vo74ngdCJvhhcbo9Y1qXlbSTfk X-Received: by 2002:a05:622a:5b0d:b0:458:52f0:9bd8 with SMTP id d75a77b69052e-45b5e0a9e36mr27185561cf.53.1727262947486; Wed, 25 Sep 2024 04:15:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262947; cv=none; d=google.com; s=arc-20240605; b=e7KNjOR+5pzEw+uQVvwf2d9s+ApP0oESK1c/oV/XJGgsYMtCz0VSecjzX+3clE4w4E vK9w9sMnBupPbYX1DNBOgEBjJYBxTiwDAJbhn18KKZht6OtkBosKNp1g2GoQ8VS+aJKD Udih0mXaSoLUwMem0nFmsn9ky3BEEZ+ogfNcmMuRygXywVGsmRv3ZfbWZSlJeOdNwVUA FAGGNpKpY3eYZwiL+xmZCus+I5eOimGLPDRHqN4wHpJ284j/dCcevZLekYXKg837CNni q70nMvF/7p36rt9ECuDgNMrurAT15foxckLLKPQkiaoB4LpvwfPM5Lb8tUtbyHnuRUc5 iRGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wkzBGKUlyRgU9QQA/Wd3XK/yIj4C76VWmvHNoa80fTE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fxWgmwZeFHSW3I/I7rc5WN8KZYjx0McBiZAgRbVPs+iPOsvLvP49NNPnU0BhlTwIFz VGdFy/wAQuyR1w/P0u4ypigxnlXvOnGRHFhR07nkC+lAtWGKOG0IdtxzNIDOwLRZsaCR Rs84eTqzritk/3FPnhYhbHmYQEYBY3WLVRoUWW2yP21PlXl2C66hwOCTjCRXvg4XzlTK ipDjAdojJR2SYjzk3Rosn3xR+Kpe7v5PaMHz3dZdPWcXOcCgrztlbo3krGRZtFIa+V7T +ifhB5znCt9/Nkgw7X/FsdgZXmJFSYDinNECZKS7ct3dgek2ua40V95QJlNsdmbqNY6C E1nw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QN9NuGXm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52748a71si38578811cf.672.2024.09.25.04.15.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:15:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QN9NuGXm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxl-00035S-GU; Wed, 25 Sep 2024 07:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwJ-0004s6-0c for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwH-0003s2-In for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkzBGKUlyRgU9QQA/Wd3XK/yIj4C76VWmvHNoa80fTE=; b=QN9NuGXm+8dFP5WANmh0JENlLNSLpFEDYCQ0t403vXbg4tpFcXLGEE9gCVWBkghcSjd3xQ WxcImpk36Skq3ZC3J8mGpKq7PeWf9wjAOCrtu0ZjATTGMGNvoiGkmsmgKM3e+QXgE2Xhc+ zC8VDTgMVQ5n3AwDKDh9FllN/DSTg8o= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-HawtOaWrMq6rbD9oxy_nEQ-1; Wed, 25 Sep 2024 07:12:05 -0400 X-MC-Unique: HawtOaWrMq6rbD9oxy_nEQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FDCF19332AD; Wed, 25 Sep 2024 11:12:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8718E1956094; Wed, 25 Sep 2024 11:12:01 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 34/44] hw/hyperv: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:15 +0200 Message-ID: <20240925111029.24082-35-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-27-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index ef50e490c4..a630ca7047 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -89,7 +89,6 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, } } g_assert_not_reached(); - return NULL; } static void sint_route_destroy(HypervTestDev *dev, diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 03f415bf22..b36bd3d67d 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1890,7 +1890,6 @@ static bool complete_create_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_gpadl_teardown(VMBus *vmbus, @@ -1947,7 +1946,6 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_open_channel(VMBus *vmbus, vmbus_message_open_channel *msg, @@ -2021,7 +2019,6 @@ static bool complete_open_channel(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void vdev_reset_on_close(VMBusDevice *vdev)