From patchwork Wed Sep 25 11:10:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830450 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685091wrz; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXu8IUK4ed5BSe+vlh40vQn1nr65KqDCgwbX7WiVvbjaFqTyy4IvY1xCQ/eKb+bTwEtic3qGA==@linaro.org X-Google-Smtp-Source: AGHT+IF8/WbAKo9JJ326BMfhCJiBJYrL+jGkQDrXldT0Ziz0DN0PjxY0aDNWjli9ki815m3v0gLw X-Received: by 2002:ac8:7d8e:0:b0:458:532c:1e66 with SMTP id d75a77b69052e-45b5def47acmr31949251cf.33.1727262847736; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262847; cv=none; d=google.com; s=arc-20240605; b=M1BM9Y9YimPiy8ELgfTRupaU3hGf3IO+53pDgFWCvoced2Bs8mwPjvPD+YJIpLqRCZ liknoaZaupJG/dfFqm/2v27IyUix9nUtQTX+CbWbRg9BXRhrQcJBJK047ddi56cVkEsu LfaXYAntcFZspS8n/6jCk2+XfVI7FGQUNkXcFzRLlB7xh1jZaVV1gLhYI5ko295nOJaI YUIpRQ14wep7yMbeO0b1EzYgCyJnhLKeeH7Y0ChPZjRWVGdMR1ol84t9eySJWFCnOik2 a7AvtcSJFhNRkVOTRoBq2exa1cuR5iS0HeKjGErf2eUnMqlJbnG1jxrr13Gf8l8HCckV J8Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=psomKvE7sW8bRpqmZzwDOu56NbGS0iusAAvNKLEfVT4=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=K4mfYugBaULlsjaF8wRWoaHUr4j1dlhVD46B5fnAYFhBBUHB/V9ICw+Q6y5HwlbGF5 Ek4//dJML3WRWLuQTChw9iYq0k7VhaboxoAgzS3XnHVaRKh2f/YxA6u4yyPDHatdLrDw hmrASh2pjzmNBnRv7qzCfrnMVh5zW4xs/aCSIdp51fbbAq6nYpe5JUl9TKqZGbiqqstt RQUKz8LN7MHMhI/zO6UipV+K3V4ts7fuxVWjCZyy5NPefPQydyGgNSyPD71Do3r3b9n0 bH8goEhE0ITfQ9s4V9o3jo27YeXM2J0GXRxavAG5kQG7gGh/O5ShF5XKgG1ljxIx6b2M dvgQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJSKJ4Iz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52570cddsi35752051cf.31.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJSKJ4Iz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPw5-0003mO-91; Wed, 25 Sep 2024 07:11:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvw-00031n-3h for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvu-0003jg-GK for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=psomKvE7sW8bRpqmZzwDOu56NbGS0iusAAvNKLEfVT4=; b=OJSKJ4IzMWMUFIFKgVYP7a4Ns6Pxq03Ti7RvfLQxx1CblYHVZaBHV7MmZhc0BHf1WXH1dY jbfy1hHPS+an3Fl97K0Fcu4lK0z9ejIJ116uFxYn8nrzMH8iB/VkczbOFvi3plqOBbyYOz 9OGz7uNyXexgAGCGg8intIqznUSKKjo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-PQkBNgS_OHiZrSxqmfz8-g-1; Wed, 25 Sep 2024 07:11:40 -0400 X-MC-Unique: PQkBNgS_OHiZrSxqmfz8-g-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A76561944D25; Wed, 25 Sep 2024 11:11:39 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 19BDA1956094; Wed, 25 Sep 2024 11:11:37 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 24/44] block: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:05 +0200 Message-ID: <20240925111029.24082-25-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-17-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- block/ssh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/ssh.c b/block/ssh.c index 27d582e0e3..871e1d4753 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -474,7 +474,6 @@ static int check_host_key(BDRVSSHState *s, SshHostKeyCheck *hkc, Error **errp) errp); } g_assert_not_reached(); - break; case SSH_HOST_KEY_CHECK_MODE_KNOWN_HOSTS: return check_host_key_knownhosts(s, errp); default: