From patchwork Wed Sep 25 11:10:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830471 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686229wrz; Wed, 25 Sep 2024 04:16:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXrwqUHmCTuUcwqNr9DD7sBWhTuyviqVoZa+W+dnUcVcGMnswlmIgJaZt4+wHrcRGBkW9Ff3A==@linaro.org X-Google-Smtp-Source: AGHT+IFA7VAhqW8VxSAONodxc/ZPACXM22NV87jJpE/Tc0v6YQpU+R9UEss+x999SUnSmMLUyvGz X-Received: by 2002:a05:620a:2489:b0:7ac:b220:309a with SMTP id af79cd13be357-7ace73ffaabmr334061885a.15.1727263002701; Wed, 25 Sep 2024 04:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727263002; cv=none; d=google.com; s=arc-20240605; b=B0nQcq8XrGyhQEwyR7iOIal5wJUjrCbtShKcgBIL2c0GCOEEWxIqRGG65ONPqJnpim lMqvt+ufmImOMPZ9PLDJ/xKBvSiIxKgA646P8CZfCwtPnGBNbzTuSz5M3ogXqQTN6Ja1 SAkEN0I/aS2t0HJNTqvUH2V5nQPvZLjXXIVeFks2UDdoiGg6CCd+Lr7uxG0GBYP1DD/3 PjZ9kmTTF2U7RRbzz7CCVu4NVzM3M099FNFyjRBu41EmMvbH1j45IqbZjXxOw6IhixX+ GviaCEnlKEmeP2OapY7+oLDPGuhF3lKuO/fY2CBg0J7ue0t5xxBaM012/SkL8NY4FfMf T6kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/kR37MkxPuif1Gz9ZYXpS2krMiMxAaq8SdO6bqCWHmA=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=aTf8BfX39x36kRxTagtWCJLslMpvmvJMZYSKTQgHu/H/kJ1ud4tRfooF+ow5OFvgR3 8PdbdCeJVhr7FOBOTLQzC6xW72vvPrPcLi0pE7+PkRpiqZYDQoVCoBcuNzOPdhkGvDAz RHCCZpKc3y3lidn21wYhT+CGbpWh9DQjTl1cW4z1gSlhZwobMknvSEfkHOkI8//kIP/K 39dtMe0khH1gDif3v39O17gO9osHu4gQCH7FWlY38davbeuiiibgLfznnzh4OxAqLSd5 Q3b2s8aiTkMpNbA0ZJ1kxIf/PmDSUbbJAiXfHvyWXbKS5CFsCpmRunUsNNiCgFmiybNK ZolA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HZdYeQMq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62f543si384908685a.566.2024.09.25.04.16.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HZdYeQMq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvu-0002lN-Se; Wed, 25 Sep 2024 07:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvp-00024W-RF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvn-0003bT-R0 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kR37MkxPuif1Gz9ZYXpS2krMiMxAaq8SdO6bqCWHmA=; b=HZdYeQMqIy18nPMXt4nZlJlzj2f/EDb0YNAMn8wDM15Y+xP2xUEBe7VnW17A1bA6zO/Vyw m6ve+eObK4g50n5I3qqQ/HLdbb8KT8QLdlfxd+ZGikBMTeyhErsAyLe59rTeJympfb2WY/ UP+rfbfD9yvhz4AH0UauJjKXhcxWJcc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-pzWi-xUaNNCN93WTMHlTzw-1; Wed, 25 Sep 2024 07:11:35 -0400 X-MC-Unique: pzWi-xUaNNCN93WTMHlTzw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB2F21944DE8; Wed, 25 Sep 2024 11:11:33 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 222661956094; Wed, 25 Sep 2024 11:11:31 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 22/44] target/i386/kvm: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:03 +0200 Message-ID: <20240925111029.24082-23-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-ID: <20240919044641.386068-15-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ada581c5d6..c8056ef83d 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5771,7 +5771,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5790,7 +5790,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning;