From patchwork Wed Sep 25 11:10:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830449 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685089wrz; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV/K0+zmBByZrtFcRNLAfT/Xdy1TA576Ouk4x/H552Weq3pZGVPXBb4g4HB4dRpfg1Saoydng==@linaro.org X-Google-Smtp-Source: AGHT+IHOum/V7vGBy9qCQjy7P0JJQ3wz5yqWiDXl4ysj23uQ+qZQeRI0al81ZtQQaIYlcyiQpNCm X-Received: by 2002:a05:620a:1926:b0:7ac:a10e:4e5d with SMTP id af79cd13be357-7ace7157d89mr428129285a.0.1727262847620; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262847; cv=none; d=google.com; s=arc-20240605; b=NYupULxvv+82yEpJvkhkQjBvRlZKZDl+VhzX1/fzDlz73y8EmW1xCeMGJ14F1RDj1B O2atDLsSsgd0uAXmFE+OE2M56llWkykCRr+lmYuWhFju10T7yRr68yhkWwRQOQkkCkYB CCy7e7bIj/OZ/hXAN7KIvwJcDsraYHNfH/w/eduwf+YipM7QO3yyo3ISmLVuGgentOPs km6JbWaApRCQqoa84y+MI3R3eGQS2G5Db6g84DGSphyOepYDpCsQY7GI6a+uEY34zAqt 1+J1l52+q5eLdDRlyDzAGdvBXVEBREgcwAYnNswfR7VyMTUnPWXd0p/HthHHzVltFLjX RZZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Od7z/DXKTWdjJQuh6kkHYLvKEg3qnz6S+3xr8klpiPU=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=K4RHtlFECVfRvXFVJ1aZH7ebeoaElhw59GeP2Y/nRtkPjCigoeZt0DHYEjih0OZkXS rxVq0+XaCdHqNirtCX1Q8HCKlnlJW1PRYgKHuDaIVXJMNPpoL7W4hK3k+Bgirp0XdtFR N9SCQSfy+4b/tM4N0aFoBnMn6nxcdpqkF+3Ayn+Obh2/wNuYUeSRP/WaEv4VVPjEY/wH FTRoi4K8GLQgOVzKHJWFyFxjkdtfZuHC2jEAvASYm/gaFwJp9401hO4W2sZmOjrXc1CJ S0mYSqfNMQ5gNRdbNQCyF4+XcBOTNnXhpuZdTA/vaLVxKsDlaRFD3DASTpMn/+sWG3eM X7Gg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYWdM8n7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde60b93csi363974885a.460.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYWdM8n7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvm-0001iO-9E; Wed, 25 Sep 2024 07:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvh-0001GQ-KW for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvf-0003aW-RR for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Od7z/DXKTWdjJQuh6kkHYLvKEg3qnz6S+3xr8klpiPU=; b=WYWdM8n7q3zLsGYkcHrOQKtYMjY5N6WCetPkethe9BMegv9Boqjrh4DREZnZ4XxtnzteYL /373s8glbTD0JscECd3GvPp464yRMyu/364C9EdPv9bw8GI94ZavSMxATHYgg6L6ZJ2kh4 Tn4v7HC4tPDexB7ReO6NKM3UNH/S88Q= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-jL5lj4kiPhOS-0bOH7vZRQ-1; Wed, 25 Sep 2024 07:11:27 -0400 X-MC-Unique: jL5lj4kiPhOS-0bOH7vZRQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6E0E1944D69; Wed, 25 Sep 2024 11:11:26 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F5011956094; Wed, 25 Sep 2024 11:11:24 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 19/44] hw/pci: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:00 +0200 Message-ID: <20240925111029.24082-20-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-12-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2..c6950e21bd 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; }