From patchwork Wed Sep 25 11:09:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830461 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685507wrz; Wed, 25 Sep 2024 04:15:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV0v/fbZAxnu1dmSCpwFxnCngAQjReZRSoa+8kgv4kYQLZsrAj0NOKQjDEMfJH2pe4OFTV0rg==@linaro.org X-Google-Smtp-Source: AGHT+IGKDW+h5mVJDJf5UI6lChK7RuAn+5baadbACMUdhvbBswGVj9rdMgNHSuFrLEWsrQRVlC5l X-Received: by 2002:a05:622a:206:b0:454:e8e6:1474 with SMTP id d75a77b69052e-45b5dedf33bmr31453981cf.17.1727262908461; Wed, 25 Sep 2024 04:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262908; cv=none; d=google.com; s=arc-20240605; b=bAm3PTFT49uiebAp1yVj3QsJQ6Sj9NQdlC7Dff8jcRAOikyB319di3QNhPhLX9bxyz 86qMKh9KLJtmQlok8Xmb91FmIB5HQp/+v9qIxpDbfQnTxxHZ+jv+P2LOOxCiVkL7waPF G5ajt7DMydt2d0TG4Jp8tIO91DbKfXa6prtUqWT+cawQXg02bYW0A07Fbg2Rjn3Y9/rq Z5qbtFBhPQ6BaNnCoNzG7D+PtTuW9Dkn1D2kdh7oZS2Cgi7JG6VTl1VVEtXfx9NR55dI 6t0ps6NS1DdYBfWm9cPbc4a5za+R9PykOlaEYQsxCj4JjEwtBn9dhkfFL5GM1jOgcsWj g2ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IGGPvMcSuORdD/jdCdMnCbXbJ4EG485+NacBfw/i2Xc=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fe+q+zpa2JgGuyrGEQtGPLTQALr5xCNRjWSInQsjefCkWyz3jSovTh6Y4qkAi7e1Mx AcTCvXyayzTwn7t5hXAcfbVS7AGoG+nWHn1FFDTxxkecl5cRaYua2a2OLxKZ2jSBnP0V W0WeM4JNDSR74Abb09UFP3yJMFgCFKrHHCrH8Ce8I5kV5rCANeahRLCUm0tEKzAQUiRB 69nM1uPMUQIBoWqMODmi3EBLm/PSxQUymobWqQcfbyM9gnA9VWW45kIgyejfLfraUrNv KJviI2J/y+J1grAU0PFj0oKq0Gc8aTwww9CIW73rc9k8Wv6xAErnP5Jyumdk/1DjjcJJ HQJQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="M0LZw/ec"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526820c5si38639931cf.265.2024.09.25.04.15.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="M0LZw/ec"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvf-0000qv-RB; Wed, 25 Sep 2024 07:11:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvb-0000Zb-2K for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvZ-0003Yb-EF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGGPvMcSuORdD/jdCdMnCbXbJ4EG485+NacBfw/i2Xc=; b=M0LZw/echS6CU7bR2mls1WwAyTmiJi0BkcziLC+csdBCunFM9XfpIsAqJ2J0/uHFHvcKi5 IO++O1NArhZnvj8CaA/+X4uVWJWZOICIXP1xznrj7mS1hO3P1Ic6Hculfh225jvvSRL1Ee +10ZwCYWCUdKZx9/yBlk0WGqLPiSlTw= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-r6bsu79aN7qwezR8HAdfTg-1; Wed, 25 Sep 2024 07:11:23 -0400 X-MC-Unique: r6bsu79aN7qwezR8HAdfTg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71B2A1935873; Wed, 25 Sep 2024 11:11:22 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B0A9E1956094; Wed, 25 Sep 2024 11:11:20 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 17/44] hw/net: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:58 +0200 Message-ID: <20240925111029.24082-18-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-10-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5..248381f976 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9c..6be6140771 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf..6b9c4c9559 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; }