From patchwork Wed Sep 25 11:09:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830451 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685096wrz; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXvSgyF5WsVu1cqWSfJ7ssWFVvdGh+4uuf+VBhAthkfEBpIV6sXJLiTmvBq2Xhw21qJbWr5og==@linaro.org X-Google-Smtp-Source: AGHT+IEMN1GnwEPIJtcZnfKue7/x1hFLPv5n4BJRyLhwowZu/vL83f98soKFi1xnk11Q4EqXDTQp X-Received: by 2002:a05:6214:3c9a:b0:6c5:7b99:cab with SMTP id 6a1803df08f44-6cb1dd17659mr34611786d6.8.1727262848135; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262848; cv=none; d=google.com; s=arc-20240605; b=K0TdYmg9y/mjq4Qc0N0F/FSK3UBXGTH/Y4hkAuUJJJbrkLM1JPJJv1pmWe2qJ5UmP+ 9KGIYOmT7ixV1Q8YjwrerlT9/F4FWsLhGimySsRwW7DYWHmKc2EQO7AgXbEWkaxgL0+X vInN6xtFQ3eDBeYTcwNFqm+nVkd41Eh0CFF9ilk4v4K64+C07hh1KRVJSM/QoaUkH2pG X8VBrdQIulgxAglAyu675d3kqgcGMpoXBuvapUE2B0wuNB3W2EWSoa8urrWAjnlhjial I3WxsO3NcRSMBY24f+R2HWfFhGYoJSPJkggz1Bco4vC6AXWnl+iIbvdZnT1LaEeUjUM1 3ZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7N7BKVbWAiFjTduC3wB4ybIMZXyqbe+MoDRqWm66aDo=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fUFE/qmRDj4sS0WOWwnmH2Y7lpAPSmPKCOA7+U+3fnNgbdoANCiI0A1clXaDsTLBXJ 2FcF5abzWXeJytHAFfZ7jqAnZ5l0oXAArS9pv3pF8WLh/ZGMcrdPd5jPYF2TVyRJ7LCL UkFFjVW/l8zl0RY9uRbVl6aMZ6upk4ZSV6KpA6BgXtiwKc4HoFR/Dw/IQT8DW1IFvi4X 30pZysr/ldnZ8gszhZjKaZbSM5pUQUxo0KMW3MjF4CoidAmhKxiiCJ9BSCyxN6CcNHoL K6FddIORXjoNqxBJmjT+SbrL9HB64IWWolyKQJlPrUl4TG3stTZ6ZGWcn+h6hOunuFM/ WD0g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aQWwbrU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f7751besi36779606d6.233.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aQWwbrU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvY-0000LH-Ld; Wed, 25 Sep 2024 07:11:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvV-00009s-TX for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvS-0003Wy-Ap for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7N7BKVbWAiFjTduC3wB4ybIMZXyqbe+MoDRqWm66aDo=; b=aQWwbrU3bpbb2wBl/5u8eOX09OVz6yyFEb+f5YvMfKFgIzwEskpa/TmpBfUSWRpHqG1dV/ mPqJK4w6/9J3UBTmU116a8TmujqfCoRWGlLY9XmMu6+/byKx7emuxLcZS9SiM7DxouHSah n+A6vnRl/7PK07nR565xXb8EsSTTDaw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-oUxlCSbcOlSGUtUM5vsKDA-1; Wed, 25 Sep 2024 07:11:14 -0400 X-MC-Unique: oUxlCSbcOlSGUtUM5vsKDA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 357891944DE8; Wed, 25 Sep 2024 11:11:13 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 416E51956094; Wed, 25 Sep 2024 11:11:10 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 13/44] qobject: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:54 +0200 Message-ID: <20240925111029.24082-14-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-6-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c..a62865b642 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -118,7 +118,7 @@ QObject *qobject_from_qlit(const QLitObject *qlit) case QTYPE_QBOOL: return QOBJECT(qbool_from_bool(qlit->value.qbool)); default: - assert(0); + g_assert_not_reached(); } return NULL; diff --git a/qobject/qnum.c b/qobject/qnum.c index 2bbeaedc7b..2138b563a9 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -85,7 +85,7 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -123,7 +123,7 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -156,7 +156,7 @@ double qnum_get_double(QNum *qn) return qn->u.dbl; } - assert(0); + g_assert_not_reached(); return 0.0; } @@ -172,7 +172,7 @@ char *qnum_to_string(QNum *qn) return g_strdup_printf("%.17g", qn->u.dbl); } - assert(0); + g_assert_not_reached(); return NULL; }