From patchwork Wed Sep 25 11:09:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830456 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685318wrz; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVsJAm3yK9FlkTykBKmVpg7/DpFVZLCFrNffXesr4s4Ninn+CxMfD5socySL/7d1rDe98CcGQ==@linaro.org X-Google-Smtp-Source: AGHT+IHsH0hGOvlmiXdMK2lQ8kMj+RksWT1d33NTbq0jirrIE0qVkz5Y6i7zrHHOlkXdpwHPl6UB X-Received: by 2002:a05:620a:2946:b0:7ac:9bdd:6e6d with SMTP id af79cd13be357-7ace744d3bdmr404148185a.51.1727262881688; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262881; cv=none; d=google.com; s=arc-20240605; b=C6GtzEgKUTjROp0FsqxMzAqLRzm1kIdNjUHuOlyqPJuM/yfQinZuh3vfyuxVaFloAD /XLFu59/Eol4zAA1nq/5ix+I+Zd6GUR55zuRZ6FkwqXlomJf7xcqX6JU3oQGx4t4GGdb Y7GBuJKYLF2Vgb/uNuuT/3kHIPafxrsucYXgbPAPTRYhuX3lZYkG/5Szioivc5mKnD9n 7+oUsUttV8gY/Ro8gi5gZG88v87eSJOp0zAClKGh0UgH+TC3FSJ8DhKDv0E+h5t1jfVO k6y02po0t/3yNi8+oufX4pCA9K9nD83KRppIk4RXBFZ4Xx50cL5l4dxz4LIr/JUDZOyR goMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hVX5F6Pv9Y4G1nUu8Eh+Z6IKHmSKXDGevjC1ZtuA1IA=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=YGgoZQIUfX1v/BtSlyHwhtfsQiW8p6im5yBPys0gSTPlThOXgM25YrSGCf6PyAVGWD 4V4e/97JPymFNBbdcZ7nmUTcYUJEyaA4VlihSsW2/7Lc3C5R5vmlCbDZd8zwaHU/gC/+ kE34AwkKqUnHMcg/dxV/NkrCfkayCmo42hRebjSFYW4Sc5lK1l667faQvkv4KirWM7nh ZnBVXv4PmQNTxzjLAmv7DFXfsGtNu2NtDDctBiYeOUupcybb+c5MjORNdyq6rJdvgbcm rgIkld+BiCECkFbhfw1dIwGnni3/6BkrgRRt05hfML+SjX8FOvxMvFCILkGsdJ5FzhuV a6iw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGXXjss; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5fea50si372910685a.404.2024.09.25.04.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGXXjss; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvX-0000Fk-DV; Wed, 25 Sep 2024 07:11:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvV-00009u-Te for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvR-0003WZ-5q for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVX5F6Pv9Y4G1nUu8Eh+Z6IKHmSKXDGevjC1ZtuA1IA=; b=EjGXXjssFeAZ4xom40hI30+DqmwtUvEYufQgAFVuMOwxeq1uCMPLKI74vdjVkF/F2MrZhB wOg7TYPc/nwbc5A1PN+Va8YwKRI+KF6fA8r7eZV7gXMD/lRq8dYtn3w9s5iDUD2PgRTpPD UzlkWLPh0CWDOG/sYy0XfJijZ2FY/es= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-dN0GfTfrP5aMjr2fe6dJBQ-1; Wed, 25 Sep 2024 07:11:11 -0400 X-MC-Unique: dN0GfTfrP5aMjr2fe6dJBQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 42B801944DE5; Wed, 25 Sep 2024 11:11:10 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7AF881956094; Wed, 25 Sep 2024 11:11:08 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 12/44] migration: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:53 +0200 Message-ID: <20240925111029.24082-13-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-ID: <20240919044641.386068-5-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++++++------- migration/ram.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 28165cfc9e..20d1a6e219 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -640,7 +640,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) visit_type_bool(v, param, &p->direct_io, &err); break; default: - assert(0); + g_assert_not_reached(); } if (err) { diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 1c374b7ea1..f431bbc0d4 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1411,40 +1411,40 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } @@ -1452,7 +1452,7 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, uint64_t client_addr, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 67ca3d5d51..0aa5d34743 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1765,19 +1765,19 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { - assert(0); + g_assert_not_reached(); return false; } int ram_write_tracking_start(void) { - assert(0); + g_assert_not_reached(); return -1; } void ram_write_tracking_stop(void) { - assert(0); + g_assert_not_reached(); } #endif /* defined(__linux__) */