From patchwork Wed Sep 25 11:09:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830472 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686274wrz; Wed, 25 Sep 2024 04:16:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWBPfPtmAwc/FLegtibQxC102doimJk8SYdUHYOdju3ULKYIjwAuNsk2cqCsvPnuFdol8uJ/w==@linaro.org X-Google-Smtp-Source: AGHT+IHsCohAheJT9Q1CDSe9NJGR5IbApkNjC1ybGEPaOk9HNZyI+Ni5GYJKT4aCAM7O0xmN8omh X-Received: by 2002:a05:622a:14e:b0:458:3867:c13c with SMTP id d75a77b69052e-45b5dedf1dcmr39769941cf.19.1727263010216; Wed, 25 Sep 2024 04:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727263010; cv=none; d=google.com; s=arc-20240605; b=HFjV/JbqDiDJKKG5g5Kp5I5wHS7PhWGWEhEEvHtDFkOlktY93DZlnxXLM1xs8CR5m2 9QaD2BIo1EQIqF+aKK2Ad8gvEXiMke8ZsDgd4vIWIbNTRHoyi3wVKuzTpXTCuvcJyEbE dwVzTjqa5JAteK+fgs49SA9QouQGynwhSAgu3RYcymN5akb9YBZWd2zmrMEdHsrcF3lT 166R7Hm8KrbqUjvPte69xRmbfKQ0+r+OHji2jlxrzsAQFFoGs7pZL7YUug/Xif6yK/EM Cj9R4/1ljRlG8patMsN5QI3gYlSpbV97ywt9AB0F+kfbstCDDXBFwSRrfcISyRyxpMCh R1CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9wA9ErZOcHxomx3D/S9htm5cMrsPvqAXtUE6ybaQrZM=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=RMkvB9JgpZpecZ4JcJZwpgvaZlgCiHcjdOEm2/zjN4Yvjt2hdtnhznXZmkDJzZ6fOz 398+tQoV6FJpIqIg9wm0MDCLo4kQlhwPG+yV27jFPK9nbzjkLEhj9MkddcftthATsNUh IfRZRK/d7stPYmQzhgVtqrrVymn8omHdvCvceqRBtvz55yFvjDrxhUqvrvgnpkbPfaf2 ggqrpzEFf3umny1kd5yYBKBcJFUZFkatkzqcKena1W4r2SF9iisM5sg6YS5jY3DxKR18 cBzvBN9iaOLmtvejR2xWNmz2SVtdcEnL/96DmRRKjBx6Dazf6L9cp01D7Kdezw8oBFvW wSXA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QOoyOWuY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526f4b0csi34477901cf.543.2024.09.25.04.16.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QOoyOWuY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvR-0008CX-7O; Wed, 25 Sep 2024 07:11:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvP-000813-5h for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvN-0003W4-Om for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9wA9ErZOcHxomx3D/S9htm5cMrsPvqAXtUE6ybaQrZM=; b=QOoyOWuY54k9eD4nLPjiakDqLlhyi1fWFTINeBfdu4vF1FOiEwsx7KCBfv0tDeuXVjfGdB l6psmze6Oe7xu4jvJvB08NCcJWcOP6iQ8gQIHKMx5zv2OIRkk8DjZP85Cur0idT1XAuPM4 O04ppuauyOBcxpyrTyfwE+rxooZLwyM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-wiqXa1snP76_u_53dr6UZA-1; Wed, 25 Sep 2024 07:11:09 -0400 X-MC-Unique: wiqXa1snP76_u_53dr6UZA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 14BFB193EF48; Wed, 25 Sep 2024 11:11:08 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6516A1956094; Wed, 25 Sep 2024 11:11:05 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 11/44] hw/net: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:52 +0200 Message-ID: <20240925111029.24082-12-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-4-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65..cd416a00ff 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */