From patchwork Thu Sep 19 04:46:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829563 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp154021wrn; Wed, 18 Sep 2024 21:48:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXjHtyjHCejnKyElfc16Sjizulqgcao5qYrnyFV+vgj/o3qNIm75l0MIUTTukkXxYsjciE3MQ==@linaro.org X-Google-Smtp-Source: AGHT+IHJUeQ4yZ2wsppedir5Q6iz4Uje1FjSbpsxxrrZ2JCfu5X1tEBMnmavhGqGwbst9vV4D+tb X-Received: by 2002:a05:620a:44cc:b0:7a9:b3a1:94ca with SMTP id af79cd13be357-7a9e5f1a20emr3630256585a.35.1726721297643; Wed, 18 Sep 2024 21:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721297; cv=none; d=google.com; s=arc-20240605; b=QTH4kK5nTRY5kBs03Ru8yuVZ9XIuhcOc5LkLcUQtQwyInAkqH6Cds/l2/nJ1BDDD1w L2MLVaPBdREk9QqP8LpBPyrwwEvjGDiBfNgCEb2wmcIoEhyjzVasQ56GIL+sh6Z5NWhy V3tJjH1v+iTSJVa17+Vl+weq+bpFBrmz3Q3lab2itHn9okBpB6xJaqNe4m6+FeDi2poo R6UjvehCqtvlZcdMQQTcnSyXcHySx/MPOSi9tNI3pFqF2P9yB69Pu+hP/Yur5BWLSjmY HhCS0pa6DMrb2mVeicpVP5JwMACzxBAdnZVn3XbXzUlgJAp8eBXse3A7V7N853UK1GGn TBcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KJkmiG3PhPpYsgMJ7XkEBDNaPQyoDU9Xw+XJyRk65WE=; fh=5sUwfmYRlCXWUAcYTQtsUKL3/h5U38RKAKIQYZIY6/E=; b=ggPOQYPTDpkB23hGVtJctFAu43UFYfwzIMjEnVYyGEo8jLT1NwgbPGz55suLbEKX8L fc+NB+girUQeBd4j+eGRtKeH6caOkOMrZio/p04bnn1NxalG6PA9y2fAuiCSRtNY28/E MrwUgA4PaH/sotYDZKYdeFIvTVjKRRtpLmfKxWNLOL6um6j1dcZyh1lmbDzKjLc1l5R9 SNQsCDsagKoiY0TwdDbESQtCGZ1FFwUMEfNZAiwzfPJQ5QyL8WVzETXywFy7NJPKVouS 2697qSvn06jsMIuk3oCCl8UW7vBRuV36ZRMMlleBfn5cQoPAD5XWaXl8SLNwZ7ycFlPf BalA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rdY8ydl4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acb08c5785si104943685a.308.2024.09.18.21.48.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:48:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rdY8ydl4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94M-00084v-EP; Thu, 19 Sep 2024 00:47:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94K-0007xE-PY for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:04 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94E-00077V-80 for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:04 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7198cb6bb02so269225b3a.3 for ; Wed, 18 Sep 2024 21:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721217; x=1727326017; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KJkmiG3PhPpYsgMJ7XkEBDNaPQyoDU9Xw+XJyRk65WE=; b=rdY8ydl4cUE2I9J8VfSYfEQaWCcmyFPvQKqfgoHdeknoJrb4JZhEPs6yiJEQ+OnC1E nnK5U+KAyKU8+Ju21Z1BE3YZ2kBLUjmzuHYIAVDT88X/tUIAubkeTFQrfArw0/QUym9g WJTwicOnVExEg79EER511wLkK9J5M3kxpZ2t+zv+j+OINIwvn8Z2zjtyjIyHg8PH+0vy Mlccob5vdo+EDtu06zl3GgkOUjvglqhmNtS/yBoARU77fgawsy69EvHLw1ZI97Xr7H10 6CU0JDM2LzYNcdY7NXxJY7eVnAcTiFaGyATz94Xzsl+hu8q0wHNBwz3GRtvjVfyDMlfR 98qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721217; x=1727326017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJkmiG3PhPpYsgMJ7XkEBDNaPQyoDU9Xw+XJyRk65WE=; b=u6/3eFcNpAMuzml7+fUGqqU1wmTUOWjkWr+MHBRGzHrdLdkGv82isorz/Hxvz0HaZL VXh622+Smw5YVmI+vE6WsirkNF2vBi2gCfFI88K2d/mjPc0cU32ern5m1PHKSLMxjnIc 2DOsWgrAga/EYFhHlu/QlIkT4F5OpNuPK3cFaXdqtldke4DoQOsflk3hRPU8RkGrb76q EsvPYqe6DJ1Q2w67Rm2QcUBYtE1ViwVt+81a44Bmv6raawl1JfKkDBBez9ApGQzSwWAQ MHHM9sEXW6d3L6D4S8RohGMo7jfKJPEtPeoIHBSwJnZbsbiMQbXW8oTdsP5cplvlPh5G Vb1Q== X-Gm-Message-State: AOJu0YyNp2Ep79jqMA021/KQOrTguAQj8FNsd5DFvilbHzICBgvKyTOs mgdUnXZxJ20hdEH9XE8OmQ1coCXDKXPXZuIhFTlbV2jzRCM2b0qVVbMAV7L4N/K0RcjoEGVMvuu zHrI9Gw== X-Received: by 2002:a05:6a00:2401:b0:718:dd53:70db with SMTP id d2e1a72fcca58-7192606c438mr38378490b3a.11.1726721216563; Wed, 18 Sep 2024 21:46:56 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:56 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 05/34] qobject: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:12 -0700 Message-Id: <20240919044641.386068-6-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c2..a62865b6423 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -118,7 +118,7 @@ QObject *qobject_from_qlit(const QLitObject *qlit) case QTYPE_QBOOL: return QOBJECT(qbool_from_bool(qlit->value.qbool)); default: - assert(0); + g_assert_not_reached(); } return NULL; diff --git a/qobject/qnum.c b/qobject/qnum.c index 2bbeaedc7b4..2138b563a9f 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -85,7 +85,7 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -123,7 +123,7 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -156,7 +156,7 @@ double qnum_get_double(QNum *qn) return qn->u.dbl; } - assert(0); + g_assert_not_reached(); return 0.0; } @@ -172,7 +172,7 @@ char *qnum_to_string(QNum *qn) return g_strdup_printf("%.17g", qn->u.dbl); } - assert(0); + g_assert_not_reached(); return NULL; }