From patchwork Thu Sep 19 04:46:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829574 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp154622wrn; Wed, 18 Sep 2024 21:51:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU6lBqTp0dtr7Z1aFkbg3NdqHhNSIFyXFPRx3LGHR2Ya4FwWsM4yM+6QKJGWhoH9GtXO5QeQA==@linaro.org X-Google-Smtp-Source: AGHT+IGzcTODK/BamTui9sOra6TBxZ+UnW+nXn/zw5dqjOv9Ct33U/5zkt9b8po014eoCR8tpDLZ X-Received: by 2002:ad4:448c:0:b0:6c5:8ab0:60cc with SMTP id 6a1803df08f44-6c58ab0614fmr252415016d6.40.1726721484831; Wed, 18 Sep 2024 21:51:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721484; cv=none; d=google.com; s=arc-20240605; b=J5vcyyLgYZPXfXqNFPaadYbur5jl448sT4ZZP1WWhfMZ1fJUueRw0dGAGKsJhQ29x1 dw5fYlqPjWBWCAtBk/G39ibQyNzKZqx/HovxwLyatoqUOsmNPrJu30iRKD1pUbO9RH++ RnDOJY5YltARb6bchsNY77NjJqmKCvxunzsNPWydM3F5cZawXQvdtaOaR1/6iRagdWWx V1zc9YkH5rj5fWkCsJJ221bHBVVLlXieAaEm7GVlJeKF6Z32TX/Oq8qNaEV07w2+DGRe wv9mbqoow6n5/x6RBT17Z1u0F2W1fJHHOyq0eEi3AwZTXJtzGDQOykZZmyXcC1wd8BwY R+hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; fh=5sUwfmYRlCXWUAcYTQtsUKL3/h5U38RKAKIQYZIY6/E=; b=eQ3U3nINdlQrWIGOAQ0itQJLRwEPS61oMqDGE4x7DT+XT8SXs0MOkUY0agWrRjkHEv rbAbmghVZq0vXgxwhKqQUvt1abXm0leMIdGVirE7MNeZi63+vdmw4R/Ox3jpih2Y2Oq2 9fuiCGD9tW3ST8iDmzZTGypxQvFTUXpk2ibyFD8qZLO6Xink62QMqx/Pbja0JNoeFD2P D8NB3e34oxauXq/zRfKo5mV2gMIUC0GPvBuiuY4vXebYzrLHRlr7AikCaMZ8ZTRfNdTU aefFK/kVGCN0YgLKjSksnDfKyEVgLukPcRkLXCPrabkjF8ntERyIgJfQYa3AmH/aPLM9 ib2w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqhnUJ99; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c75e5dab6csi10021136d6.592.2024.09.18.21.51.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:51:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UqhnUJ99; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94J-0007oW-67; Thu, 19 Sep 2024 00:47:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94G-0007dF-Fc for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:00 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94C-00076E-TA for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:00 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-7197970e2aeso262417b3a.2 for ; Wed, 18 Sep 2024 21:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721213; x=1727326013; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=UqhnUJ99+f+7i8sWkEH5kbcTMTzmDkGA8fxLdcdadayW2xkgsASOOeHDt59M0jjrsE g/WD9zMhV0zbVCEZmFNw0WaNrQxBtBEfuZW4socp1M7eNAylsasETSUJ5m8iwqIgXHyh t+MhHwG+LaPZFKQNmUzcPQObNHyIy2yv9naxlo33nPtH5uc3Yhh62UO4RMaDZH8V62RA 6VJ8eolOe4XNTci9nFCTt+KDVTEpH21ywoc32HoTyiSCJixksMZSGJRXRsaZReLqoSyU gbh54iWryPFEU2GIlpfKViXeGPUufCmABmuYXINuCaMtPUeUHoZx00Jng6vsEyZcCqOv 1QrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721213; x=1727326013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/2IU4UYdfrAjMX4NizJG5E5V51UHXtFH8CwKGzIrQ0=; b=CbXK9ee0kAD+dPilwAOlu2qY7Z7VD2+tLnB84T//4vkKXNYC47jc+rSrix3hG4GpAD DRSBHs/a31yaokKk6aCHv6gxiIrJVQIcAgTjFGuA0lt7bB0O8i01pWcps7WPPYXacRuF nVkpX9Wz6nS/AlptK5E/H+uzGNlPDOTtDo2QY2rSTSfIbjOPlXGWkKsmsRqkuBwAcE88 YFAQNyYtOMHhu0Ot4JoxJBM6+2MeKvR4WvDwA8NAgkReVzJJx0jyS/POABdatsDUTrEN sp3YlqdNcHDK3lcMXWEYV/PqfIuWuYvhDLFPFapzLjuYJitiVfWG2ewSgU4rHL0IXkbZ ceZg== X-Gm-Message-State: AOJu0Yz/Zx0DQuUV/d7SQ7EqUd/nSxGXaqHMnRtpDC1ajCP974Z5Qorw lhlofoT173y7NwzFiDyEwm8yrPTQLXCOitAyt0YpkXBw3zdUw/sPOepBkoIqpMRBzTIXjrpmyIk 5GZcGng== X-Received: by 2002:a05:6a00:3c73:b0:718:ea84:3e50 with SMTP id d2e1a72fcca58-71936afb98cmr25001957b3a.22.1726721212760; Wed, 18 Sep 2024 21:46:52 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:46:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 03/34] hw/net: replace assert(0) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:10 -0700 Message-Id: <20240919044641.386068-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65a..cd416a00ffa 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */