From patchwork Thu Sep 19 04:46:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829593 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp155533wrn; Wed, 18 Sep 2024 21:55:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVXegSh3uPDSZDNEbVlDvh7jmHloxHkHuoHkuEmUf11YeIpvvOUMdT6TQR/BmCYTQSWoFib8Q==@linaro.org X-Google-Smtp-Source: AGHT+IE695blne8qyT0zwTol9EW4x9w2eNGn5NVDV6ulsDgBzMgfe1dAEQZM4ZbmucYSF8LtmP4/ X-Received: by 2002:a05:622a:491:b0:458:4aec:2749 with SMTP id d75a77b69052e-45860462832mr433986511cf.57.1726721735306; Wed, 18 Sep 2024 21:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721735; cv=none; d=google.com; s=arc-20240605; b=Yfpap0MzwCEoeXP7CZnSWej5uz7oCA6n2AwoBS6zR8V0HGL3dFeN8joFWYO8SGA+UU Dek7yb2tVkAx8NfNYwb9EUuscV9mRXwcE1hH1L1ViEn/FIbMzPzeV2v1kU7gM1CBwMQu yc99EOje5/F46yFWWeZodTjQW6EoKRSYu+m5xeHWbkwLdGW5lsDtW5zRxsaWyTNc1/pP 9RYQnGdjepIyJQYUO48RpkMT6bjDRy3Tt0z//BF5aU3GHvuAchu5IigZ17x2CU9JgQnV Z9vOe0yKTSY5jXTW0fNz8GVI8yeqvMVf/foKhkXUce3paQFL5LhgiAE4ikJkd41f2lKU nmUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; fh=5w0C6Su5YL6D4gRQXRxjwqg6NKEGLvt6ptRsHlrbxUA=; b=LFkqx8L+WaErrqiuc5qTKbQas2VG2aP8h8wdzU7iMQD/Vl32HvtmSD6iXxJcnFRqZt AVeL2FmBnOMAsjo9kXBkxDq8uABjUP0OENgH0rAfrAuF8fkGxkzxu1f6BF3KRYYpXAh+ fnfDAWEKpsNT4kHPUFUdr0vwJPIahLptrkrP5/cH+8X4zY9y0lERzRuuk6Cqv2QTafms nEQdf7qvyPtQN5mymcA5RhT84OEdzU0BzroVC547X4Q3w803csFvtXUZOVqucbKxRj6i 9HFxRmW/IXG6hNVjikvfegnYTHzw7RMtVOJUyIb/TD5gzXM1O0IRscwX3kKKYp/XZtgJ CDBg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wfPGMaYQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b1786aa5csi11433271cf.161.2024.09.18.21.55.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wfPGMaYQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94X-0000SO-42; Thu, 19 Sep 2024 00:47:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94U-0000EE-7n for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:14 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94N-0007CX-Nx for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:13 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-6bce380eb96so229908a12.0 for ; Wed, 18 Sep 2024 21:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721226; x=1727326026; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=wfPGMaYQv7SGeEjJ4b/DyaMh+4CrNjToVfqAcyDCwDv5mOvPuU+Oze8ct+4qvD8ggS ZwjxO7dMa+Y/Ha02SwJeysMr1gAVHFC93xY+dMhYHOEkFyD/RVhJY67ZHMTlux8s0UHk OcqwS8cwINuDcPrIcSoVJkZK9Q2EkQjFFF+kdhnbciOBnpr57Jatb9/c2PAQiB9rGnUE RxEzbNnJzjqvsOOmmeZCu8btv/o8KjjIHy/CCPiENzgXxs3I1MBW6Es4ReiwlSo/rkSD F857g/6K7/zacJorzJ41y559ztVxVDeXJEN8VSd6R1U0SnJ1pu5GjO0yGRxtF3bEqgU+ bCsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721226; x=1727326026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J91xisxxghHlg97TfgBUUF7cBAztIX0LnTXW2HtCgj8=; b=fMNp5mAke8MlRP6esGqpXCZrMWowwR1KWhWgLwqtYavkXE1dp7ztO4LvN67nxtQW2/ JkNg63Q3hAOOvMHcCOCP0TP4YdWYlXMpza7bbFGKGD145LzYQ+4TEamUAhlvLIUSmtuV LnVVKCFVMuOWAw8KEstzycntnWAEeiXBgAzO717WGJ3Ju985gfAWR6X2xpEfrePtsZTv tr0IuUyMgNaa1BbFcc4B8fRHATk3t6mGbjDHDovKSMWnVLJo8YormFl1vgq/r8QB/X6L aHeYhA5qYIzKRZeNSdAG3pZNJDgINf9t8n8aFXCO4FLWW8wXRZLMlaVHfBa4OlmgJxss sUIw== X-Gm-Message-State: AOJu0YybMvqMX9X6LDrG4NmDtFd+f7qTi3Mg/h6gRRpmmRp4ALXephvt i5/hu60LLXLqV1P9WbUg3MRsqnQFiebMqxMa9F6m6CMQr32aVJ2YIDNncwvv8bHbJUkJdwYLquu 82yhmAA== X-Received: by 2002:a05:6a21:3947:b0:1cf:27bf:8e03 with SMTP id adf61e73a8af0-1cf75efd46amr36339625637.26.1726721226274; Wed, 18 Sep 2024 21:47:06 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:05 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier , Klaus Jensen Subject: [PATCH v3 10/34] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:17 -0700 Message-Id: <20240919044641.386068-11-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Klaus Jensen Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9e94a240540..2589e1968ea 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR;