From patchwork Thu Sep 19 04:46:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 829587 Delivered-To: patch@linaro.org Received: by 2002:adf:ebcc:0:b0:367:895a:4699 with SMTP id v12csp155102wrn; Wed, 18 Sep 2024 21:53:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWxcn8E9XPtqcL9MoZNa+OvM8fkg5Daeq20GnsLjDrBO0M/U3lLmJ4s9Zfajr7SEJ/1E1ZCkQ==@linaro.org X-Google-Smtp-Source: AGHT+IGKLLs6/dlpypoGfKT3QTA3+z0ey4+BgWRbLQNs/DWT8k12LD55Q/DTcwuJ3ZIekE34wvo+ X-Received: by 2002:a05:622a:15d3:b0:456:85a9:1838 with SMTP id d75a77b69052e-45860465a8amr330359261cf.60.1726721627810; Wed, 18 Sep 2024 21:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726721627; cv=none; d=google.com; s=arc-20240605; b=NBL5KV2/QDddJeQa/BGOwgyiL3dicABztqx0ZNz7attMT2x7EEGWvim/cAnVn33F5d XLTCdZgynQrUe34hHaLGSaxVgOfkoDoF8BhhDi+h2Cgo2hgsXpVD0vFlfa85W1pfEA1O HvY2J3OrF46gSYohxcsHnKA/6Q59SETm7ESwy4VQo0UJv/XDWuTMB+zVYQssJD+Jv/tp uouD9m/QEmn1pKVOL5HTINxtHHJWozShVtwGtYTLaIj3ZFgi335pHt7U3zYFPXsjKPx7 cKB/uNK4jvRMa9IGW3u39OarcIT63ZGGJXcJnXW9aMjaRQKns9tLJwxJ7NzJhAtmfoGw WyeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HfkyjDHktRIdC53aV7jz+MEYNAmpLLxTbQ4xm76fWo0=; fh=5sUwfmYRlCXWUAcYTQtsUKL3/h5U38RKAKIQYZIY6/E=; b=lOgaxv3CCRHUeRdeGSeY9HkG9P7viYp91sQ1LfqWlZ/q3V2m8mgKrTGFPwfgndE61V z88thVthR5IkrS5H/CVbzb2s4BppuFoFncACyJ3I2MDHMUtBMM8XOZoRphYJbK4J917Q JRPsn1hjSnouVEDvkJ8oQ/rF2c7VbkINhsLTQDMy78/MEEj8fukqGL+H7o413SdMtT4k 42ulvfb2ge4N+b3cT4m+jXeIsd5MKj16VrTbSJx4R0ie2H2F3PFLuiNU/rhFgAvciMJR 0jK8BneHtVihOipVf98o9ItS1fTFqybe+w6EE+KixCooFma9ictyUAlwgnGIIg3UHqwV S5lQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DiCadRI5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b1793e4fdsi10940361cf.647.2024.09.18.21.53.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Sep 2024 21:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DiCadRI5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94U-0000Fy-J4; Thu, 19 Sep 2024 00:47:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94S-0008UT-0m for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:12 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94L-0007Bb-MQ for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:11 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-7d4f85766f0so296104a12.2 for ; Wed, 18 Sep 2024 21:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721224; x=1727326024; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HfkyjDHktRIdC53aV7jz+MEYNAmpLLxTbQ4xm76fWo0=; b=DiCadRI5GDIbCHswgP2povN3DH4UuKzdQmGrzHXBav0fhT/UC6Mc1iCzpjMvvCaBZZ Fy/t8fQI0atlOqjrY1rxplR6FD8lB3S/v3lkkUL4KLuyN/ffNnOAxDItRGIOMZ+dnhF+ 1MHj2INry90zzSSk9ChDbGxAREk8Sp+6E22dh8LJHDIEEvoMp7t3g0ZFHh3uBtmdvlr+ SCbKo0s3yT1DV8uG5i3PFHO/GFceud9y5JB6eom+Rld+HpRswVtW8hzWIhiEUSoVX+q6 63undiA5llO9sZRaUZg37SA4I8LTwgiw3BEz7oTT9bBkASKYRV2loc4t6hQT4J3jk08l +6Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721224; x=1727326024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HfkyjDHktRIdC53aV7jz+MEYNAmpLLxTbQ4xm76fWo0=; b=jzr2JZr5iiuUcWvCJNydk2m4WZJqH5MmWfycilsXr7i2CEi2KKgevEZhXeI85N5/lm Q6jl7IRFGpnWuqvGawrfK978S7M+DJmD8WOEDE6v9RNBcVlu70jeuanwJH3IaieM6ga1 /WgnO2CUOL6zzBj6YpL8BsDNCJtWk4xhW+sKqNGLpn8XsmIM2NjIkGxbTyqwgXIG3NPm JlTOFDNgTzSeqFJEUxf00929eMpTFdC4rgucv16ZUQDht/Uv5dBxF40BTpt/cQ5PU/fT SaCi+4cixn8KbyQTo1eXWwEIzWgXM/uUOhNdZn0cCMf/cQBeLPTNe2SmZZq6b8349+5Y WkIg== X-Gm-Message-State: AOJu0YxHglqVZkLCC5cwZIXzhrCT8+uG700xwl15RxGzE+NiBsn7ps9y LFdGg3kas6HdClsD4tmxGYCPq0pbkdkUBzHKqcr1xT4LqSmDPCUUlhkYqxyTqreK7f21G5p7s2q HuOhLLw== X-Received: by 2002:a05:6a21:3a44:b0:1cf:2ab6:a348 with SMTP id adf61e73a8af0-1cf75ea1dc8mr38949451637.1.1726721224333; Wed, 18 Sep 2024 21:47:04 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:03 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 09/34] hw/net: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:16 -0700 Message-Id: <20240919044641.386068-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5d..248381f9766 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9cd..6be61407715 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf7..6b9c4c9559d 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; }