From patchwork Tue Sep 17 10:35:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829233 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp213937wrr; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXLYYmCrzrjZ+rINp7+JsLLAvzQVMs9M+4yo+i56EzfZZPUihJRqiOHsmXrOPTjVoWTOyP+gA==@linaro.org X-Google-Smtp-Source: AGHT+IG5F4l0oYguaZPcdrtPFMHuusOiDZb5FGnxenHHB5jlxjo/bTM8j8KUQne6tyuGq5VLSMMV X-Received: by 2002:a05:622a:2a11:b0:458:4f4d:1ffd with SMTP id d75a77b69052e-4599d2b9845mr258372861cf.45.1726569408183; Tue, 17 Sep 2024 03:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569408; cv=none; d=google.com; s=arc-20240605; b=M71duPrV6pm4WDf1DAhGN1Tk4nj7lR6DvMIsjNjT5JCyZUWEoBeD23b/+tBj8OBRNw tiMspBGxcxS+fwocNkZVxbAy59819AIwLJ+DCK3Xgw9BdYuE2lOuA7lS99o/dxHuM+oT Lx9xewQbdnwudJuoq2erMSbnUmyR96wzIk1SlSk9ijZiqMs5nR0KNAsLGYXjr316m8Nr wOQ5ol7cJ0IUy8lJQnGiv+5AsWyAjSsnpcNEeYUxHomKcSJ8eOKDtm9eFsSMWr7Ib+MR 0RzfXaeyeqDBlxSpnwTiSn5/I430abxDtIHme44tSY7WN8gDCpijYU1L3fND7BZ87G+u 0OPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2A0bMQNYir9UiOIApKS5SDLnl+/c9VOLN14bZaqlyWE=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=VVyPQhc7wqGMyH2pzWAtKJX4DCh0wZqrWxmWt/hMOlD/kTDV+DaJ/APFe5o7yHx+FY /woApDuk8PdUSZ8iATkSA8Pe9zZz8KgqxiCvWj5nNrSOqTFZTSlq6iyxYRsB+UA+Riuz q4KNXeXyfhsqViOygg1Jjm+QVo39GSnifEWIv+gQT3UGme/+nrwdGNHMLnlljTEhr1GM Kz6kMlGsSItLnsjLX9iWw5mwFI+QWT8LhFUXhpU4hosuMM6K2mRPU2aE6LuDdBT8q/a+ VxZ9K+TL3a7W2RXMVYAPgCekQJioTCcSqBQcs5DZbDfE2ffoBTqT3VGJ593D5HS0f+gS r4wg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NdjpxfAb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-459aad0c4fesi85393391cf.303.2024.09.17.03.36.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NdjpxfAb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZD-0004SZ-Bq; Tue, 17 Sep 2024 06:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ8-00045K-Ev for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZ6-0007Kz-S0 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2A0bMQNYir9UiOIApKS5SDLnl+/c9VOLN14bZaqlyWE=; b=NdjpxfAbzSDvACG3IlDkmSHdEIbCwKPw6E3hnjtPn85yvK0gJUUn/f0Ml1fzuTILyFPb4+ lx/1gMZx5c7/OWG7+C9lxGsGYhS4n2ASX9Uo0RdwTjrQLHHXkxgwYLOmhgWoqWwejJN5ZJ nOrrUH36RfHHq7YkmqmHsS9kYxSc8sA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-x2MMbfEENSijvHX_W6gpqw-1; Tue, 17 Sep 2024 06:36:05 -0400 X-MC-Unique: x2MMbfEENSijvHX_W6gpqw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D40441956048; Tue, 17 Sep 2024 10:36:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BB6061955F54; Tue, 17 Sep 2024 10:36:02 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:31 +0200 Message-ID: <20240917103540.149144-9-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-13-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/ipmi-kcs-test.c | 4 ++-- tests/qtest/rtl8139-test.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c index 383239bcd4..13f7c841f5 100644 --- a/tests/qtest/ipmi-bt-test.c +++ b/tests/qtest/ipmi-bt-test.c @@ -251,7 +251,7 @@ static void emu_msg_handler(void) msg[msg_len++] = 0xa0; write_emu_msg(msg, msg_len); } else { - g_assert(0); + g_assert_not_reached(); } } diff --git a/tests/qtest/ipmi-kcs-test.c b/tests/qtest/ipmi-kcs-test.c index afc24dd3e4..3186c6ad64 100644 --- a/tests/qtest/ipmi-kcs-test.c +++ b/tests/qtest/ipmi-kcs-test.c @@ -145,7 +145,7 @@ static void kcs_cmd(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } *rsp_len = j; } @@ -184,7 +184,7 @@ static void kcs_abort(uint8_t *cmd, unsigned int cmd_len, break; default: - g_assert(0); + g_assert_not_reached(); } /* Start the abort here */ diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c index eedf90f65a..55f671f2f5 100644 --- a/tests/qtest/rtl8139-test.c +++ b/tests/qtest/rtl8139-test.c @@ -65,7 +65,7 @@ PORT(IntrMask, w, 0x3c) PORT(IntrStatus, w, 0x3E) PORT(TimerInt, l, 0x54) -#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0) +#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); } while (0) static void test_timer(void) {