From patchwork Tue Sep 17 10:35:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 829238 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp214705wrr; Tue, 17 Sep 2024 03:39:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW2GHu8WbW9/ajoAt7/BjRYhUmVOL/GXRvEXRt09fzCMnhZDKxLrUJUbELY5z7JHD0ExYd4dQ==@linaro.org X-Google-Smtp-Source: AGHT+IEC4esBDZik6kaK2dzB+qPofGBtemOYxsL+8K2dDsR4yPcjIYk60GEZh3lFNGsfey7OVPwM X-Received: by 2002:a05:620a:640c:b0:7ac:a077:6a3e with SMTP id af79cd13be357-7aca0776d13mr148861785a.39.1726569552543; Tue, 17 Sep 2024 03:39:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569552; cv=none; d=google.com; s=arc-20240605; b=A7Y4yNIr0BdLuRwpi/1MJxtF4ekL0UnTUBarF0Eu0gPoaFGKqMFZ9+NV0YX/IoWlcV teBPVHX4Xap3sSZ0DRvIvlANJz/9LJ0gs627VhglKHjhRt4CfrpFMmREwovGo3DTw+iR MwVkCdhw/d0zk4C8HphnKPMojOA+d1Y8LmygXGnEIV6tM7Np6/DJj4/WEiH0GN1ZsQmS 77w2H7acrdrAnlvMx9nAOtKEsJHacGkTPL/l4RidGieYyGoTQbYqcoktWjcMLVXR6UJy bRLidXfRCT6Q5GVm/olJYPR1942bgIiVBRFDfE6DqgpXVs4szOw0weybNRmIZ9eNOqUM jU1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=la+StKHLdWyfgIDn0o+CQJClKABKz7FpaTl7t/apb1g=; fh=CsrrMFYqxLb2ncaqCW7Qx+RO/RoxmO0iSVmBprRl/p8=; b=SIIMWM/Imf9NA8T3TsAMGzajEBsTB4OFqnHmTP2gE91EUQFicxrXmG+ZQFuucZOreJ fJnBCVt3725TJtrBu2Ai9tqTwaH2NX7+z9g/GQq70fzPMJ0ZdOEKkhiKvKk4bP3AN4ZO BctpMSgOsRF2vCUUtpQRyJ59hKCWyzpBLC8yi9TS9WS8GO9GpCsmI+GHgEbz+JiklsNV lPFIYgmDeQ5Fmmt3eZe8576yC2/vdQZNIr8YQRnK5X6PPqgjcFnfkPtGD5MJH5BfL3iP A5Q2q1dQ5f2JEgEvAwUfGnlWExUbES/M/xk1sp4UemwZ+5sRHr5t+++DWROcLrUspapl ONLw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSirlGuo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7ab3eb54d2fsi814689285a.333.2024.09.17.03.39.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:39:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSirlGuo; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVZg-0006xA-Ky; Tue, 17 Sep 2024 06:36:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZI-0004zT-UL for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVZH-0007Mq-C0 for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:36:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=la+StKHLdWyfgIDn0o+CQJClKABKz7FpaTl7t/apb1g=; b=XSirlGuoZhYqTbGOgbemAOSbP0IUpkuAWnHdl/1YbHIlViAZj0SX1qUBqgviMUEpUg0Nxo SyPa0gc9mDG2h0vdD6eoY0EzFeiy9fpNVukDkaf/1053q88lyJuT40REd7sxenWiOikAuo FpmZFIELuegwXJxJU4NTwM/pnjNbzZs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-yl2ZPdjdOTy9M4or0P3FQA-1; Tue, 17 Sep 2024 06:36:16 -0400 X-MC-Unique: yl2ZPdjdOTy9M4or0P3FQA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 563B21955D4F; Tue, 17 Sep 2024 10:36:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.158]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 497A019560A3; Tue, 17 Sep 2024 10:36:12 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier , Richard Henderson Subject: [PULL 11/17] tests/qtest: replace assert(false) with g_assert_not_reached() Date: Tue, 17 Sep 2024 12:35:34 +0200 Message-ID: <20240917103540.149144-12-thuth@redhat.com> In-Reply-To: <20240917103540.149144-1-thuth@redhat.com> References: <20240917103540.149144-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240912073921.453203-24-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/numa-test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c index ede418963c..6d92baee86 100644 --- a/tests/qtest/numa-test.c +++ b/tests/qtest/numa-test.c @@ -162,7 +162,7 @@ static void pc_numa_cpu(const void *data) } else if (socket == 1 && core == 1 && thread == 1) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -207,7 +207,7 @@ static void spapr_numa_cpu(const void *data) } else if (core == 3) { g_assert_cmpint(node, ==, 1); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -257,7 +257,7 @@ static void aarch64_numa_cpu(const void *data) } else if (socket == 1 && cluster == 0 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -305,7 +305,7 @@ static void loongarch64_numa_cpu(const void *data) } else if (socket == 1 && core == 0 && thread == 0) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); } @@ -367,7 +367,7 @@ static void pc_dynamic_cpu_cfg(const void *data) } else if (socket == 1) { g_assert_cmpint(node, ==, 0); } else { - g_assert(false); + g_assert_not_reached(); } qobject_unref(e); }