From patchwork Thu Sep 12 07:38:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 827798 Delivered-To: patch@linaro.org Received: by 2002:adf:ab1c:0:b0:367:895a:4699 with SMTP id q28csp1142235wrc; Thu, 12 Sep 2024 00:42:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVs3ygqG5WXq0XTa+Jm8c/qsG8ghnqlpJZbAH0vWrHRRvbgYmXFG9+uCH1n1NHGZKmCOwKKIg==@linaro.org X-Google-Smtp-Source: AGHT+IEci87T4fZwychQA5K5Q4WiewvqbPXSM52I4LHd7BP84o8wQeAkO1RbEklU9z9ZZzKq22Lt X-Received: by 2002:ac8:5782:0:b0:458:4465:d6b4 with SMTP id d75a77b69052e-458602da313mr30443501cf.13.1726126943301; Thu, 12 Sep 2024 00:42:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726126943; cv=none; d=google.com; s=arc-20240605; b=LPodbIjS8TgrYnkyU0gq0knUyry5GaStcvqQiPTf8jJaIt3H8hzg812LXn5O+BqY4S Dex+8I/911w2jR5zFZ9qdvWLhqMFmruNGmZ19sjsRKAi8AAti5yKjkmitZ+vbS371Nx6 WM54zRn05mt7ldM7qGlW8OGEhzCTkg4zQHwjcwpXwOC6X7kq/dVXoZaBsiEQKNHK/Qad YIOHEMlbYbJLRAgxO/UMyUuwb8DPmZRuZSvd+AAS5jBSQbDJqKFXJH5n17oDLH26K/or uHVzo0PN2kkK9MOm6Vsrc52cAGStPmOZqPHrUatTVNB5G+6j/dhHVNozmFkIWUJMk8nF PSaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=THAU92UrM0dCOcON0qgAWJPM/1rIMc3WLepZV6d4U4w=; fh=9lXHm2cv0EOsvaESlQxkp+iopfNbpS2ZXLeBYSea/ko=; b=jItotDJ2uakyoQv9JQ9RVjEL8b/vXwujSFqrNfil4aAp+qnFoNoky+ckW6rRsW8Bxy EheMaZuNMVjgHEk8ap9TiQ3xcCEq4kmQ4pW77rTd+4CVS5QblDeY5fOAKNLppegDGLhb oUnI+PpMI2zcAelTaJsFs69pYfsOFYcBK+0tNixulHFJMQNEl5xoBzzUVWUslClXqbsD X/SZDvjtyojkG9RYanvK+tpgdzNohd8TzQYb6dNBu2Ik49PxBC8lLXrGN0dCEAo76idu M8XAcXuml51ObvkJ3CgjSlRREelIq94rjRoszO9tLtImvhLKb/SBVN+ObjX6Q6pIV5KG nAkg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kro1XKv/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45822fb49cesi122645331cf.657.2024.09.12.00.42.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2024 00:42:23 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kro1XKv/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soeSE-0001g2-Oz; Thu, 12 Sep 2024 03:41:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soeRG-0004LC-J2 for qemu-devel@nongnu.org; Thu, 12 Sep 2024 03:40:31 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soeRC-0000bb-FL for qemu-devel@nongnu.org; Thu, 12 Sep 2024 03:40:25 -0400 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3e042f4636dso346319b6e.1 for ; Thu, 12 Sep 2024 00:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126817; x=1726731617; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=THAU92UrM0dCOcON0qgAWJPM/1rIMc3WLepZV6d4U4w=; b=kro1XKv/1q1SZurjp8JX/217lkWYC3UsiqKWG7TIHrM2jIaqofPMYaa45IFn07XX3b 34sa5UwVHf6dxJqoxa4blHip/lmXS+ZUwJWJy2/9HA0kLmVsmLkBLjn8CVKLc2yg0a2Q Z9vGQ/D8uTbWvCv3JWlK3ixPFKb96ZUM33K8mSIVPS0fUsfyFdOIxgUPgk58xSjqzGHh OB5t7UxfoRSk+OSdqWA4uB7JCrl+FSOq4I6h+HtU6KefpjY+EOG8loDuLSUBg33cRtE5 LdvbebSzFn2Xk3vs2+Rq7uiA/c+X6iHtWx06jtHXnzKG7attIVt9DpAno1z1F28FyS6D qU4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126817; x=1726731617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=THAU92UrM0dCOcON0qgAWJPM/1rIMc3WLepZV6d4U4w=; b=LWIOXb407zBxyy5cdHszoxDtMwQTUtD6oWyuA2LyeKqZzaFbI8GM1jR7YZdTlfgqzH usUjOvXK/KAyS5OvvB7yMc8RKIHhBUk7QnrxswFwOXMTVU4dkh/ybOTSL1Vowmocxf+t 9v4unnlNOyGlwTRwxjgziPssecwHfUpQTymVBppgVD67VuLlv1jQ75wCVny7NR8lztgy mgcwHgp8e64N7UkMNUHL+7WEwGicJjeqOWBsZpuVc/g+Ym+OKe74aSeg1gezNqnFwbT7 zTOciQDeEAh+1MzM2z9ngW8v5SQfbuL/og2qPA0hiP/lissw1HgtqX2wsXI6/+LIiDwI wf8Q== X-Gm-Message-State: AOJu0Yyiii0AI15ZBAL98/hnqNMP6ohFg1ezBff5rYcgqE1/0fZTvVNE DADOgZCjroPXuaq8p+SkRQJWO6YuXiQ83ARjv2v9i1ycTp8htk2xz7NDUdmJ2U28Dns+6V3o/6n pDH80nrBD X-Received: by 2002:a05:6808:23d5:b0:3e0:45ea:7fbe with SMTP id 5614622812f47-3e071a97f6emr1220176b6e.13.1726126817031; Thu, 12 Sep 2024 00:40:17 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:40:16 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 19/48] hw/pci: replace assert(false) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:52 -0700 Message-Id: <20240912073921.453203-20-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=pierrick.bouvier@linaro.org; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; }