From patchwork Thu Sep 12 07:38:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 827802 Delivered-To: patch@linaro.org Received: by 2002:adf:ab1c:0:b0:367:895a:4699 with SMTP id q28csp1142515wrc; Thu, 12 Sep 2024 00:43:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXITmP0NqEqYjl9T5b6yWNJoCVP96qsNMVGZ+tFU2teLlA/M665O6UDnZ3i46psH1lpeEaV3g==@linaro.org X-Google-Smtp-Source: AGHT+IGYmBsen4TlrPNgTBj6Wnult/7OIbz5tckYsmnhedYnKmmyeNXanlbqi03xMw2rJIvC2ZP2 X-Received: by 2002:a05:622a:11cf:b0:458:5482:c565 with SMTP id d75a77b69052e-458603dde29mr26047921cf.41.1726126994627; Thu, 12 Sep 2024 00:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726126994; cv=none; d=google.com; s=arc-20240605; b=cT6gsj/rMIYS+BodC2vHZhr+8VTIVS/oW8qCjBRI9iR5yi4NYolnqAv5ikMB727M1H eA5dicetC398jUYWJYhaXxUXhnXFoymPJqoE/+gV8PKGpaDe6BjLP06XSnfd+1RTOsU9 vRCYSEK1ZoAurK3uuwuexQjsqIfU3Dvw37I+8c0L7gn6XDXKIvamqQkuG6w6t6/+eIkR OEE9RU0t37UhH7anHYVxln0qCiWvLKREDLvhBuucnC3Z1IpNyzG54eAqRu1KpAMJK10A E56iqkgOlynXktOPWW4dZVT8U8usXilmm/X997WqSh9XqRgfvkBKsVj0hKLnxn2p5Gbz G7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F+rVp3/BLJYyjxO33P6GwzzAqjbQ85NDH2br5JtXUaQ=; fh=9lXHm2cv0EOsvaESlQxkp+iopfNbpS2ZXLeBYSea/ko=; b=V7bQ6QA1UK/zwdvgkPE144uMsEjUWou2LSxtLTKQqctsmDYWJYjSiyDcqL4gowWKAn GszM3ZEeAzzmb/AAeP/bO0yT9Xlv7bWNRuGAbtnjDfDJ9ovkgEapQIJBGZIe9ZkPqzJD A7WngQQL9O2VQ1gMQ5NzJfspP0+WuoDB8Ca+6UiWWlV9YkFT8GYRexScA483zl91RUf4 XrOtvhKymZprVl5G/m7U2/CrJAZAP4ko66iAmD0Ux2aTCs4ERxcfkw6fHx2NzhCBCilP sTAOIFlmqOlL5hXL1tAAfgsoLQAQaX7paNuFDE8IKXminxTTte/Hu1EFR9gwJek8HwCp NQSw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LGSkZnRl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45822f80f64si122870931cf.399.2024.09.12.00.43.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Sep 2024 00:43:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LGSkZnRl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soeRe-0006CW-Uh; Thu, 12 Sep 2024 03:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soeQu-0002ov-91 for qemu-devel@nongnu.org; Thu, 12 Sep 2024 03:40:09 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soeQs-0000K0-2w for qemu-devel@nongnu.org; Thu, 12 Sep 2024 03:40:03 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-710daaadd9bso335233a34.2 for ; Thu, 12 Sep 2024 00:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726126800; x=1726731600; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F+rVp3/BLJYyjxO33P6GwzzAqjbQ85NDH2br5JtXUaQ=; b=LGSkZnRljWDM7uymPWgDkrJXtxwNpgUSYPeRnmsHK+vvxl2kTaQyV/jv61LzjM3tEA tAUGB2JijT8NPhnWRRAi5Lhj2m4PiJxbR7VePAVRdr5mYp2j21eYHlXzfsUNrfd+cmKL VhiT+Lr92Rc//ATeNXAbzqCGqcWFixArz8R+CBX2vbMeXG+ZUhaGVferKu7E7GpAH4EQ KjnfGOvnowDsy6A9t1X7ira9Wa3Y/aKyyvkvuc0o/Ps9V1uuKVlXvM8MXJ7gEu+fgKRM TafiyXnnCArKWX8OVIxvbf2uhFoBwz7AOM73kFxWMwCdnZYEsacjpgL+8KiBR/DSBnOb 6hew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726126800; x=1726731600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F+rVp3/BLJYyjxO33P6GwzzAqjbQ85NDH2br5JtXUaQ=; b=Op6h9VDvef7XCxHzBP6LaGWMvjjFi7TRD0kJ3pBeUF5sH5nnoNZsetcpq23PwhZG+r bMVQq/QeXIg5Z7qz6RgBdul4ES/GfCH9QBd4rEUDGrwJkpB6fedkaPeZkvV9koYlhZ4R A2/GL2pNP9KHHfNKeos/gRzvcGP6VWAflErO6nUnTt4a5/r31JNbVOK2qrR61ZjqthAG bO1LL0rEPI3hJDm2zfqXJrp5FmumHMvcj0W+TuJ142RVSNt5TPqUNwB96Hij/X+J0Quu bSZyt4hAfWVWRtGCl/EZk6tIQd6WXIx80DpnEQOlc/WzZr7FbYIkYMjunfLZQ3PjHSnV HfoA== X-Gm-Message-State: AOJu0Yy9fnrq/ukR+DKtswT/2VAD7OnAOSvNFMSfO9tPDtfgR39qjmXE yBpsuF9JuM1XEz7gtqCqw1bD1gYfqW7uVqYmrK1kA/ff309lGXLRq3nRpyqC2g+W9WjNDx4EjIS odiYW6lZM X-Received: by 2002:a05:6830:4994:b0:710:b19a:cea3 with SMTP id 46e09a7af769-711094727c0mr2302235a34.13.1726126800291; Thu, 12 Sep 2024 00:40:00 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fb9ad87sm983458a12.6.2024.09.12.00.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 00:39:59 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Jason Wang , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , Marcelo Tosatti , Nicholas Piggin , Klaus Jensen , WANG Xuerui , Halil Pasic , Rob Herring , Michael Rolnik , Zhao Liu , Peter Maydell , Richard Henderson , Fabiano Rosas , Corey Minyard , Keith Busch , Thomas Huth , "Maciej S. Szmigiero" , Harsh Prateek Bora , Kevin Wolf , Paolo Bonzini , Jesper Devantier , Hyman Huang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Palmer Dabbelt , qemu-s390x@nongnu.org, Laurent Vivier , qemu-riscv@nongnu.org, "Richard W.M. Jones" , Liu Zhiwei , Aurelien Jarno , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Marcel Apfelbaum , kvm@vger.kernel.org, Christian Borntraeger , Akihiko Odaki , Daniel Henrique Barboza , Hanna Reitz , Ani Sinha , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Alistair Francis , Bin Meng , "Michael S. Tsirkin" , Helge Deller , Peter Xu , Daniel Henrique Barboza , Dmitry Fleytman , Nina Schoetterl-Glausch , Yanan Wang , qemu-arm@nongnu.org, Igor Mammedov , Jean-Christophe Dubois , Eric Farman , Sriram Yagnaraman , qemu-block@nongnu.org, Stefan Berger , Joel Stanley , Eduardo Habkost , David Gibson , Fam Zheng , Weiwei Li , Markus Armbruster , Pierrick Bouvier Subject: [PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached() Date: Thu, 12 Sep 2024 00:38:46 -0700 Message-Id: <20240912073921.453203-14-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240912073921.453203-1-pierrick.bouvier@linaro.org> References: <20240912073921.453203-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=pierrick.bouvier@linaro.org; helo=mail-ot1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c2..2f447a73fb8 100644 --- a/tests/unit/test-xs-node.c +++ b/tests/unit/test-xs-node.c @@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque) printf("Comparison failure in TX %u after serdes:\n", tx_id); dump_ref("Original", t1->root, 0); dump_ref("Deserialised", t2->root, 0); - g_assert(0); + g_assert_not_reached(); } g_assert(t1->nr_nodes == t2->nr_nodes); } @@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s) printf("Comparison failure in main tree after serdes:\n"); dump_ref("Original", s->root, 0); dump_ref("Deserialised", s2->root, 0); - g_assert(0); + g_assert_not_reached(); } nr_transactions1 = g_hash_table_size(s->transactions);