From patchwork Tue Sep 10 17:20:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 827028 Delivered-To: patch@linaro.org Received: by 2002:adf:ab1c:0:b0:367:895a:4699 with SMTP id q28csp423518wrc; Tue, 10 Sep 2024 10:21:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV6cgeQE1wdLZ03Lks0DdnxcvkdT/nFd1j5gu6nGvsRPgNbNuRCOjgpUvJzV5WUYvt0to3mlg==@linaro.org X-Google-Smtp-Source: AGHT+IF8B3zABgV6XnhPTDGjVHv1rlWven+LprbXgZKi2yVn5GxhZVgD4wKkNa9mHteHHktQhKyL X-Received: by 2002:a05:620a:1728:b0:7a9:af25:802d with SMTP id af79cd13be357-7a9af258469mr1565954685a.40.1725988914441; Tue, 10 Sep 2024 10:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1725988914; cv=none; d=google.com; s=arc-20240605; b=HormCJLp0QVbHU7WPWtyRSANz+GUEzOykVXXHrUGpcT+VSqCi4GO3aEVDg6Su3lP2t ZAaTqD9+WHtH3wjA71v2kpqM3UqunE4sJ5r3de/c2wRTknUv30aWTR6j+uX3kPc8aQTY f5SqM6ksfzUdGf243urzOJ7z6aYPhrPQRGVxciLmOS/pJw3PpnFXu1y926uJi+bPCLTF PNhay5t2Ak4WAi2bbbBUe85lwRxteYX4Lfamy8N/t9YX4160tZj9FWsXOn6e2EnBd+zD c+XB6BnqWURUiWTYZXBRFg0oMcreIgJ/6nsnwuhDC1ixVQoywc/9+YvYBPl42hlMmlJi KLSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pjRe9WOOgnZVoD/80IX7JyvW7Ap72zwjrzdwxvANZMw=; fh=OhV3JIe6s7BYVATlKJ3Ib2ybA9N3ZJt49O4IlF1MoN4=; b=BxJecHJJVw+uSbZGeeAyd/+6u4O41lZkgU5hzCW6wWm5Zk0MGJCGUaZRA2JdRESwd2 xg4MFL+1sF1knjZlX5aaLbPPuTPpFnsgPWtXko27Cb4qSlEw71s5LXj6TpOyh60undRh YyRc2roofTRYaVgfOMWDwAuJd8kN5qGEnMJ2jVSVLLhAMVq4KHoXGuTKL7+/tqxjf1+Q B/Rlk4Al2jk+svrBfD7Xwx4W7r4TH6UjySy4h6uRdI1mmMde4bIMT/Ji+YhoZuH5hTby cPqfv/a49OBodoihw/FK3+f47Agcmwvq4fFks2ndlZC2EjNjCk16XfFtAkgUelUVG/fh pWIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=phGalolR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a9a79ee9f9si810885485a.159.2024.09.10.10.21.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Sep 2024 10:21:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=phGalolR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so4Xw-0003MV-Nv; Tue, 10 Sep 2024 13:20:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so4Xr-00035i-CC for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:20:52 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1so4Xp-0002mV-DM for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:20:51 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2d892997913so3807925a91.3 for ; Tue, 10 Sep 2024 10:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725988848; x=1726593648; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pjRe9WOOgnZVoD/80IX7JyvW7Ap72zwjrzdwxvANZMw=; b=phGalolROCwVN2XfIwjTJ9mGmKLK3SPrBZ2wiK4PHd0UFabmTnEsJtmgIS7G0o0ILi DnfIfrt0JmPBThB8B36IRj/r/HVh0vvBV03+7juJvnVAhWCmbhcbq6++GGCjsM7V+g9f iLe81OA7b4XT4J/zhrUtEmDJWJqQ9XAvZC1wMZhkE2Hb1tMAM9ae/lMFthVFfmZaRTiR kEK8n9rskB1f3bGTMIjlwbprNulJzvqjgwJ3hOKNPVGnDJo5bQ0aVLDRJL6Kr6R7/rVy a3hHVQ2ngZebWFpMA4vf3dFDR3h/yW1X1yZZS2qzEMWtxTa47KVRfZnulVHMl22RUMfj qGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725988848; x=1726593648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjRe9WOOgnZVoD/80IX7JyvW7Ap72zwjrzdwxvANZMw=; b=P8uK0ovcIFzu2bqRQSI212aWZJhfitIxKZJAd218b3uRC+z37JsSWhIsO4IgycpYsd PpPm+eBBJpmcwej8/6yDbk9c02b4N4+olxJySLOsI5FUSyfmKnI6hJcTL8xG2ry72R26 F7YHJr28+XBGOPQNqOhsFQVW/vEn4PrVc3DsKvh2hDLa//x8WTY8v3BTFzTKBsr4oFkd yK2UzRPw9pLL+umxasbXX9A8fVnVIuNwzw6OI9vDF6iveRNKM/IgdpxZvOU4hcuxExxP edreeYoiKk7bl0N0urWGoHzs3Fhz4NfShOvJxI8zm/TxM29kIiGR+bDo6UyU/z6kojrN 9KEA== X-Gm-Message-State: AOJu0YyfWkRFkeAySKsKvER42eVKMk6SnKHN/QtVQEiqknO0+j8imXtf WBTgJIjX9T3+plSjASNAHZoAJR1AvpsLBIu0X/uScMZKwAGdmCDlTLWVi1+XTaQtHGfMS5c+2u5 +49NS6w== X-Received: by 2002:a17:90b:3b84:b0:2d8:8f24:bd86 with SMTP id 98e67ed59e1d1-2dad4de167dmr16170621a91.8.1725988847740; Tue, 10 Sep 2024 10:20:47 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2db049883e5sm6685310a91.50.2024.09.10.10.20.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 10:20:47 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Daniel Henrique Barboza , Alexandre Iooss , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= , Eduardo Habkost , Richard Henderson , Pierrick Bouvier , Paolo Bonzini , Marcel Apfelbaum , Yanan Wang , Mahmoud Mandour , qemu-ppc@nongnu.org, Zhao Liu , Xingtao Yao Subject: [PATCH v8 2/6] plugins: extend API to get latest memory value accessed Date: Tue, 10 Sep 2024 10:20:29 -0700 Message-Id: <20240910172033.1427812-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240910172033.1427812-1-pierrick.bouvier@linaro.org> References: <20240910172033.1427812-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This value can be accessed only during a memory callback, using new qemu_plugin_mem_get_value function. Returned value can be extended when QEMU will support accesses wider than 128 bits. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1719 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier --- include/qemu/qemu-plugin.h | 32 ++++++++++++++++++++++++++++++++ plugins/api.c | 33 +++++++++++++++++++++++++++++++++ plugins/qemu-plugins.symbols | 1 + 3 files changed, 66 insertions(+) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index c71c705b699..649ce89815f 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -262,6 +262,29 @@ enum qemu_plugin_mem_rw { QEMU_PLUGIN_MEM_RW, }; +enum qemu_plugin_mem_value_type { + QEMU_PLUGIN_MEM_VALUE_U8, + QEMU_PLUGIN_MEM_VALUE_U16, + QEMU_PLUGIN_MEM_VALUE_U32, + QEMU_PLUGIN_MEM_VALUE_U64, + QEMU_PLUGIN_MEM_VALUE_U128, +}; + +/* typedef qemu_plugin_mem_value - value accessed during a load/store */ +typedef struct { + enum qemu_plugin_mem_value_type type; + union { + uint8_t u8; + uint16_t u16; + uint32_t u32; + uint64_t u64; + struct { + uint64_t low; + uint64_t high; + } u128; + } data; +} qemu_plugin_mem_value; + /** * enum qemu_plugin_cond - condition to enable callback * @@ -551,6 +574,15 @@ bool qemu_plugin_mem_is_big_endian(qemu_plugin_meminfo_t info); QEMU_PLUGIN_API bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t info); +/** + * qemu_plugin_mem_get_mem_value() - return last value loaded/stored + * @info: opaque memory transaction handle + * + * Returns: memory value + */ +QEMU_PLUGIN_API +qemu_plugin_mem_value qemu_plugin_mem_get_value(qemu_plugin_meminfo_t info); + /** * qemu_plugin_get_hwaddr() - return handle for memory operation * @info: opaque memory info structure diff --git a/plugins/api.c b/plugins/api.c index 2ff13d09de6..3316d4a04d4 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -351,6 +351,39 @@ bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t info) return get_plugin_meminfo_rw(info) & QEMU_PLUGIN_MEM_W; } +qemu_plugin_mem_value qemu_plugin_mem_get_value(qemu_plugin_meminfo_t info) +{ + uint64_t low = current_cpu->neg.plugin_mem_value_low; + qemu_plugin_mem_value value; + + switch (qemu_plugin_mem_size_shift(info)) { + case 0: + value.type = QEMU_PLUGIN_MEM_VALUE_U8; + value.data.u8 = (uint8_t)low; + break; + case 1: + value.type = QEMU_PLUGIN_MEM_VALUE_U16; + value.data.u16 = (uint16_t)low; + break; + case 2: + value.type = QEMU_PLUGIN_MEM_VALUE_U32; + value.data.u32 = (uint32_t)low; + break; + case 3: + value.type = QEMU_PLUGIN_MEM_VALUE_U64; + value.data.u64 = low; + break; + case 4: + value.type = QEMU_PLUGIN_MEM_VALUE_U128; + value.data.u128.low = low; + value.data.u128.high = current_cpu->neg.plugin_mem_value_high; + break; + default: + g_assert_not_reached(); + } + return value; +} + /* * Virtual Memory queries */ diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index ca773d8d9fe..eed9d8abd90 100644 --- a/plugins/qemu-plugins.symbols +++ b/plugins/qemu-plugins.symbols @@ -13,6 +13,7 @@ qemu_plugin_insn_size; qemu_plugin_insn_symbol; qemu_plugin_insn_vaddr; + qemu_plugin_mem_get_value; qemu_plugin_mem_is_big_endian; qemu_plugin_mem_is_sign_extended; qemu_plugin_mem_is_store;