From patchwork Fri Sep 6 06:53:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 825912 Delivered-To: patch@linaro.org Received: by 2002:adf:a345:0:b0:367:895a:4699 with SMTP id d5csp662074wrb; Thu, 5 Sep 2024 23:56:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV3jwAmYJSjYmypFt7/7LJgsG4dNdNCl/1y262bqXvc9aDKUUfN4dARG0lpTg8UokYsOci3NA==@linaro.org X-Google-Smtp-Source: AGHT+IHyy7hsvee1o6O7PaaOuObHkV2n3DiZJxLUqfUTm+nkmBSgx9jlTZMaRdO1tqFh9oBVuHTW X-Received: by 2002:a05:620a:4608:b0:7a5:1ca:d010 with SMTP id af79cd13be357-7a988886e4emr1482346385a.12.1725605807140; Thu, 05 Sep 2024 23:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1725605807; cv=none; d=google.com; s=arc-20240605; b=EMvFV+9/KNZ/CGqGYlitt3DWXdZTtOxYcjn189qMqus+wc/qT5qTDvJw5hS1bxHWek TonQCwNdDMC7ydeHUQ34Mx1xgvFOHxIF4xDZInY0VLDM2n4f/B2KyJRcKRaP2wxSeN9n sj0nyt9GC7fuznA0QXHeLm7Ha5ZqKPUiURzmU7t+i0wvjmbk502tID8LXOoTfYZxcoMx bfVkg4aySfA7axEXr/FlpfF1l09Eoh2D4czY8BO8iLIP6NHVxtAKWmZnEOn/h04pXEC8 TxY+mF70wpVoOynfzVGvBnkfXWnX+VyPLK697hIQAmmeuUSUEkCuEwouludfi3puI/d8 ObRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=2v/itSbhrsvC+OQ9czB9xUrt9HijAS9HoAxkePOeUAI=; fh=xcz4BIk6UKjOo0wG05W3ZY0KrLZqRuYba2k7grc93iY=; b=KyAMtzsqbxWn6q/JsHhlpArN08wsg3FjqPkvyvfw9Oti3nwXcCf+CfoFVydaGC05Zf YO3vxMiqHconR5nPrWLW+SLhpqPSiPy5cr2/KIGxGpG9gWZo8dch/XfL0Ja7J/LMTew8 7x4T1rR8RoIkwLBwpSx/8w0ERdO6TEjM1Nv6rcWE1sbXFFEy7j6kogLYNFi4kyFh5Q8a qKJbCEOhU31j/nYtcVdbpMhE18gLD5l00tBYNw5tmKchimJh0ANles+IqP8055yFjbZh hxSRcPeF1SW9U64D/1DWyiFJ4xdAjkKTXWVygUO00d9o/QJz7EWQnYBfUqQ9TMrBp+Lb suaw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a9956beb34si209474285a.227.2024.09.05.23.56.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Sep 2024 23:56:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smSrt-0004d3-Jo; Fri, 06 Sep 2024 02:54:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smSrq-0004RK-NO; Fri, 06 Sep 2024 02:54:50 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smSro-000307-UY; Fri, 06 Sep 2024 02:54:50 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id E028B8C23A; Fri, 6 Sep 2024 09:53:11 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id A6BD91333F2; Fri, 6 Sep 2024 09:54:29 +0300 (MSK) Received: (nullmailer pid 43335 invoked by uid 1000); Fri, 06 Sep 2024 06:54:29 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson , Daniyal Khan , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell , Michael Tokarev Subject: [Stable-8.2.7 05/53] target/arm: Use FPST_F16 for SME FMOPA (widening) Date: Fri, 6 Sep 2024 09:53:35 +0300 Message-Id: <20240906065429.42415-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson This operation has float16 inputs and thus must use the FZ16 control not the FZ control. Cc: qemu-stable@nongnu.org Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)") Reported-by: Daniyal Khan Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-id: 20240717060149.204788-3-richard.henderson@linaro.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2374 Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell (cherry picked from commit 207d30b5fdb5b45a36f26eefcf52fe2c1714dd4f) Signed-off-by: Michael Tokarev diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index 46c7fce8b4..185a8a917b 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -304,6 +304,7 @@ static bool do_outprod(DisasContext *s, arg_op *a, MemOp esz, } static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz, + ARMFPStatusFlavour e_fpst, gen_helper_gvec_5_ptr *fn) { int svl = streaming_vec_reg_size(s); @@ -319,15 +320,18 @@ static bool do_outprod_fpst(DisasContext *s, arg_op *a, MemOp esz, zm = vec_full_reg_ptr(s, a->zm); pn = pred_full_reg_ptr(s, a->pn); pm = pred_full_reg_ptr(s, a->pm); - fpst = fpstatus_ptr(FPST_FPCR); + fpst = fpstatus_ptr(e_fpst); fn(za, zn, zm, pn, pm, fpst, tcg_constant_i32(desc)); return true; } -TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_h) -TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a, MO_32, gen_helper_sme_fmopa_s) -TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a, MO_64, gen_helper_sme_fmopa_d) +TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_fpst, a, + MO_32, FPST_FPCR_F16, gen_helper_sme_fmopa_h) +TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a, + MO_32, FPST_FPCR, gen_helper_sme_fmopa_s) +TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a, + MO_64, FPST_FPCR, gen_helper_sme_fmopa_d) /* TODO: FEAT_EBF16 */ TRANS_FEAT(BFMOPA, aa64_sme, do_outprod, a, MO_32, gen_helper_sme_bfmopa)