From patchwork Fri Sep 6 05:16:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 825895 Delivered-To: patch@linaro.org Received: by 2002:adf:a345:0:b0:367:895a:4699 with SMTP id d5csp637545wrb; Thu, 5 Sep 2024 22:18:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXByqtnOOLcnETdM4wNl5r/o4VHrFuW4StVYCZlYpNOMNUJLjFPSa0vpP2/EvZZGR2d5KDO7A==@linaro.org X-Google-Smtp-Source: AGHT+IG4t1XrQ+En1ydyJhsthKtYZzy3zZ0FahkwRW4NaWCtOqupauAxMwHz1yzWwQ0L0gM2JAoI X-Received: by 2002:a05:6122:92a:b0:4f6:a7f7:164d with SMTP id 71dfb90a1353d-50221423548mr1651437e0c.8.1725599933718; Thu, 05 Sep 2024 22:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1725599933; cv=none; d=google.com; s=arc-20240605; b=E5wYtDW+yleW0fiGnF21q0NxHyjEw40aUCgVtXd3rCV9GyyiG1svLJSYLK21j2kwjD 56y4DyoFJygwz2SNlA3H0gT0iVw7UfK6XjGXim5l2A15VoV0lYdW7vvSBkRGzsgVbya0 nV2a8FzqhH2HCtCMtwp31gJwUvWFKh8fLzQ93G1X545wN1GZoffXZc9sEKDLCvCsZKys OaP8dJQLDrJfWmWHLZn8fMQ94YY2IjUiGERiHbqwOaddI8qtS5rjgMzek5G8Ivjo1pyj BU4S2FU/S9wn5Frl2s3/B+1W3kwhTkMJMcPPcoMt65fxFfqaQu3icjSxJHAuwwHCtmW+ Z6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=JTlM5nxQbkJr/OsHMk1hDNcjl9gtAPvPaaxbxJSCbQU=; fh=xJ1URYKcMN3TM0/XAv5v+aCN+5tIbzAdcfBx5UNgoLw=; b=OUiXs8n+8P43dRIoEzSscfANotAQ28GIgKHL9nC5L8jYy9m9bILEDda3S2hW4ZyN4X 2Y0ioWBisP/rrTufq53KhAKa1HZ403EzadILb4fU9BZDp84s8C4lFGwYK3E1OGJ3YL2t xof6bO3Yk0zMZGvB+mTKPs7i7Ak4D0NDO58n2kwdOU/ZIjBlECmzYQuQTzILsQ6dxWbo 4UStZQfwwbZAG22Noeg1/IsLiShSgqZ+8PjyQQjjo3pysHkbbK8VTSzTn2O9RAhumREk RIRIzZ+eQ7BDc8AFhqPI9GowxRsV9oQaHPdDNuaQIpCr0N3nRFCCfps3/05Qm707zT8r CwEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45809c4d110si18867231cf.132.2024.09.05.22.18.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Sep 2024 22:18:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smRMJ-00088P-UE; Fri, 06 Sep 2024 01:18:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smRMH-0007xr-4F; Fri, 06 Sep 2024 01:18:09 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smRMF-00083S-Kw; Fri, 06 Sep 2024 01:18:08 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 565AA8C126; Fri, 6 Sep 2024 08:15:17 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 06E5813336C; Fri, 6 Sep 2024 08:16:35 +0300 (MSK) Received: (nullmailer pid 10439 invoked by uid 1000); Fri, 06 Sep 2024 05:16:33 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , Richard Henderson , Michael Tokarev Subject: [Stable-7.2.14 18/40] target/arm: Ignore SMCR_EL2.LEN and SVCR_EL2.LEN if EL2 is not enabled Date: Fri, 6 Sep 2024 08:16:06 +0300 Message-Id: <20240906051633.10288-18-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell When determining the current vector length, the SMCR_EL2.LEN and SVCR_EL2.LEN settings should only be considered if EL2 is enabled (compare the pseudocode CurrentSVL and CurrentNSVL which call EL2Enabled()). We were checking against ARM_FEATURE_EL2 rather than calling arm_is_el2_enabled(), which meant that we would look at SMCR_EL2/SVCR_EL2 when in Secure EL1 or Secure EL0 even if Secure EL2 was not enabled. Use the correct check in sve_vqm1_for_el_sm(). Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20240722172957.1041231-5-peter.maydell@linaro.org (cherry picked from commit f573ac059ed060234fcef4299fae9e500d357c33) Signed-off-by: Michael Tokarev diff --git a/target/arm/helper.c b/target/arm/helper.c index acc0470e86..5c22626b80 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6335,7 +6335,7 @@ uint32_t sve_vqm1_for_el_sm(CPUARMState *env, int el, bool sm) if (el <= 1 && !el_is_in_host(env, el)) { len = MIN(len, 0xf & (uint32_t)cr[1]); } - if (el <= 2 && arm_feature(env, ARM_FEATURE_EL2)) { + if (el <= 2 && arm_is_el2_enabled(env)) { len = MIN(len, 0xf & (uint32_t)cr[2]); } if (arm_feature(env, ARM_FEATURE_EL3)) {