From patchwork Mon Aug 19 22:50:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 820280 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c8:0:b0:367:895a:4699 with SMTP id m8csp1652943wrb; Mon, 19 Aug 2024 15:52:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUQxLSL3iQLD82Fn9d0NTLp2cnHX5ZM1pvMj+V1mXlQuI8rGk7+/8oDlVuT/F0SuSoNjCLUCw==@linaro.org X-Google-Smtp-Source: AGHT+IHzwl+fainjiHRnn928L2M7ydLuv/HtbL+zRPYHL7rUzEUUvYIAIEZjPLDBq76tVrcnneKx X-Received: by 2002:a05:6830:61ce:b0:708:f1ad:c4bf with SMTP id 46e09a7af769-70cac8905ccmr13056528a34.27.1724107934789; Mon, 19 Aug 2024 15:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724107934; cv=none; d=google.com; s=arc-20160816; b=j9uxPIPKeZvFS1Ud6Y8czBw/L7sYhzOVoSxd0LrWiRbHMC+/YXcERKStJ9mPgYp9Rn 41f4ltTeFrfjbpZcREWC4YAjOoXkfQANi/33oLv0OCq9PoJYIPU/ENefkbAyKYoEOAxL 4ul4anN2o1249GFFxnOhEhYobiayyrvDGL0DsB+8QHXycqfwM9qngF9ljdaf9tyRAOT9 TBpCk58CEdn9W1VJpmm56iqfTs9d1r5bXNM0wWy172Oimx+bNh68V+x1OerVIOLsBG80 OWRyMvnJwXkYTSkHRfowvHk1XoTKj2Z3DRrqP5/U8aAJgg1b8C7BTYI8pyr4DT3vxkFE qnyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wXvH5zTUg5dAcDnGKaZdfrZjdGQ55VlC72RabvGbTBU=; fh=jiKM5Jsg5IywfmBhne3oNkoWpsaS5OqwqtJOUwmjFpk=; b=VYTyAcJtR56LVrLX8aHwx5BFdmEQXOck51AkN6aKRk+jEOzxksKC5s92hc924HujNM NFDz0AqN8DjrjiAMzcRnN/msnClteShYEjfmvgqt71fKs9lU3zYJNZqNRNgYYoCJKO/q 2CqOzIgloTvCPHaw285fnfWfHfNMrEASa+3IFOCw/wUugNhxMa29uwIivucPllKD5szR iP/iNhgb9m0XYhFpFKJq11tlw0LWnJtQgHs04ZeleIYqh4skRoK5G6mv6b+OTWGjM/23 UnsvACQ3NgfOtHjDeZGjbsd7IUnc7ThCbNUi4QKWjvEK/PhifmP96Q/n/7DPbSBiBcgq ZBOQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hYkphleQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45369fe58c5si129488441cf.31.2024.08.19.15.52.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Aug 2024 15:52:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hYkphleQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgBDq-0000IU-CC; Mon, 19 Aug 2024 18:51:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgBDn-0000Ap-KP for qemu-devel@nongnu.org; Mon, 19 Aug 2024 18:51:31 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgBDl-0000fx-RB for qemu-devel@nongnu.org; Mon, 19 Aug 2024 18:51:31 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-42819654737so37531655e9.1 for ; Mon, 19 Aug 2024 15:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724107888; x=1724712688; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wXvH5zTUg5dAcDnGKaZdfrZjdGQ55VlC72RabvGbTBU=; b=hYkphleQqaKitRHcdH+7hxl3x/XQytVH/Rb2tNWoGAOi/8KG00EsW/V0EUtiWdHZX0 j2pQjCuriAxQgLm8sKcBqT8cBq7zLdRpfPjM1mV577UPd62P6Ur7hY4jmfKqV8lxwQz0 etktUwGf/nD3RFDsB3+xBLhK6a3XHssXMNWKfdQtyc+S/SuqggvkUWYQ5JZV5j8yh9Tm gGh599hO21enp22FvcYvcE/mVLD0D49JuInP2OZnLXehoI5I+SCcELhGVd6qq/RNgPvJ eWGJbNee2L5HL4LOWtXJJUkQAHJ9MSAOJSroPChx6Vqyd45/DkcPyMaxFJ+PliRuWq7W Ni8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724107888; x=1724712688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wXvH5zTUg5dAcDnGKaZdfrZjdGQ55VlC72RabvGbTBU=; b=aaEGWqq5X9pszdtnGW4fRFQ85+uQ8zno4zJfNH2oIIbKGslJVpH9WRDiG7xkbfvOc4 PpHkApaVWfaNqNc+kwfMMuNcUbISy9wqYXxl3Fzv66iTm6nq7S8LqV4JkHkF/6RC7Dka VkhIHV0PN/FfjLPKasb0awjiQHw5Mlajr+VGIvJGh3yZXFCWM4qbm9Z18UG5XtLqDMUX qT2w4qTFzzDsEVIEN19qkI4pZKiM6yII4vWV/GPxzUN1pO+0WiQz1l5fwyzjh/pKruaR OjqyvGOxPt0OOZPwIoULH49rD8aLTYOyJypcy2Uw1C/xzBMqd733nLy6yCqktmwT72tS WfQw== X-Gm-Message-State: AOJu0YwrOPYaE7Nkb7OsD9VAOd2ci9YR+46I+C++75ONtUEP1tlyI7Og pw308env7iGZ2+PWmHqWB3wm4MQ2OsFIFErQFMUpfF6bbDxMhGjOXJhxdEMMfGxinGygZ/gzmvC fLU4= X-Received: by 2002:a05:600c:5494:b0:426:6edf:6597 with SMTP id 5b1f17b1804b1-429ed7b8c11mr75319395e9.19.1724107887915; Mon, 19 Aug 2024 15:51:27 -0700 (PDT) Received: from localhost.localdomain (88-178-97-237.subs.proxad.net. [88.178.97.237]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded17cb3sm175578825e9.10.2024.08.19.15.51.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 19 Aug 2024 15:51:27 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PULL 02/20] hw/mips/loongson3_virt: Fix condition of IPI IOCSR connection Date: Tue, 20 Aug 2024 00:50:58 +0200 Message-ID: <20240819225116.17928-3-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240819225116.17928-1-philmd@linaro.org> References: <20240819225116.17928-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Jiaxun Yang >>> CID 1547264: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ipi" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Resolves: Coverity CID 1547264 Link: https://lore.kernel.org/qemu-devel/752417ad-ab72-4fed-8d1f-af41f15bc225@app.fastmail.com/ Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240621-loongson3-ipi-follow-v2-2-848eafcbb67e@flygoat.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/loongson3_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c index 27a85e3614..2067b4fecb 100644 --- a/hw/mips/loongson3_virt.c +++ b/hw/mips/loongson3_virt.c @@ -574,7 +574,7 @@ static void mips_loongson3_virt_init(MachineState *machine) cpu_mips_clock_init(cpu); qemu_register_reset(main_cpu_reset, cpu); - if (ipi) { + if (!kvm_enabled()) { hwaddr base = ((hwaddr)node << 44) + virt_memmap[VIRT_IPI].base; base += core * 0x100; qdev_connect_gpio_out(ipi, i, cpu->env.irq[6]);