From patchwork Tue Aug 13 20:23:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 818862 Delivered-To: patch@linaro.org Received: by 2002:adf:cd01:0:b0:367:895a:4699 with SMTP id w1csp431178wrm; Tue, 13 Aug 2024 13:28:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVXwXkPe/L1cr2+ySwxKMgqpQ2vehrSzfOPY1JtfMkeE3Xc5sK6+F2+GtPUVRzKmu9pE0Rqph3fiE/tabxCdGY+ X-Google-Smtp-Source: AGHT+IHDVtWUWKgjkjSMHiEWSpttL2pN+8EtKmZXhB4fZ67jE84USeG9SPBYRPJ4VzgqKUJQaLbm X-Received: by 2002:a05:620a:4445:b0:7a2:32e:3c47 with SMTP id af79cd13be357-7a4ee33cb71mr84531485a.34.1723580897640; Tue, 13 Aug 2024 13:28:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723580897; cv=none; d=google.com; s=arc-20160816; b=iLYG6HAcXlgC7OjqatjV+ESK5BTbmDifdOEojF/ZDLt/drqPCxeyW10IPZ7DOa9oWi DTbnYG51G9g+hN6ZSFsZRBZ8EOtbgTBVp7WzoS6qhaQZ7AtUax0g3GRaKfwQ8uQXatTa pG/x2KYGxjrHyGBzRLEPV+fiyrJFkX0QR6InNOZjeR5WTr4m0bqBKo2sylyzLxdeBVsa Ltdj3eFEc1SikvxmiguF/BVlcAXriFfsdAlcw8QiIVoThBHccpZRc2hGkcRQH8ClZGoP owFn/DfnnvOR0a80yYZbE7WV09devNx0UL8fTTPrhxPvqPii1++79n/Rm9iCt30Lr9pL dm6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0GxFDxNA+tjm9dd3YyBkmqa3TunWqvDtTEUpcD5o2pA=; fh=Ip02gOv1lgiIzx7E9rCtSzygLd40BfH9FLx7CcJdySM=; b=vVTEj9sd91ehGKAKQaVVDieSFafLo5YgFMYZRM6LKQbbjllwkR8R+c9hOi23Nl0uM2 q+n43kh+U6nreE6PxdbOxn/iQEzfhWdcQ0c3dWtVxKiynpTu/zmaPwojV/Ibe53t1jQp C3JCA3cut9hqvqSJgvErXJ+Jm7C3IZtnR3U5y3aRGbBCQZWaVlUVOOPXNS64D91zXovV SywClAB+S34aSSQI/iAVzV+fkGdsYiV4tnRl0z7Q7M8re9YWHuflGuQaQV4Zkyi26be6 O8YQoSNJTzAjsWIJ1wRg73FVdkv0ZjOoQpuJUunH7jxeNIzMxl3GZFvDnNsOtTNzjl2A NiNg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hwTr3Wem; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a4c7df5857si891705185a.226.2024.08.13.13.28.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Aug 2024 13:28:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hwTr3Wem; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sdy3V-0004WJ-Ej; Tue, 13 Aug 2024 16:23:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sdy3O-0004NI-Ts for qemu-devel@nongnu.org; Tue, 13 Aug 2024 16:23:38 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sdy3K-0006AU-U0 for qemu-devel@nongnu.org; Tue, 13 Aug 2024 16:23:38 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-52efc60a6e6so7859453e87.1 for ; Tue, 13 Aug 2024 13:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723580612; x=1724185412; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0GxFDxNA+tjm9dd3YyBkmqa3TunWqvDtTEUpcD5o2pA=; b=hwTr3WemTnyV45lich1ruVLj/Mk3k2/xVr5v7MoW+gf02fTgn6xi84bNCf+rtp3900 WXa4iCsOponY6jVwHmyPkH75oPzYzbkVYLFKjT1PR5qWmIrK3kD3iNL1kVCtR2SQn1CF uM4jOk+LffYrtKBacXfimTRQXcFkdV0sD0DKsgugv+tfOWY6ia+X73Jry1D+cWsc9So3 F26NyfLdhz87b7Ddxk+uWH85gTlD/0QEYD6PLWfLsds2UkpXOiuLw23micVEBq4RXIpT b5WnHIETZBNNc743KylVIVWRWlIBs0IsDuqp1U2dvQ7V9gHssBGUnoCw8RjcRx00sYP+ E9bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723580612; x=1724185412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GxFDxNA+tjm9dd3YyBkmqa3TunWqvDtTEUpcD5o2pA=; b=mzmoKBUzF/AKeH2Dko8EqKXjtwBFLSxMisC1wBv90cPkgcedcQKZkIrWDQy80S9anz x91c/IxHCEkg3/hyvqr/4Fl5BhqoUflgU6oIrXLr/vBS1bQBSB0vHZ9wDtwvJ85kSKfB 3B9Rf/WIHq2Y/cD+AyzJPOzWyXNs+9OPWYQR3oyVP7aHdLw+BCoJTC/NtThWIi6EqG+3 zt8DR4gZHwIgLhPyeQosS0KazT/E4cO1u2MxXwZ5dYvwRaeVzn+Lsje7TPJhxbo/tfjt ttnTFz3E7kztXRTMQ4jdlClMZb6QuGQ3cyOiq2B9ozxJErvb0YNY+/AmCkTbevg4MG7A ItYw== X-Gm-Message-State: AOJu0YyQ5o5M99ksW1uIFhDvtb8P96uqmbsMxRuSFfmW3IZQG35FpRnG 7ykheeNZR69FTIy1zEQmdeK1M4HLM+k0BVcf+tGPTIafk0MWPYCgr/gPzZnCIns= X-Received: by 2002:a05:6512:239b:b0:52c:8596:5976 with SMTP id 2adb3069b0e04-532edbcce45mr270967e87.55.1723580611264; Tue, 13 Aug 2024 13:23:31 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429d877e066sm32268685e9.1.2024.08.13.13.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 13:23:30 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id BB7655F930; Tue, 13 Aug 2024 21:23:29 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Michael Roth , Palmer Dabbelt , Mahmoud Mandour , Pavel Dovgalyuk , Yoshinori Sato , Weiwei Li , Eduardo Habkost , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Markus Armbruster , David Hildenbrand , Beraldo Leal , Liu Zhiwei , Eric Auger , Song Gao , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-arm@nongnu.org, Peter Xu , Jiri Pirko , Eric Blake , Fabiano Rosas , qemu-s390x@nongnu.org, Peter Maydell , "Michael S. Tsirkin" , Daniel Henrique Barboza , John Snow , Alexandre Iooss , Konstantin Kostiuk , Pierrick Bouvier , Cleber Rosa , Ilya Leoshkevich , qemu-riscv@nongnu.org, Thomas Huth , Paolo Bonzini , Richard Henderson , Jason Wang , Bin Meng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Gustavo Romero Subject: [PATCH v2 04/21] configure: Avoid use of param. expansion when using gdb_version Date: Tue, 13 Aug 2024 21:23:12 +0100 Message-Id: <20240813202329.1237572-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240813202329.1237572-1-alex.bennee@linaro.org> References: <20240813202329.1237572-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Gustavo Romero $gdb_version is now used in more than one conditional case and its usage in such cases may increase in the future. Therefore, avoid using shell parameter expansion when using it by setting gdb_version to its final form. Signed-off-by: Gustavo Romero Message-Id: <20240804161850.2646299-3-gustavo.romero@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240807114059.2339021-5-alex.bennee@linaro.org> --- configure | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a3aa257fd3..97de85d710 100755 --- a/configure +++ b/configure @@ -1103,8 +1103,10 @@ fi # gdb test if test -n "$gdb_bin"; then - gdb_version=$($gdb_bin --version | head -n 1) - if version_ge ${gdb_version##* } 9.1; then + gdb_version_string=$($gdb_bin --version | head -n 1) + # Extract last field in the version string + gdb_version=${gdb_version_string##* } + if version_ge $gdb_version 9.1; then gdb_arches=$($python "$source_path/scripts/probe-gdb-support.py" $gdb_bin) else gdb_bin="" @@ -1673,7 +1675,7 @@ for target in $target_list; do echo "GDB=$gdb_bin" >> $config_target_mak fi - if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge ${gdb_version##* } 15.0; then + if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge $gdb_version 15.0; then echo "GDB_HAS_MTE=y" >> $config_target_mak fi