From patchwork Tue Aug 6 12:51:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 817050 Delivered-To: patch@linaro.org Received: by 2002:adf:e00d:0:b0:367:895a:4699 with SMTP id s13csp1785427wrh; Tue, 6 Aug 2024 06:00:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVB8HvdGJVpA9uMEH5PDy08d6tX8D46JDLbEHydFsRXn9D7WMVx71SdZZWJPtxp5Emy4dklUiqVm2sDMSGBzb9/ X-Google-Smtp-Source: AGHT+IEPUbpUMBlrjHG/gfd5/xHUTvnmPDupqbEE0uzPAA6ZjqJ/wUXy65keK2djDmjxNp05phid X-Received: by 2002:a05:6214:5bc3:b0:6b2:a333:2a9f with SMTP id 6a1803df08f44-6bb987ae578mr260410716d6.23.1722949253770; Tue, 06 Aug 2024 06:00:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1722949253; cv=none; d=google.com; s=arc-20160816; b=x3sOXO1rs4PDE0FX+33G7pRYDaO2kcMcUOYCTu+GiarSHG5J3vUIBL1oLAMazqKnZG Il39EIIAg9SCsXZuFbxcGOxTYKxMZcY4UeRK9np/XBE5+lW/Nf9qUkQ64YFNs3jjsYpq vukMNIUKaYFgMCz+IM9p0aAk6Omh6cbrSi08onvt+wDIAWvdPKK//BY3eSxwPM4HHbEV 2coYiFmAMGrFyRAXXP4wAhITfWH4v9qQbbBXAT/7RofKQQaKcAzmm1f+lflTMOaV+xxa 45lhdTxXnAKRJI5dH/hwHMOBt+v7FvYNysVocBLwmw5ZVj0dk2ywV52aHYDIKod09HyM Rngg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0GHmHGgb11iYqcqPSgHHl5+4znvZdtn/oYi94we9BmQ=; fh=CxGANQnxl0w34GvKO0j3aLxcHGRl2QR9Bm7QFKqLsvg=; b=st2Cglze+ElbFQJiSdhlEhkFTUtnOm8R3UdYQ97U+Zkw4+BLDFWcTRQM5egb/sqzbO XHo9m1in9yROjoCyKcM43x758vBkIvnXi85uw4PMZo27ZyvZJj9bBOwZT+lLRMxM2w9f k/+PeFeRAw5qC+DPYfEvbfHMP1I94DENLRjSlf/KWfPwDj8K8g/kj4uhyGan0k3S22oh 99G4ks3qtbmTUtdLUqYpl5wLUBOy9/MM5LcpwI4h8FULPVJvfJXlR2bkv0SbXjkf21y8 xq6o4nxXYqbWC5HbrRGgEUasdmSshLBFA9dZZm33eEx2Qe3coZO3oZ5pJdCEIt8vxRuq p2tA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F8p8PwSP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4518a77f091si121011331cf.464.2024.08.06.06.00.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Aug 2024 06:00:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F8p8PwSP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbJiH-0001pI-Di; Tue, 06 Aug 2024 08:54:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbJho-0000nB-Mp for qemu-devel@nongnu.org; Tue, 06 Aug 2024 08:54:29 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbJhn-0000Nw-0p for qemu-devel@nongnu.org; Tue, 06 Aug 2024 08:54:24 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a7a83a968ddso68694666b.0 for ; Tue, 06 Aug 2024 05:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722948861; x=1723553661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0GHmHGgb11iYqcqPSgHHl5+4znvZdtn/oYi94we9BmQ=; b=F8p8PwSPMjqiDf1fjeafK20HfvSm7LyuWBdJZ8gbuaJGz+jcgfKlzRNYtpki3l8gSQ 6Uu/jb90k/quNvwTvT6RVv1xTvbF+4tpKSLgRHW9BoZkqPLLCUtER2Vn+ECT/DNf6aq7 BNNdcsrPBMIfNO5SlitGn6HV1C+PtHM1LqmvsZ0NEFODUfh1RsKIAx6UAu4EW/8UGDc2 mKHN1+30IdZNRjTJGVGWSP//CJcQ3Wwwrp8PL9WU90S27Uhx9MTliMo6+RYRjhqnpXCg Jtk4fAcFYXrb4jcNtNQszsChBlA4nkXTYDOy72YZ9denSKz3kqFX35e+R/HAuOMgRl7N lVcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722948861; x=1723553661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GHmHGgb11iYqcqPSgHHl5+4znvZdtn/oYi94we9BmQ=; b=pq6ZFaKsa7r1S3rQWfCSFiPa5lynIMK1t6NRGxFD648SIxG7tX9cM4RqcZNM0fq0az 0hk3hDb8dUn8aFSmDhRFTMzVUKlTsK1pgywqTukL3msZtO4sbd62H8HocxlGjTMP+HwG oFB4HwpKlyCtFLnCbVdi65XbvPEP6H7pXFq27x5/SBxQTuTdynggwuL3kOw7YwHs0IV9 21F8XdNpgW4b6BG8Sl0FGpG8MBAHLyZdJTrACEJoocrNnwQrJHNPuNAc0wYKRMCovdQ8 9zb0xXui9msscmWrod+as5LQP9L90oZelyqWVFV0bgH+ebMXu/N5oAuIVkAdyqsAM2ua nXFw== X-Gm-Message-State: AOJu0Yyf0+dHWLfnN97NBnuBMRJTZqjeLStM3wgf+qbrl+vbbIyoIuBj AXyX3PG0rk0JBp4uUFFJqSEjEXVVPYQfVznP5FzmgpJooAWO5uRsSdMEZLpp7h2kO4jqL8uJzmb M X-Received: by 2002:a17:906:7312:b0:a7d:a680:23b5 with SMTP id a640c23a62f3a-a7dc50007bamr1077254966b.33.1722948861023; Tue, 06 Aug 2024 05:54:21 -0700 (PDT) Received: from m1x-phil.lan (cor91-h02-176-184-30-206.dsl.sta.abo.bbox.fr. [176.184.30.206]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9bc9d7dsm547291966b.9.2024.08.06.05.54.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Aug 2024 05:54:20 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PULL 23/28] system/vl.c: Expand OpenGL related errors Date: Tue, 6 Aug 2024 14:51:51 +0200 Message-ID: <20240806125157.91185-24-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240806125157.91185-1-philmd@linaro.org> References: <20240806125157.91185-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=philmd@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell Expand the OpenGL related error messages we produce for various "OpenGL not present/not supported" cases, to hopefully guide the user towards how to fix things. Now if the user tries to enable GL on a backend that doesn't support it the error message is a bit more precise: $ qemu-system-aarch64 -M virt -device virtio-gpu-gl -display curses,gl=on qemu-system-aarch64: OpenGL is not supported by display backend 'curses' Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Acked-by: Marc-André Lureau Message-ID: <20240731154136.3494621-3-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- system/vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/system/vl.c b/system/vl.c index 9e8f16f155..213ee6a6a9 100644 --- a/system/vl.c +++ b/system/vl.c @@ -1973,9 +1973,10 @@ static void qemu_create_early_backends(void) if (dpy.has_gl && dpy.gl != DISPLAYGL_MODE_OFF && display_opengl == 0) { #if defined(CONFIG_OPENGL) - error_report("OpenGL is not supported by the display"); + error_report("OpenGL is not supported by display backend '%s'", + DisplayType_str(dpy.type)); #else - error_report("OpenGL support is disabled"); + error_report("OpenGL support was disabled when QEMU was compiled"); #endif exit(1); }