From patchwork Wed Jul 31 15:41:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 815661 Delivered-To: patch@linaro.org Received: by 2002:a5d:4acf:0:b0:367:895a:4699 with SMTP id y15csp802115wrs; Wed, 31 Jul 2024 08:42:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXCB5DGyvOvd5gHOdxl0tWjTn5ci3JP+eSyUoivDbZ2w+VripCcLcYlI/k719OHih+laz31GTF2zrmEjzumdEXY X-Google-Smtp-Source: AGHT+IHPSVYCPpJitMlZDNFM3Jl61nnFstZpXnE1d9L+c2R/sB5II9jG9pz1DZbJSwUC7kyESkV5 X-Received: by 2002:a05:620a:4415:b0:79d:8eb5:d0f4 with SMTP id af79cd13be357-7a1e5302062mr1530114685a.69.1722440560269; Wed, 31 Jul 2024 08:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1722440560; cv=none; d=google.com; s=arc-20160816; b=ntCQN5wUseJAR6R3J0dVcOKtdY0JUtfPFqMkA/hohKznDCRd+/lXkbpGKZldZjVNrR IqDD2V0KTqHY1cUjCGP4t/4lewGgdbRVtLVMyRU8U503yZpyWmcwk7WW11zvLtqb8L7W dnVtEChT097gjM6RQFc8dPB3aikB1iGpeBB6iGiMmoO0VpCflaxbtgRmZXYJAcgqTP0x j7ET1L0o9mBTctRufU2XvmUmUSs3JhpetNV+v1RRz2sdG+Fa42VX1/PUvLoxJBUnawai PHFbHZF5t/G7+NPSLI4ivdmhDvP2g075hXpkdzW/ZO2jO10FyFJL7faZzkzzFibdqAhe X8rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EgQ8hDnd//FyBdrootoUTzW/R8QU7nkSIuMQVQDrypA=; fh=xpqcRkWdG1c6qr9WoCAMJiomiim6Sb2z67WgKdYAse0=; b=tEpWVyABkb3DwyeLSzv99+7AjcTimM0eTWr9JuaGSelczWGf5rXRBxszmNfe0e2p97 Mpd0ImkLZEBGrQvYinO8NVERzs19lt/CBM3WUeK1OcyUPpbareTxsqs7i7Kr4YeLM0ro GWdDHD1aV7ATyYQsC/sqaYT3kxTBLxmhMcI5/5twiY9beSMW0qr8f9OqPyGkQoVjuqm3 7IIsu45UH2b3CuO+oYTOLsAwgwXWANr14mP1OTPN/T00HpAjMyqqhyLqtG+XiO2JEgGd Pf3o1riv4OWlxoylkeEEhgq3NnkCGSQxQGA7AbfR1ARUYh0SW0yhivgcBcaS23Wi9rEV bm9w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AVvwR50+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a1d7399613si1570507185a.55.2024.07.31.08.42.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jul 2024 08:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AVvwR50+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZBSS-0001vJ-6g; Wed, 31 Jul 2024 11:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZBSQ-0001qY-VP for qemu-devel@nongnu.org; Wed, 31 Jul 2024 11:41:42 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZBSO-000574-6k for qemu-devel@nongnu.org; Wed, 31 Jul 2024 11:41:42 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4281f00e70cso26739415e9.1 for ; Wed, 31 Jul 2024 08:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722440499; x=1723045299; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EgQ8hDnd//FyBdrootoUTzW/R8QU7nkSIuMQVQDrypA=; b=AVvwR50+/kmhwbEeqMpaKH2pd+PSPF5z/VT9OntQt8GrfH5w5AIaFz125RQJQBpkcQ yCaxdwRSvB/UyA81bBElg0vB6UZwIuMVlqoAAWwvjj4UG3TQHfL3J2+u4fUd3WnuEEgT LEM9b3dVGG4fJNGOCHmUFGOLl9oN/LXCwIvfcS2rJ8Eys8TT7qQZIcuTy2XyPQBzXJew APUu3ur8daXrdfUhF7if55iu7AJNJrouMKecGzYaYaNfwj+/olXpDeTvPO1EYIyyA1q7 fzRxKmU4UBLlvqNZknFDxasm7J3m5bHe+Z6amgUQjv5XcNArsxfS/Rgf6+m2BOqqw4tl gWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722440499; x=1723045299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EgQ8hDnd//FyBdrootoUTzW/R8QU7nkSIuMQVQDrypA=; b=m8r5/6lXYDEd7Ini8TqKkl0HYfZgB+GmWT0QFt0CE6locclc2NNZEJHavODWXCi+G5 Vx9RtDqhtwWJHJdIPniBSfxYTgZoW8XitdC6ipRvvepJ5Vqg0zjXxf9JeHDtKYsoM0Sa czexkjmvXLJos+y/XdivIihLt2mWvb5uK5sNoWubY91W0kTFGSRdlB3he3QKbg2lYU0i D1FlcwexYXr6Vwm+X+y7er92Xl1kcr76BBUTpq0mvX/zHKIIuAe8mzt34nx3IwI8XlkL 6S4mIl0f8PNKMLcKHiMFtMGbcF5117cwZPOz9fdpwp48xVdElMtZe8zssUPuaJ/iNQZy UNJQ== X-Gm-Message-State: AOJu0YxzO+o5T7sKCdJ3KJ35YSA4Ufrp2bRWFTMnXSGBX/w+P5V084LF JOjs2voFxUaUn3iY4knnB4JuM/5gOD+yociTiVtLl7bP4mkdy+xrGIjMMZzvRNdaBEjhQ6jrlO2 L X-Received: by 2002:a05:600c:1d03:b0:426:5cdf:2674 with SMTP id 5b1f17b1804b1-42811d735c9mr94933405e9.4.1722440498715; Wed, 31 Jul 2024 08:41:38 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bba283fsm25201295e9.46.2024.07.31.08.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 08:41:38 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PATCH 2/3] system/vl.c: Expand OpenGL related errors Date: Wed, 31 Jul 2024 16:41:35 +0100 Message-Id: <20240731154136.3494621-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240731154136.3494621-1-peter.maydell@linaro.org> References: <20240731154136.3494621-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Expand the OpenGL related error messages we produce for various "OpenGL not present/not supported" cases, to hopefully guide the user towards how to fix things. Now if the user tries to enable GL on a backend that doesn't support it the error message is a bit more precise: $ qemu-system-aarch64 -M virt -device virtio-gpu-gl -display curses,gl=on qemu-system-aarch64: OpenGL is not supported by display backend 'curses' Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Antonio Caggiano --- system/vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/system/vl.c b/system/vl.c index 9e8f16f1551..213ee6a6a92 100644 --- a/system/vl.c +++ b/system/vl.c @@ -1973,9 +1973,10 @@ static void qemu_create_early_backends(void) if (dpy.has_gl && dpy.gl != DISPLAYGL_MODE_OFF && display_opengl == 0) { #if defined(CONFIG_OPENGL) - error_report("OpenGL is not supported by the display"); + error_report("OpenGL is not supported by display backend '%s'", + DisplayType_str(dpy.type)); #else - error_report("OpenGL support is disabled"); + error_report("OpenGL support was disabled when QEMU was compiled"); #endif exit(1); }