From patchwork Tue Jul 30 16:22:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 815328 Delivered-To: patch@linaro.org Received: by 2002:a5d:4acf:0:b0:367:895a:4699 with SMTP id y15csp375431wrs; Tue, 30 Jul 2024 09:25:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWbrrrJpEooonRVPpqeMtTeJWRpxqemcJBVjCP/kSNB5ly9NELUKdbzKBSL3Hc6E1soZiv5DJ+1j1UT3qb5tGSG X-Google-Smtp-Source: AGHT+IGox/rULyZKwpS8zPNzo06ZrBKSoI0yth0L8S/pkEQoiatVufxbceEdUiPdwwyBITAE2Tmg X-Received: by 2002:a05:622a:2987:b0:442:1bdc:2a6 with SMTP id d75a77b69052e-450375d488bmr34684541cf.30.1722356719773; Tue, 30 Jul 2024 09:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1722356719; cv=none; d=google.com; s=arc-20160816; b=lSn4wlr8+k1W9a69IRk4eYEjxJEyBCaRF97tDyrIcHUlo5nL72+dSXmHpEUKjjyZpo 0BKtrm+h70syo4QmYFdILhi21c2ebbkcW8FtjN7SZcK1LoLxqbpsSXkt3CB+l6Nh4+WJ gBUv9RbNQVoEaJO0rVaAZ8lL3CZTokvtsYx7gl1S6b1LDGUmMhQWKJ1GoO9f0HbJV//j /hwq9ht84Y41i5n+igwfGGwJzKKZXaOwXkqLkBBvI9MbnC8ROnc3aSKRvjWT3+ltUFwf 3DUg9JfjkeyVP/AJW36fXZHENjiwJvsL38KJuf8Y5eOD2yxknrJQkGF29QVVAOTvo8dN 91iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LRXaIONybMmBdGeWuB9Y8awgTfEnHzKiFMl1WGBWlGA=; fh=FAL2D6uTyIa7tGzjyRrQN+DzefW95j5rgBe4AZL1gi8=; b=uUI/Yq0jolpdnpC+Vt/H2f5v0uZht4DRVHtaiOtEuQtJjGPiwY7XKnS2WckYxNdPZQ ajTD8uYmo1pFj2Dio6Nhw7dTPyvrxqG7q0oqhUN62ub965P88iEK2GlgTr840eSAlff3 2Q11Q65vVwPelGLfhV09r8gOSB8vnuFAbRlJJDIduDw6AEL80W8LPZ0IZUQsW9qk2Q7o gzYwh3JotPNuara0Zn8FaMwTqQsYP938sSV/4Ivq4gqTr5jzACqdaQfWCg9tvRIkUvPD k8+aTbkiXcPKcBNsGvGmq20A835sPMWixI9PVDC3zNXfMVFT+JG0RPmjuUIFSH5mqT15 1kaw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xuW2kCW/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-44fe8425826si125907831cf.627.2024.07.30.09.25.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jul 2024 09:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="xuW2kCW/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYpch-000092-IZ; Tue, 30 Jul 2024 12:22:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYpcf-0008TF-R2 for qemu-devel@nongnu.org; Tue, 30 Jul 2024 12:22:49 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYpce-0003Yl-3C for qemu-devel@nongnu.org; Tue, 30 Jul 2024 12:22:49 -0400 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2f029e9c9cfso76608631fa.2 for ; Tue, 30 Jul 2024 09:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722356566; x=1722961366; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LRXaIONybMmBdGeWuB9Y8awgTfEnHzKiFMl1WGBWlGA=; b=xuW2kCW/jI52nHiLJvt+6z06PHOyeuxOVM5cNIj33G3LdfEpb5kxBsawTQhyEmIYWB 50qVa742At3ElK9oNk2Ms8Kip3XE3BovgY2gSwrgr4GGKRwxgu3ap8/8Vf+QBS0nfgr3 43SIcxuKOnYDWa8KI3dCWC1VKLGCwgw8fUcQpcmLgqOd3iGqq4//W+k+RbMj0rw4GobB fYEB9KmgvKRL9uGzA1mxHLS08gxPE+uHA/dbaxeqG6OWUA7ydXZjNVvWxYwF7f7rvU1W W9PdtNWXVIhrMfho6j6Rq1kUR6YwnHDJRppMGjgPZcdFsYCjv9ETrbrKKEu2fb+Ty1mJ 2+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722356566; x=1722961366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRXaIONybMmBdGeWuB9Y8awgTfEnHzKiFMl1WGBWlGA=; b=dUAa6olayr9YZxVW+4wgx/HyjNtyP2rcFts0m5BY2dCDEfDScSaplAmXd0ooIKjjsC ZCxaK42NCcFVWB2ktX+KLWi3lQTZ/lOo2YHr5Jt2tUpWr7QBr3RZ6fM2WJL03Sd3BASG OOH+riFQtRfkcAKpgTAAI0u9CUM/yA1O2+A53fVSAYtNOi5pmoHtWXHw1j8QV6dPqojm /1DUxxLikJfad2Ck9gGA6+r1uv97fHiW1l+LKBmebQMEt/rUcxxpw8+by6JO1nv+E+ZY EzsojLd81iK5sgEzjkJZGOR4jcrhTHXN0MQfl2pjfT2um6LRWv5cw/Yw2MRQJ4C9BD/4 kU0Q== X-Gm-Message-State: AOJu0YzENlDSwHHVk0M5zDuajAmBawxgpdsBNDZWrzS6pIg/fJ+9+AmO MZCgLgNquz6tZLxvnyKV9bmtE/CXUxDMFNOHsYwkjjfKgzPeM3yGqht2cS7apes= X-Received: by 2002:a2e:9a87:0:b0:2ef:2f9e:dd19 with SMTP id 38308e7fff4ca-2f12edfeefbmr95149631fa.2.1722356565999; Tue, 30 Jul 2024 09:22:45 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad41027sm660084466b.122.2024.07.30.09.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jul 2024 09:22:45 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 043CA5FA0E; Tue, 30 Jul 2024 17:22:39 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Alexandre Iooss , Mahmoud Mandour , Pierrick Bouvier Subject: [PULL 12/14] contrib/plugins: be more vocal building Date: Tue, 30 Jul 2024 17:22:35 +0100 Message-Id: <20240730162237.1425515-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240730162237.1425515-1-alex.bennee@linaro.org> References: <20240730162237.1425515-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::236; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org With the conversion to meson and removing the old QEMU Makefile baggage we became very silent when building the plugins. Bring in a copy of the quiet-command logic (and some magic COMMAs) so we can at least assure developers we are building them. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2457 Signed-off-by: Alex Bennée Message-Id: <20240729144414.830369-13-alex.bennee@linaro.org> diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index 98a89d5c40..edf256cd9d 100644 --- a/contrib/plugins/Makefile +++ b/contrib/plugins/Makefile @@ -39,26 +39,41 @@ endif SONAMES := $(addsuffix $(SO_SUFFIX),$(addprefix lib,$(NAMES))) -# The main QEMU uses Glib extensively so it's perfectly fine to use it +# The main QEMU uses Glib extensively so it is perfectly fine to use it # in plugins (which many example do). PLUGIN_CFLAGS := $(shell $(PKG_CONFIG) --cflags glib-2.0) PLUGIN_CFLAGS += -fPIC -Wall PLUGIN_CFLAGS += -I$(TOP_SRC_PATH)/include/qemu +# Helper that honours V=1 so we get some output when compiling +quiet-@ = $(if $(V),,@$(if $1,printf " %-7s %s\n" "$(strip $1)" "$(strip $2)" && )) +quiet-command = $(call quiet-@,$2,$3)$1 + +# for including , in command strings +COMMA := , + all: $(SONAMES) %.o: %.c - $(CC) $(CFLAGS) $(PLUGIN_CFLAGS) -c -o $@ $< + $(call quiet-command, \ + $(CC) $(CFLAGS) $(PLUGIN_CFLAGS) -c -o $@ $<, \ + BUILD, plugin $@) ifeq ($(CONFIG_WIN32),y) lib%$(SO_SUFFIX): %.o win32_linker.o ../../plugins/libqemu_plugin_api.a - $(CC) -shared -o $@ $^ $(LDLIBS) + $(call quiet-command, \ + $(CC) -shared -o $@ $^ $(LDLIBS), \ + LINK, plugin $@) else ifeq ($(CONFIG_DARWIN),y) lib%$(SO_SUFFIX): %.o - $(CC) -bundle -Wl,-undefined,dynamic_lookup -o $@ $^ $(LDLIBS) + $(call quiet-command, \ + $(CC) -bundle -Wl$(COMMA)-undefined$(COMMA)dynamic_lookup -o $@ $^ $(LDLIBS), \ + LINK, plugin $@) else lib%$(SO_SUFFIX): %.o - $(CC) -shared -o $@ $^ $(LDLIBS) + $(call quiet-command, \ + $(CC) -shared -o $@ $^ $(LDLIBS), \ + LINK, plugin $@) endif