From patchwork Tue Jul 23 11:14:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 813944 Delivered-To: patch@linaro.org Received: by 2002:adf:f288:0:b0:367:895a:4699 with SMTP id k8csp2263476wro; Tue, 23 Jul 2024 04:15:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVVb97LBQ0D3pNbYDfl0TDRvRuBZoSeuYFmt5EriM2rMstIcSd0mDrkUPcaLw5WNAhSrsPfGvZg9z5HbfHS+Dlo X-Google-Smtp-Source: AGHT+IF/vPsHBx7YRvWwzUUmF8dFGfGhCx302hkm9s880gru3ZDoTYD1qnbH1OwNqhvcWKBBzn2W X-Received: by 2002:a05:6870:718b:b0:25e:170b:4470 with SMTP id 586e51a60fabf-263ab62b612mr8589893fac.50.1721733327386; Tue, 23 Jul 2024 04:15:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721733327; cv=none; d=google.com; s=arc-20160816; b=NbGxDwkaZ+MNtRrdpLGWDeL05CbZHq0OK9vtaBJiLpMZmcygS9So06HhMC35EwtKe3 Egje8wphhssMvpeiEaEbCxo8FcMDlIKM5D/TCoEjiMOhMtATEEdUanMjLycfiN3+cJU4 H+VNqABCisNnqEHhcSljgceBq8jQuJTtFRiwbactyg1OODRBak+dvbj4t9sZK8NcDSa8 HLiYkOc7uDTgsSkCwTN3z3CNIjdd2qDyRbrsMMBq63ZtOlVL7vDXm7vKR9JiNdmZIAIw iIwhpnaiO84XVH+kc5ekoAUCZDbLoyeK5uHgtG248p0Pdh3lFa5iYQZZZBX01In9mQAd 9eQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=R+6A8WFWFSiEF37fcqIfeInJAB6wU5Iop/0MxtMGn6w=; fh=mN3jRtc0I95shLAqShMU95KWKIjA7cZbN3R6Zxd2630=; b=RoBnJD7DJ9PyJ6dAEGv/neyjQmEQVfe9PNlNu2iun6IFGTZaqxXyzFcmo3CmEyAcEY 7m3HyCvl/lOTlDWHckRsfp1ZHkyCM9k0xc33VgkFPO0RNxcCvOIzR+CgJGra0A/MRl64 wUJ01ttsZ08f/sCAm1265qF9YlAubv8iUkdwdsHNphw8o5UnilFZgzupdlFIcHVXnApq SODU/VUoSa5xoprFb0u+3R7ahuChUAZM+wjNygG1o+tpuTY/epaim105fONQZiNEsO2L P0geIHEEyV4lEttCzGOTs/klYLSrggD4P4Ul5KOmpn3X+JgdgS4JlSbvL6HRQqxzLTXY qhRw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D1XZb3Z9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a198fb2169si992429585a.190.2024.07.23.04.15.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jul 2024 04:15:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=D1XZb3Z9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWDTH-0007bI-Gg; Tue, 23 Jul 2024 07:14:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWDTF-0007Up-R2 for qemu-devel@nongnu.org; Tue, 23 Jul 2024 07:14:17 -0400 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWDTE-0006Nh-2u for qemu-devel@nongnu.org; Tue, 23 Jul 2024 07:14:17 -0400 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2eeb1ba0481so79661921fa.2 for ; Tue, 23 Jul 2024 04:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721733254; x=1722338054; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R+6A8WFWFSiEF37fcqIfeInJAB6wU5Iop/0MxtMGn6w=; b=D1XZb3Z91huaE0scAKrZFRobOC7Ir41QKPLXd5JE6YS/WHA587Yvbxeii1xQGfwcgX 0fi/UJesiW5uLvPU8FfMvDWKI3xFkLY9HZo01qBNaA4/OuJWL3p0KhA7LIoxVJMYKGPk h0/qOWcqBH/8+5FOmQFc8h+5dTQ4f3JHj74mT4FeKwYBvoCh9n9gninA64cTzuHYeb49 8COqOt3XNe+TmtjorxxiWehqmEjCa8EUXhaOejg9lxmED9VJhVmnTkyJlnbdx/Vnics+ 5dU7KX1SyncOaA581zMyIvlKkt5s6OQ6nGEYbIp8UGVJEmzud0yN1dOA0ElcaFw8l5Ip /6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721733254; x=1722338054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R+6A8WFWFSiEF37fcqIfeInJAB6wU5Iop/0MxtMGn6w=; b=duMj1vY7MggZVaB2KVT83BqrLdiMw6TBEAhaj7eXjd/k6yGnw/efKBqa0EZ6uHn/9O xi/JrJG4uFsME5c7qU6kYDpbFdYJl0u6M9facM07LBPv1fBFipAq6YNicUY0RzeqDrAJ Ly8zkelH6wJWSjSxbtXGPCmg9q853If6GjJ3y+AZeD8DEFlBCJjuZqFMLAB+qr3+LBiO fvX6tj4gKm1JFqC0/3GL9q1MIOAKOiMqKjNsUi5Co7jBeZ3YrgUHgwXs6qvQfLmxMNj6 VSrVSs0yr0dZfaouDfeiIGsYIk8Np/hrAl61pUbkP6rSQHj+CVoqqIMbyVqOkI5ECzFe 6qVg== X-Gm-Message-State: AOJu0YzCTfUAqPM7C8NFffjyyVwZj3j2N/fXNVtlW/8zVO01GId/9+Nr hTTQV17Xmdov8U2Jep1eKrlN2p8Cn8njFMMbJtrgcUCazJiRtxvjaE/+cddFAT9fR1N33kOJnaQ xPBQ= X-Received: by 2002:a2e:91d3:0:b0:2ef:2c86:4d47 with SMTP id 38308e7fff4ca-2ef2c864e49mr43201111fa.15.1721733253778; Tue, 23 Jul 2024 04:14:13 -0700 (PDT) Received: from localhost.localdomain (5.red-95-127-46.staticip.rima-tde.net. [95.127.46.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d69073d5sm169054185e9.25.2024.07.23.04.14.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jul 2024 04:14:13 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Song Gao , Jiaxun Yang , Bibo Mao , qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 1/2] hw/intc/loongson_ipi: Access memory in little endian Date: Tue, 23 Jul 2024 13:14:04 +0200 Message-ID: <20240723111405.14208-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240723111405.14208-1-philmd@linaro.org> References: <20240723111405.14208-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::22e; envelope-from=philmd@linaro.org; helo=mail-lj1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Bibo Mao Loongson IPI is only available in little-endian, so use that to access the guest memory (in case we run on a big-endian host). Cc: qemu-stable@nongnu.org Signed-off-by: Bibo Mao Fixes: f6783e3438 ("hw/loongarch: Add LoongArch ipi interrupt support") [PMD: Extracted from bigger commit, added commit description] Co-Developed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bibo Mao Tested-by: Bibo Mao Acked-by: Song Gao Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Tested-by: Jiaxun Yang --- hw/intc/loongson_ipi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/loongson_ipi.c b/hw/intc/loongson_ipi.c index e6a7142480c..e7979dbdd8b 100644 --- a/hw/intc/loongson_ipi.c +++ b/hw/intc/loongson_ipi.c @@ -14,6 +14,7 @@ #include "qapi/error.h" #include "qemu/log.h" #include "exec/address-spaces.h" +#include "exec/memory.h" #include "migration/vmstate.h" #ifdef TARGET_LOONGARCH64 #include "target/loongarch/cpu.h" @@ -102,7 +103,7 @@ static MemTxResult send_ipi_data(CPUState *cpu, uint64_t val, hwaddr addr, * if the mask is 0, we need not to do anything. */ if ((val >> 27) & 0xf) { - data = address_space_ldl(iocsr_as, addr, attrs, NULL); + data = address_space_ldl_le(iocsr_as, addr, attrs, NULL); for (i = 0; i < 4; i++) { /* get mask for byte writing */ if (val & (0x1 << (27 + i))) { @@ -113,7 +114,7 @@ static MemTxResult send_ipi_data(CPUState *cpu, uint64_t val, hwaddr addr, data &= mask; data |= (val >> 32) & ~mask; - address_space_stl(iocsr_as, addr, data, attrs, NULL); + address_space_stl_le(iocsr_as, addr, data, attrs, NULL); return MEMTX_OK; }