From patchwork Wed Jul 17 06:01:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 812977 Delivered-To: patch@linaro.org Received: by 2002:a5d:42c4:0:b0:367:895a:4699 with SMTP id t4csp640950wrr; Tue, 16 Jul 2024 23:03:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV8ZOJ8pcP8sjDLqGUYcyHaMJqZnS0vtCZmKnhYSSXNpMMi4PnnP+lU8lKc7YdlvPmJfvzUpG7usEs8V3ZHj5Lw X-Google-Smtp-Source: AGHT+IF3Mo0DXfFSzTWNdyRQdC+P19dwBXkuD9xFmm8rUz3kywRlgMIuTDxf47ZBbGAW532HRryg X-Received: by 2002:a05:6214:5016:b0:6b5:e190:435 with SMTP id 6a1803df08f44-6b78e2fe904mr11138806d6.50.1721196209326; Tue, 16 Jul 2024 23:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721196209; cv=none; d=google.com; s=arc-20160816; b=TvyOCZyMuGtXeVV5KHNDXlFtI/kACankypcb4vJlPC2lh57FOmsFxljiiYv+sU5aoh pBS/RcWS0bVBKKqXMAQkg0oplP8ZXflo6OJiVDKLRuG3WAQHsLvGiG2Z3lQhcx1w/kY9 nedLodOqK9ZsvtptyEbtFLl1jsXbqxkNUIUuP4T7QIJnlLthxcz1hxQ1JTU75kSKwAPB BoVNkzcEQqG45RQUYHIN2ziacLSKvyBHHAEp2HzklnWIg2PqXV166hF1MRl3xVsJ/mRd iws53RdmiXBct8oCqr8ZZueX0I0WazdK3mVzTq/Cn2Mba0L73OCltxQG0lM2kkGXhIJH d0lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZMf5aA84rLqw++9CAhqa8G+mFDeuLcUiCA683ccZn6Q=; fh=dFXwJpUtYIuNDeXNg18LLjO38IWf4MjVXDf6uIjrXsc=; b=RuQZSM3xhmcc1fr2PpY3X4KZV8ohYYkUODR5OqegyEw25QfQ51jlFUu4nZ1DhtyF0M CYYwhSiMmdAsR58UHJM8itHqLMF19k/Zmumojld5+jbwrnP/5Ejsq3tT7TenMZ09DcNP 2hr8G+Au4NJMeScmmK0gSI68YanZ7waLm0gTqO2Z606UzgPC/6FuINa6QpfXvmKgTgd7 xAHqkOSYkrkNUArss7u5Utjq477sZ3+a8UA5KrsA2ZEI1hgSXjVL4CqoV2NXrLoAZ5G5 AMPOlnLSOemB5wptdwLa8zbSn27eodPqiikavZrRYEoJd7rHAK+pt9ZZaxj5A/3vFqhX eO8w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UPaobX3T; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-44f5b80565fsi90035121cf.490.2024.07.16.23.03.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jul 2024 23:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UPaobX3T; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTxk1-00051Y-2X; Wed, 17 Jul 2024 02:02:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTxjy-0004v4-2O for qemu-devel@nongnu.org; Wed, 17 Jul 2024 02:02:14 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTxjs-0001F8-K3 for qemu-devel@nongnu.org; Wed, 17 Jul 2024 02:02:12 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-70b1207bc22so5362680b3a.3 for ; Tue, 16 Jul 2024 23:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721196122; x=1721800922; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZMf5aA84rLqw++9CAhqa8G+mFDeuLcUiCA683ccZn6Q=; b=UPaobX3T9cqZsaLk/G/eK00FiUS5aipmG6R5aXP8yydURnLfvIRUJhZEnHrdyCVYWg UJh43Tw8dopZwVY9n2b2yZHbGRc1A2QL2PQQ/arCEfQ8SRLrYEm1vvL8yHn0BCKXTAAy 6vt4luwKvChQxYxqcLzuqPhWS/gxS22qvQHR7GoMMriS8cRCOZ1fwJx0iUYUzW4DAn75 d0lRzdfX9cRANoYLM2M9CMMf2SoVLRJhbkaQQhZ9AkllEbrS1iGr5sf7D6YmTq8FjVY7 vS06zml+uRenNDeu6pRatGMnqqxO6vfjhpxhEKOhMzZK2o8NwyEP9J8nGylW8hvD+Rxp +MrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721196122; x=1721800922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZMf5aA84rLqw++9CAhqa8G+mFDeuLcUiCA683ccZn6Q=; b=cTmrkVc8mDvI7iGYHwABUf9vrLkGno0gAFQJOp647yAzBaJTGRbAOPa1TL41FjWsbn UDqkCsGeaLQYP+DZCw2k/hI0eWjuTebf9pbaSPpEG2zxveM3mFMha4clwbqsnBR50KSl ajccwJtUafRb+AAL1gzQrcg97VV6qN1S1DncFKI5CmP6lML8msBk3iG4W/IowNUaTIfR KaXAp5wiCKbj6Y1QFb9HsLB//cvuWAV2fWPfR5WpQwWmz/P+kMYzblKEkElGkF+HK7OE X5495d1WXI3ormDz8Q9Y0mpBLLLxvImGbPL1O2TefYs/PAe7rIhuqujeka12QZUMjeow 91dA== X-Gm-Message-State: AOJu0YydcoN6LAreliBsAMbnlboF5ANcZh7+Ueaa1f0O9Dd5FXG9Duw8 1hJUE1oelCWi+EKOMWEdVZwGCY3tiWko2X7uUZ38ZoZU3kJYfwCYNM7wpo9x0d0xnmsobF8Se+l oNxg= X-Received: by 2002:a05:6a20:7348:b0:1c0:f759:9544 with SMTP id adf61e73a8af0-1c3fdcd50demr1239258637.11.1721196122385; Tue, 16 Jul 2024 23:02:02 -0700 (PDT) Received: from stoup.. ([203.56.128.103]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc27383sm68131575ad.140.2024.07.16.23.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 23:02:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Daniyal Khan , qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= Subject: [PATCH v2 1/3] target/arm: Use float_status copy in sme_fmopa_s Date: Wed, 17 Jul 2024 16:01:47 +1000 Message-ID: <20240717060149.204788-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240717060149.204788-1-richard.henderson@linaro.org> References: <20240717060149.204788-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Daniyal Khan We made a copy above because the fp exception flags are not propagated back to the FPST register, but then failed to use the copy. Cc: qemu-stable@nongnu.org Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)") Signed-off-by: Daniyal Khan [rth: Split from a larger patch] Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- target/arm/tcg/sme_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index e2e0575039..5a6dd76489 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn, if (pb & 1) { uint32_t *a = vza_row + H1_4(col); uint32_t *m = vzm + H1_4(col); - *a = float32_muladd(n, *m, *a, 0, vst); + *a = float32_muladd(n, *m, *a, 0, &fpst); } col += 4; pb >>= 4;