From patchwork Tue Jul 16 18:41:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 812790 Delivered-To: patch@linaro.org Received: by 2002:a5d:42c4:0:b0:367:895a:4699 with SMTP id t4csp446966wrr; Tue, 16 Jul 2024 11:42:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV4EM1qk/b/9yu+zOEQjLNw7xApaiIbGFIo3h5P7ssBSsLc4nNc7TN4Knora85n7gUy3A+dfF2NlMy/xRpknZgK X-Google-Smtp-Source: AGHT+IHrlkSkjUFXgelTgpEuBFM8a1cbFcE+syGzaZwpImSCUvCn+ec+OeejmizRjdm2S/GjcM57 X-Received: by 2002:a05:6808:2381:b0:3d5:4256:26d4 with SMTP id 5614622812f47-3dac7b6102emr4265726b6e.7.1721155359179; Tue, 16 Jul 2024 11:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721155359; cv=none; d=google.com; s=arc-20160816; b=vZ3aDhO8SJHu7SpEtx3qo2ttPP670jwQ7jZ/HqvvISPbu6X/Sec+Qufoh4nXMPyFHa Ufs3H4h+Amh2ZV2ftcJpyjK/W6wdgNamHpOjK5M0lncelr3oF6lBCXnA3oC7Klo91Ox/ x03Tk64xRNuWPpAVmZxMxB7zyy8kSYNvHMQlZ60tlYwQrMN42Wn4b/yXPfUpVudMr5Zf gzDsW6Ft0Rp3Jk09/PI4G3YZr2lBg1edsgl25pxjW0n0MWq60eg1IiFsMlc7qMBTcb1y 7YuHD3u4GJr3WFABJ3oLEcufoZjuTz8ljYjjszic0RHTw0ZY/TkviUt5Tq94qnKP+y2h +jjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JznOvy06gTAUHJS2akh7+jNgw+O2s3K30hb0qRzqsUU=; fh=8ly4dktE5qX7scQRc1qmWVsO0MVOdxfDtQTaDzdLLVc=; b=KXLHAavOVvYiDnrkre+V9qf6S5JDuPtiQdMY1j4r9k4xTctGGKT5LKEaTEF/hnSQzA EfW/IjzjgvbkozQ2ks2kOk4arRJDJWfCfkpTfofnVFQA/SvoOGuINVIhAEGmlIH9BbJx EmpCjaf2PbsBs3v3RQA5+2cYPAId59gRP/xPvhLi/Klnj3V8H29mpdPPvpZzcJW5Rlt3 Gp+PPd7IZmP0FBfFO0nr16lSbWG0F+iS2gWU95aN16xUm6ECooiKW8196WEC6KDqnnTg RKdiP7a7C+ZfNJZkquxHwlIDMYg3tMk/gI95cEi0vtczQ8YZ7fvx35/lWbZuDve/2/qO KFPw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jMm0WnBq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a160c51582si793726185a.360.2024.07.16.11.42.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jul 2024 11:42:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jMm0WnBq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTn7s-0000e7-Jz; Tue, 16 Jul 2024 14:42:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTn7q-0000XJ-R3 for qemu-devel@nongnu.org; Tue, 16 Jul 2024 14:42:10 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTn7n-0007LY-PW for qemu-devel@nongnu.org; Tue, 16 Jul 2024 14:42:10 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-367940c57ddso3579748f8f.3 for ; Tue, 16 Jul 2024 11:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721155326; x=1721760126; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JznOvy06gTAUHJS2akh7+jNgw+O2s3K30hb0qRzqsUU=; b=jMm0WnBqz15Bof6QhsShZouoGjeWGO/R8vfIEpezeETdGW0omrqtxqYwn41pIlvRS3 zxY7mXvZuq4OV4UxJqbnbYnutk3RH9jP59W1xdLEAQc2s73rQNp5qmOueICJ7JSva04/ Oi8RkX7zjermyw6zjtyg5qGN93W/l1mmOB6LJkpI6mecVoIIIQUY3vCIjy5E+NhAtbbN XCz7zp/6ft9AdUDQrvHTF5RIZsmK2kX8QkVppsvwIb/RuPvfxkXtIx0cZ1vfjSk2nGbs XrMl4D7O291S32cVl0+SnBC2gUtQd3E4j4COp2nqo4SJi8Z04b+JIyYpumnsUFRM1mx6 lYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721155326; x=1721760126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JznOvy06gTAUHJS2akh7+jNgw+O2s3K30hb0qRzqsUU=; b=BB7Zz8W8J9yOlurTxP048ZKV3DuZNnoh9NqYKORP7Xvq7wDM3MoFd6Z6JKtGE5LN5M lhPriftiZ86lRCfYqst3csVHKObpqodIdL35gufRUNKm5yMZLEb0h3G60xJrxMtAwyZj Itaefb2c9iwhEZh2NgHHyCl0S/c9sPWRMWa7swl27Ii4IkpK8ZO9yjznRizly9/44AiO U/vvzTDd/KvRxNs/jkadsJBRWNdUgatCTesq2ubrXyaGINtgGZc3xsKnqmNdw8DFCibU nTi8VIs00zoXGZvtAY8bcx/Q6MD8GPrPNjjOymn96ByL1VQqRYZzRJlwhVxJqMndYSPO sGRQ== X-Gm-Message-State: AOJu0Yzo8BrKQgODQM9zQ/RyHjIWPeOzop+bgoJVNahP2jbr+iczLRYF siAY1pLCG+DbJ/wSXHyivk8zx6L9HO3NrA1EDtg9jM1+fzjY3h0yOA0IBj8VS6LSneksCHFLZxE mIfF6hw== X-Received: by 2002:adf:db42:0:b0:361:d3ec:1031 with SMTP id ffacd0b85a97d-3682613c607mr1927356f8f.31.1721155326039; Tue, 16 Jul 2024 11:42:06 -0700 (PDT) Received: from localhost.localdomain ([176.187.209.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680daccbafsm9650673f8f.51.2024.07.16.11.42.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 16 Jul 2024 11:42:05 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?C?= =?utf-8?q?=C3=A9dric_Le_Goater?= , Andrew Jeffery Subject: [PULL 03/11] hw/sd/sdcard: Register unimplemented command handlers Date: Tue, 16 Jul 2024 20:41:36 +0200 Message-ID: <20240716184144.42463-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240716184144.42463-1-philmd@linaro.org> References: <20240716184144.42463-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Per the spec v4.3 these commands are mandatory, but we don't implement them. Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Tested-by: Andrew Jeffery Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Message-Id: <20240712162719.88165-4-philmd@linaro.org> --- hw/sd/sd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0093bbab3e..8a23e9eb23 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2445,24 +2445,33 @@ static const SDProto sd_proto_emmc = { [0] = {0, sd_bc, "GO_IDLE_STATE", sd_cmd_GO_IDLE_STATE}, [1] = {0, sd_bcr, "SEND_OP_COND", sd_cmd_SEND_OP_COND}, [2] = {0, sd_bcr, "ALL_SEND_CID", sd_cmd_ALL_SEND_CID}, + [4] = {0, sd_bc, "SEND_DSR", sd_cmd_unimplemented}, [7] = {0, sd_ac, "(DE)SELECT_CARD", sd_cmd_DE_SELECT_CARD}, [9] = {0, sd_ac, "SEND_CSD", sd_cmd_SEND_CSD}, [10] = {0, sd_ac, "SEND_CID", sd_cmd_SEND_CID}, + [11] = {1, sd_adtc, "READ_DAT_UNTIL_STOP", sd_cmd_unimplemented}, [12] = {0, sd_ac, "STOP_TRANSMISSION", sd_cmd_STOP_TRANSMISSION}, [13] = {0, sd_ac, "SEND_STATUS", sd_cmd_SEND_STATUS}, + [14] = {0, sd_adtc, "BUSTEST_R", sd_cmd_unimplemented}, [15] = {0, sd_ac, "GO_INACTIVE_STATE", sd_cmd_GO_INACTIVE_STATE}, [16] = {2, sd_ac, "SET_BLOCKLEN", sd_cmd_SET_BLOCKLEN}, [17] = {2, sd_adtc, "READ_SINGLE_BLOCK", sd_cmd_READ_SINGLE_BLOCK}, + [19] = {0, sd_adtc, "BUSTEST_W", sd_cmd_unimplemented}, + [20] = {3, sd_adtc, "WRITE_DAT_UNTIL_STOP", sd_cmd_unimplemented}, [23] = {2, sd_ac, "SET_BLOCK_COUNT", sd_cmd_SET_BLOCK_COUNT}, [24] = {4, sd_adtc, "WRITE_SINGLE_BLOCK", sd_cmd_WRITE_SINGLE_BLOCK}, [27] = {4, sd_adtc, "PROGRAM_CSD", sd_cmd_PROGRAM_CSD}, [28] = {6, sd_ac, "SET_WRITE_PROT", sd_cmd_SET_WRITE_PROT}, [29] = {6, sd_ac, "CLR_WRITE_PROT", sd_cmd_CLR_WRITE_PROT}, [30] = {6, sd_adtc, "SEND_WRITE_PROT", sd_cmd_SEND_WRITE_PROT}, + [31] = {6, sd_adtc, "SEND_WRITE_PROT_TYPE", sd_cmd_unimplemented}, [35] = {5, sd_ac, "ERASE_WR_BLK_START", sd_cmd_ERASE_WR_BLK_START}, [36] = {5, sd_ac, "ERASE_WR_BLK_END", sd_cmd_ERASE_WR_BLK_END}, [38] = {5, sd_ac, "ERASE", sd_cmd_ERASE}, + [39] = {9, sd_ac, "FAST_IO", sd_cmd_unimplemented}, + [40] = {9, sd_bcr, "GO_IRQ_STATE", sd_cmd_unimplemented}, [42] = {7, sd_adtc, "LOCK_UNLOCK", sd_cmd_LOCK_UNLOCK}, + [49] = {0, sd_adtc, "SET_TIME", sd_cmd_unimplemented}, [55] = {8, sd_ac, "APP_CMD", sd_cmd_APP_CMD}, [56] = {8, sd_adtc, "GEN_CMD", sd_cmd_GEN_CMD}, },