From patchwork Tue Jul 16 18:09:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 812785 Delivered-To: patch@linaro.org Received: by 2002:a5d:42c4:0:b0:367:895a:4699 with SMTP id t4csp435924wrr; Tue, 16 Jul 2024 11:12:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDSTXJ+n7z3VTqC5nVwU2vBjzolknxkKIoSSjTVxnL0SqLkCEZtkr25cjw2vbSj6rwxdK6mwpIlNUSuV61u3iC X-Google-Smtp-Source: AGHT+IG6KosPVC/mYP9iSMCeGXTs7V0BGxF6HNNouEw/3BfKu+c3QpbheOitTCYZaQRTvk5psjKl X-Received: by 2002:ac8:5904:0:b0:446:3927:5a9 with SMTP id d75a77b69052e-44f7acad29amr36592521cf.10.1721153541263; Tue, 16 Jul 2024 11:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721153541; cv=none; d=google.com; s=arc-20160816; b=OOmZrHsymDKjxArWWiiVK1/OxpGJK/gsXX+1Ni6UMq7mvfFC2FgS8AE1Uw0t9Olono lbxONsNQ/Dw4QzuMEhkBn7vF2KR5fOmCnClXuUax56WueXxusiZWgDTQF/fTkQFLA1U2 QfJd8qshLtNc6/3eQ1iS1kDgUsu+E4Un2jGh7SDNq/c256rN/Z5Ouiri4ynuABsOoAH0 ULjJ+NKj17gDfX4czNcmxlcnUXMWWGD/4+bkexfhHQVoT4vga9Nx7yLXeWN+RaR2Wbic FI/PdJIwm4bO7UL8SThYk/vsPbsSDznKzTnhSl+sPjo/4e0UBcCFjlLmtdPC7MY1LAkD sDoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eXyrM2tLHAmHfdAt3y0LUG4EVP52RhZxQbundRVG0Yk=; fh=wiKz0x7qvKwceerDkCg/vXelUIS3VMX4wuMEccF/XUs=; b=n7y0lFc7wa2Yp/HgwL/iWJwyUg6h9Layo4rSHQaz/JC4Tpbcjlkq2NYfQaYepv5N1N 5T2PspFYnk5M9pSZwbh3VBBiLEIWezolB0bD9e1suJlM+WiyjpDEdLFZBni2I8CVsw0N go8BVZQQ0HuHczCJ/g7Pj5v0xJXzuIqFWUaAET01b3W/0IhvmVsFg21ZzN7fm/QdtXNm XHXR1+LiaBtdt/gGedM0ND5e7rL0uUgjLIbCfEOso890g3v5oHnQqk7Bt0cf57qNuGKH ugDXDKZRO4LXkLT1v2/UKN3FRhm+qKD9c+5d99okCBYNR6sa+QCyIPlq+HsfSR84urNK tifg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgOdY1rd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-44f5b821c7asi81610511cf.653.2024.07.16.11.12.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jul 2024 11:12:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgOdY1rd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTmdV-0001b4-PT; Tue, 16 Jul 2024 14:10:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTmdF-0000fM-AG for qemu-devel@nongnu.org; Tue, 16 Jul 2024 14:10:33 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTmdC-0001HM-BM for qemu-devel@nongnu.org; Tue, 16 Jul 2024 14:10:33 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4279ca8af51so36334045e9.3 for ; Tue, 16 Jul 2024 11:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721153428; x=1721758228; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXyrM2tLHAmHfdAt3y0LUG4EVP52RhZxQbundRVG0Yk=; b=CgOdY1rdX/R+0iYabBrqhZX/UUZ6usnVkGKR3gaIG8754cW0nmV/wAZNDeFv8XRW+Z unDaJ57AN+ApG47d3SogWvKDFkFzA9+apxm+wMZtLPxkp+kUNo13ne9alhxKon5PAyEC /OVyKzNTFRo7FQT5XYw3f4qjz3XeOP00q5WgtZG+LV4/IvV23pRc7e/WuvK07yIbIVLm eP+LRnYxD2fOZ8lpI5y4ONHXf0c4ckdYcYYC/OTS4DE6EfRsyXdIh6Cjcn9UzJUWHjEi ncIqFFDc9VVTSz6APhQAxgwNTpjG5yB8ZvzhDTwQuB6n8n0OINznBkMlnQlVsvVi+4uK FW5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721153428; x=1721758228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXyrM2tLHAmHfdAt3y0LUG4EVP52RhZxQbundRVG0Yk=; b=bqN4qCRW0bH4KG1AvMKis3xVTkhKO784AsELvE5+EabBcOrgp6gXSrs2RnM5T+6+eo EHasbOKMMmeyIdGVlTZuqTJPL7GfWFv045KWJz8S7ZNJ/SQ6+pVn5FlQDsE+zVF+FJff azo6n7HNW0OwQm/E/GToeFa5c0Ejqu9PyOzmnGO1zAeM2VSGX9+VgLHSFhFQ4tyzFDUY gOpph8UPA7saGyYn68MBKT0tO596/Nzl46ptNjagYkekvt4c6ACGHPtOBg+47Tpn5/39 ZvRdYLEYTw0Qhz7tBKJxPQgxvMW6qxGMm1QbDIwzLCUaVPygPLSxa43CpwA17iDFZl/O InTQ== X-Gm-Message-State: AOJu0YzEp6xlt3whbGARUrTl6L+6yqrUESp1kNvp1smyYW/fjxks2JD3 G0q53S/sKToENaNl3IEEKumZ8CdijEG9xw3trz/MdTHq3/cleKWxYvKvI43M0pOkmi/vOUOk1k8 /lRtw9g== X-Received: by 2002:a05:600c:468e:b0:426:67f0:b4fa with SMTP id 5b1f17b1804b1-427ba655261mr22919295e9.1.1721153427828; Tue, 16 Jul 2024 11:10:27 -0700 (PDT) Received: from localhost.localdomain ([176.187.209.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e8387fsm136156095e9.20.2024.07.16.11.10.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 16 Jul 2024 11:10:27 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PULL 08/13] ui/cocoa: Release CGColorSpace Date: Tue, 16 Jul 2024 20:09:35 +0200 Message-ID: <20240716180941.40211-9-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240716180941.40211-1-philmd@linaro.org> References: <20240716180941.40211-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki CGImageCreate | Apple Developer Documentation https://developer.apple.com/documentation/coregraphics/1455149-cgimagecreate > The color space is retained; on return, you may safely release it. Signed-off-by: Akihiko Odaki Tested-by: Phil Dennis-Jordan Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240715-cursor-v3-1-afa5b9492dbf@daynix.com> Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 2935247cdd..79a054b128 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -307,6 +307,7 @@ @interface QemuCocoaView : NSView BOOL isMouseGrabbed; BOOL isAbsoluteEnabled; CFMachPortRef eventsTap; + CGColorSpaceRef colorspace; } - (void) switchSurface:(pixman_image_t *)image; - (void) grabMouse; @@ -359,6 +360,7 @@ - (id)initWithFrame:(NSRect)frameRect [trackingArea release]; screen.width = frameRect.size.width; screen.height = frameRect.size.height; + colorspace = CGColorSpaceCreateWithName(kCGColorSpaceSRGB); #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_VERSION_14_0 [self setClipsToBounds:YES]; #endif @@ -379,6 +381,7 @@ - (void) dealloc CFRelease(eventsTap); } + CGColorSpaceRelease(colorspace); [super dealloc]; } @@ -456,7 +459,7 @@ - (void) drawRect:(NSRect) rect DIV_ROUND_UP(bitsPerPixel, 8) * 2, //bitsPerComponent bitsPerPixel, //bitsPerPixel stride, //bytesPerRow - CGColorSpaceCreateWithName(kCGColorSpaceSRGB), //colorspace + colorspace, //colorspace kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst, //bitmapInfo dataProviderRef, //provider NULL, //decode