From patchwork Mon Jul 15 05:58:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 812599 Delivered-To: patch@linaro.org Received: by 2002:adf:fac3:0:b0:367:895a:4699 with SMTP id a3csp1658986wrs; Sun, 14 Jul 2024 22:59:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWRk8wruIH+T92OeLhjCb6pPXajRZvANfXbFIqbPewR+JfGyFTCONc49CYxTMZ4+2AOJ3s92oTW2oaTdqy9wUV5 X-Google-Smtp-Source: AGHT+IEsE7TkRcUfUHveVcftCU14W6yohga9iksuVdgBATablFh6+hQ86lOy+MVrgqn8zKe6kPXH X-Received: by 2002:a05:620a:2145:b0:79e:fede:692a with SMTP id af79cd13be357-79f19a6fbbfmr2019808285a.25.1721023167697; Sun, 14 Jul 2024 22:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721023167; cv=none; d=google.com; s=arc-20160816; b=U+dUxTj8LlqdbbqhYulzyLMv5TqJJAUhKPoaDm35xi2vzu98NfWDpCcKdh3mFwptVf Ih7N7sV7e166UdBA0eZoFKaxRVQVfWprTOMQB7hMw+mDg3236143qmmSUABlpeIQA6dD 9o4bu/nEubG0E847wQVQZMkEpcUq7AQ5YDZYkjDUqY6DnZME3OdVRRKcokMORfO4X60I JFoz8/68G3aOPtm1hlHUl7jGMUKwl5OuE+lXNdCjn53DkcKxZv5zMfG1UnnWT8u3S0XZ iC5Fl4jZmgT5H4PeCFB+k+UqHgncUco62VtZ8iPLllIDWtahzhlSucHteoE2XU7oUFE9 yI3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=69RYijPlse3JbUzx+du3ou9M98Z9jhFYXn2Bml2d90w=; fh=KK8zc0HD8TLB5rwBMLjEUcsTx4xcA/ykt/spDw31gEY=; b=ZZbEr26O4Zzh4F1LGDhC/sEHb57wpiZKFXXhQLuF0H1cQw4Yz+2J62ayJyvZbBB0Kj x3fPoRhoJ2e0UonWw3h1cTJ7Onnrx8LAAArfuQFZaOVbeLzogillFw1krjAiXFbZTdKL yrQlAaDOnjUyRIsIll9zG+jw87sy5ocLBY3n3PwYxfdAqSadCjuvborv76aOV7pcwqFW iMbmwtp13KrB/kouHyBa2qvkZgkYRYAkEq+LBeZf++RTKE+DalCAdoCk9mJTm5SIgwZ3 byBn028yux9hUKBdGStHQtPS1ko+iASvYcQkY/Jd+vCO0UBOBI9TPjL7QyEkmChYy9Tb QsTQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o123e5h+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a160c496fcsi451317885a.368.2024.07.14.22.59.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jul 2024 22:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o123e5h+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTEjM-0004ke-BR; Mon, 15 Jul 2024 01:58:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTEjK-0004cD-Rk for qemu-devel@nongnu.org; Mon, 15 Jul 2024 01:58:34 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTEjI-0008Sb-L1 for qemu-devel@nongnu.org; Mon, 15 Jul 2024 01:58:34 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2c9baecc80fso2495748a91.1 for ; Sun, 14 Jul 2024 22:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721023111; x=1721627911; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=69RYijPlse3JbUzx+du3ou9M98Z9jhFYXn2Bml2d90w=; b=o123e5h+nYYMG/q0WlAenQ3hD8fGclL/ME00ECx1OAKwvGdNlY4PHEnfM64wab7gnL +509QAQLHiVh629/zl/pw4QMuB89QV0w3RDnojUXtHCqp6Nve+/1//2ykppOILBshpGT Ya3rLi6aPe5j9VwRCFg5EJ3GyGDdQ9UeBKT0fzkxGD2BTCWrzc2bEsX9WoWX5U3G3TGk PuAJI47+8oS91yh+acYBKTYUb4tNn5tmjMnDvWImShBqCfWZ2DRM0hVijSLKNlFwjx0r tYoIb01Z4gf9WWFCp1m9sc0l/aXhDETh3nbaHKTlinX92zANP/t27BnRKECElHD2PfPs c9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721023111; x=1721627911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=69RYijPlse3JbUzx+du3ou9M98Z9jhFYXn2Bml2d90w=; b=VtjZW39fZss2V/5lOIuzyp3U1Dy2HsM7JQIcUIRXia5vlhrwjNFiW6vhXYenpFtxSc jbD/fG/koMUeZNVcHQAnBqjolBal484ImSA7Eqm7ERyYY702xxioDMEcD+JWw3ouHLsq HXAFiMF6oN3iDLRf5U6jm5+WGFa5lT/2/C+a+xSRlSHF2o68cVtr6dutZGmQYNr3W95O xK/ySA5eLuIr++Lxml2GcXyGHry6UkSv19HfZJ3MKjrqKHAiMFpi1H+qCB0oBkSiAj4/ 5PQ90qI39Y8KevHoNqsQOL2VeALK6sEMNotW56mi0kbCUwU88z+rdCiSb4CM8EjczLBX Majw== X-Gm-Message-State: AOJu0YwioTVjisXYrwYprnOYqI9xddxunTWMxbHDq6/ygn4D+XSw8kiQ t9Qc1sx0g49AoZjHuOo/bRZcrlvram1ojCBs8vzEd+oRslMoAnNQh4MwMFraYqchJ2cHNpJbdRl kaG19kg== X-Received: by 2002:a17:90a:db4c:b0:2ca:7e7c:83ec with SMTP id 98e67ed59e1d1-2ca7e7c8890mr9278627a91.20.1721023110671; Sun, 14 Jul 2024 22:58:30 -0700 (PDT) Received: from stoup.. ([203.56.128.103]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd419af7sm5463589a91.25.2024.07.14.22.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 22:58:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: danikhan632@git.sr.ht, qemu-arm@nongnu.org, Daniyal Khan , qemu-stable@nongnu.org Subject: [PATCH 1/3] target/arm: Use float_status copy in sme_fmopa_s Date: Mon, 15 Jul 2024 15:58:18 +1000 Message-ID: <20240715055820.319035-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240715055820.319035-1-richard.henderson@linaro.org> References: <20240715055820.319035-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Daniyal Khan We made a copy above because the fp exception flags are not propagated back to the FPST register, but then failed to use the copy. Cc: qemu-stable@nongnu.org Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)") Signed-off-by: Daniyal Khan [rth: Split from a larger patch] Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- target/arm/tcg/sme_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index e2e0575039..5a6dd76489 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn, if (pb & 1) { uint32_t *a = vza_row + H1_4(col); uint32_t *m = vzm + H1_4(col); - *a = float32_muladd(n, *m, *a, 0, vst); + *a = float32_muladd(n, *m, *a, 0, &fpst); } col += 4; pb >>= 4;