From patchwork Wed Jun 12 15:35:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 803478 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:e87:b0:35b:5a80:51b4 with SMTP id dz7csp852811wrb; Wed, 12 Jun 2024 08:37:34 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXCwTu7eVaQdZwy0te6PC1MrYJ3aphUElU5legLBz1GGSWuVF6PpBcef3ytlY6wrqiZGDb+pdTEZOeiNleTZgKo X-Google-Smtp-Source: AGHT+IGY7r9z4EGtnx5n7XApWTccuwVUfCUWZt8ehQeU21J2RBc4QUEHLU2nTK8ZAGKPQu/Vo4Gx X-Received: by 2002:a05:6214:328c:b0:6b0:865b:66cf with SMTP id 6a1803df08f44-6b191d46aabmr18165976d6.17.1718206654187; Wed, 12 Jun 2024 08:37:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718206654; cv=none; d=google.com; s=arc-20160816; b=WF41YE3HQHbNiwTdcqqymOR7zOK34Vlbi5ceK+3fCHRlFyHjIKEQuk1syCm4d0e46K ZtkI53CPWOhNsotWBZqwjuZWlQaufWoY7HuVzXaXNjz+oa7+f/yuuPmzSBKuH0qDWklS cOaLtyBGh4N0Xd3l+eN5/qQvPT0N+WilDyxL8Ghe7lsgpxLvt4IXLAJzup04hqO82k+X 2XcMeQb3gPcqHDbfeAvjfRMm+TAul/qIX9ylP5XMQNVOH6sWQfQjM9jmCHrnC5keC1TF Qp8O11bZv3oKgL1Zh2GzB5m/YwClFtlgyu6meAQ0KlbLlRwTJcWx9HG/8qLY2p7JwTFi xaxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0UFHAsoemA/1ZyFVkieFp/Fehtdb65Sq2hGoqSQrpDk=; fh=db25YsqUVo3eIRzWVB7HueHEzf7WHEt51xFPObrkxX4=; b=MKU4vdnvlfr9PxohvDJbLUfXcVdTIIYRKVpP+RrHmyq0QtvRQo75pG7Ang6b7YL1Va 3AittJYI92g1nEqf1OxJCviWA1cL6b3g07bivGeW8Tz5uuUlPSP3lS58vpMsp2wT5WDG 5cDY040GJQmkT+8S7C4qphcVvhIvHtNAdi943/ula14CguawoW3/jXA1RkuajiZ5Lx2x keMlWURoNFR5RaL0IocOWpCP8yg7u2S6ij29yq1hNSzaSYwbVJRWKdXjCNe3RQ+Sd7Bc A6M52G89+sHbJLhu30dEs8EDYD33gJxZNNhiqwkbPmn6UoNu/aGZgZmPmP3swue1Kc9D waYg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zxqKA84o; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-441530f868csi36682141cf.306.2024.06.12.08.37.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2024 08:37:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zxqKA84o; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHQ0R-0000ww-AX; Wed, 12 Jun 2024 11:35:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHQ0M-0000hL-VM for qemu-devel@nongnu.org; Wed, 12 Jun 2024 11:35:19 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHQ0H-0004KW-61 for qemu-devel@nongnu.org; Wed, 12 Jun 2024 11:35:18 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a62ef52e837so107166b.3 for ; Wed, 12 Jun 2024 08:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718206512; x=1718811312; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0UFHAsoemA/1ZyFVkieFp/Fehtdb65Sq2hGoqSQrpDk=; b=zxqKA84oXR+mtYuxxvWvdUd4yx8ec6lG2s0QKMG4hV3ozJ2XKuzLrnxMMbTfXGlOXx 5vZ6boR56bHcKthgNxYc/S3QnahgRKwTphgU2L3TMO1AtyM32Ku7GBTcX9Bjy4Pd4cDK fy+ZCM8tnb5kBNeoo4712B1HTHmoIg0yDIyDwv7m+1x4JSu2cg3pNGKqhrg9U+kJxM95 q/xaPP4cLzxGFApc6pvLPbrXaCSKqvUloKPnIJ2mmhB7/xlkWtiEZTb/diZnnO9HhwC/ IMqtYH46t86YGbLRWOr6teNB7fSB5qSx6C6+wCyDgj7aJN2MQAXR1B+b0EaRV8gMEaut ldBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718206512; x=1718811312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0UFHAsoemA/1ZyFVkieFp/Fehtdb65Sq2hGoqSQrpDk=; b=IyMdRKoIhTz8WZSdl3lQALKJZgoW8RknhVPVqKAIWqq96hGYkUNEouSdS95CbELLf0 wllmX9qMxPDu/mJA6LDcJHstA/pbkvEWqjkvP9foeypjyWmI1SywJV0Tn3ufprDu3mpG r7Msel9UTY0AS8hk/VMzb6TXzE07sbo7CtgiUVJEuMV/JRDQhZhhMGHkzK1ARkm4HCaO T9zxxdwuCxT15bWZLCTN9dsCKROEhRgUzlrIHk7uTXLJOYyilD4cTzeOgvL/rk2DKHLR mLxDsFMWd5uggGKIf9ncXV4s9S+smR72gkK8d2YD9d4Wt7ZkLyMUVntNMOYm/FG0EHJt zorA== X-Gm-Message-State: AOJu0YyZIC49AnMPJ/3r5G0Ff/CSMVgEQsXa5XghK4nGK4jdiwNnamX6 aKnTy1ZIIuXvxRRvldJ/b0h4tq+/jOiOo7y/rGvZCFoprbojJ4Gp88VAatMj0Zk= X-Received: by 2002:a17:907:7756:b0:a6f:4f3f:e6d8 with SMTP id a640c23a62f3a-a6f4f3fe75emr48893466b.20.1718206511842; Wed, 12 Jun 2024 08:35:11 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f2195a2a3sm370298966b.99.2024.06.12.08.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 08:35:09 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 784465F93D; Wed, 12 Jun 2024 16:35:08 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: David Hildenbrand , Ilya Leoshkevich , Daniel Henrique Barboza , Marcelo Tosatti , Paolo Bonzini , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Mark Burton , qemu-s390x@nongnu.org, Peter Maydell , kvm@vger.kernel.org, Laurent Vivier , Halil Pasic , Christian Borntraeger , Alexandre Iooss , qemu-arm@nongnu.org, Alexander Graf , Nicholas Piggin , =?utf-8?q?Alex_Benn=C3=A9e?= , Marco Liebel , Thomas Huth , Roman Bolshakov , qemu-ppc@nongnu.org, Mahmoud Mandour , Cameron Esfahani , Jamie Iles , "Dr. David Alan Gilbert" , Richard Henderson , Akihiko Odaki Subject: [PATCH 3/9] plugins: Ensure register handles are not NULL Date: Wed, 12 Jun 2024 16:35:02 +0100 Message-Id: <20240612153508.1532940-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240612153508.1532940-1-alex.bennee@linaro.org> References: <20240612153508.1532940-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Akihiko Odaki Ensure register handles are not NULL so that a plugin can assume NULL is invalid as a register handle. Signed-off-by: Akihiko Odaki Message-Id: <20240229-null-v1-1-e716501d981e@daynix.com> Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- plugins/api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index 5a0a7f8c71..6bdb26bbe3 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -507,7 +507,7 @@ static GArray *create_register_handles(GArray *gdbstub_regs) } /* Create a record for the plugin */ - desc.handle = GINT_TO_POINTER(grd->gdb_reg); + desc.handle = GINT_TO_POINTER(grd->gdb_reg + 1); desc.name = g_intern_string(grd->name); desc.feature = g_intern_string(grd->feature_name); g_array_append_val(find_data, desc); @@ -528,7 +528,7 @@ int qemu_plugin_read_register(struct qemu_plugin_register *reg, GByteArray *buf) { g_assert(current_cpu); - return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg)); + return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg) - 1); } struct qemu_plugin_scoreboard *qemu_plugin_scoreboard_new(size_t element_size)