From patchwork Tue Jun 11 10:23:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 803243 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:e87:b0:35b:5a80:51b4 with SMTP id dz7csp228144wrb; Tue, 11 Jun 2024 03:24:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUuHqrOoy1n2SgQLfl13aBnkp4Pi5yn/livovaEuGUH0tDizQhOW6ePb+Rt4zj82Yzpk1zZE098Yf0Th2BDMY7G X-Google-Smtp-Source: AGHT+IGj1sVBIHrv5S1fL6uwFcb9glbC7n3mXncXFwU9Ae4GdbWOsuCaYMHxRZN5r8rGvjSacjQV X-Received: by 2002:a05:620a:4049:b0:795:ab7c:8a71 with SMTP id af79cd13be357-795ab7c930bmr569324285a.4.1718101460519; Tue, 11 Jun 2024 03:24:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718101460; cv=none; d=google.com; s=arc-20160816; b=VToJezlN2mqmYi9PpUjiRyNSq0mR66zSnZzXMI4jNsIdnPzmhrou1j8JPzqX+t7+I9 NovrI7mV7OYIeNO3zlwRTTlQYR71VvmIEMSAUmZL83luXNTKfhVX6Ir4wezoYMRpa4AC YoXqu+NcmrjKwZsJaJPgRLFXTjQhwu25WTjJRyG7NIM4A+cL70NeMDDb1/sdhPLECnqx tUx7axjMd0FAiwTpZrT5erXjYta6sUzf7u7JTFieNnvrDu9k1kw1t0mrNOx7lKyClqWK NIASZQ4GyoLGuIpwJEdsW+wS3w1bYCrkUttKJCqsRwOozlQIW8qxhgZ7ZtiDa0s87k2o hrdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0tgZq3sbZcXD41HkUXjwl9sONKRxoM6G0WQFFkBzjWc=; fh=uoIbv1r+8U3cHO65CUbP9R+kO0oCFQ3JVzDTGSxa82Q=; b=rgIhuyMA7sJFlu7jQQusNzCqIkJwg5AaNKkAfzAZZGgoz+LP/JLtbsnYTaMfUhEbNU DaDlFPO3kwyjDm/+2bcZuPhqQvZVf/8uFdh8mQTM5VIDr+vCSwt5NjUDufYp1uMgFM57 JODJa4KQAqjDRKCM2dW1KWClG8OZ3ydlgkZ2o/Awom0cNcfzZLJNmow9hJSGmTM9VfiR pTEyNHnd2V998zMGHXzKtIwLlSDwanp3QRdRSwYc1K8X+NmQq+bmRqRLS6YIpn+oou6P eZZmdIcqml7FsJq5h+7HCuB6mWMkRg2Vm1MEmFwRDmqCEJTUc1jkUFkQn0EPlIAaL8fn v8MA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UB/y2fsD"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-795597417a1si730819685a.53.2024.06.11.03.24.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2024 03:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="UB/y2fsD"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGyf5-0006UD-57; Tue, 11 Jun 2024 06:23:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGyf3-0006Ty-Ir for qemu-devel@nongnu.org; Tue, 11 Jun 2024 06:23:29 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGyf1-0000ZH-U8 for qemu-devel@nongnu.org; Tue, 11 Jun 2024 06:23:29 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-52c4b92c09bso1097371e87.1 for ; Tue, 11 Jun 2024 03:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718101406; x=1718706206; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0tgZq3sbZcXD41HkUXjwl9sONKRxoM6G0WQFFkBzjWc=; b=UB/y2fsDJLtvXgHEAn5o+BUgRDr+osL/vPLHM/G1RIW2fPnMP+Wm6hhbuDzCb8dypr eBYSesrCHXmSccVkU+Q0BTwucTiczJOFN+IhoAv9Jtzq6BUpzGjEtfrwEcC4b6G27JZJ lQs+GaF/QiazCdNXPHYDq+zB+iioCaPZYHUql5Gp6kzEjoMQHjc1OA+mLNmLQlG4izrr xOVwN2h84N0g+/qmdA6ZFk5LkC85B4YPLnU08SR/cMDCb8V4VBljJLHz0ZAC2/SzeTp1 cWMkmFbBwZNiBDnilaNfJi69pmdaMFwpnnBvu4MG7SENaGPLJJB8YlBqv6y6+x6cwVYb 9+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718101406; x=1718706206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0tgZq3sbZcXD41HkUXjwl9sONKRxoM6G0WQFFkBzjWc=; b=KspxlSPDr+2jrOxeDzSo3mOK0Of2rYJSyUAlsrzAXwgKbo+1RHn35jewl4zZ2iiDPA bliCBuC1caPHqgg+ZeE5KWn+kEvUnVwYYz0MsTlIOPLpArg/7+md8btkheGrt1G1n5ML WzoWBiFMhDkK1cmRJzLShy/TqekKjPOcjH7IpSoyQV5AtXtqP3MSkYzOH/Z54ey1VIcC uBA7WpfCaPb4dqVeGpOpVV3eH8hSqxn/I3pLn4EfQmF0ZGsm4np4fntdU0sTWRa4eO8u kIi/YpmS2NnsffWeGkws4WsiRn20MZ6DEHe3a2v4V6BA3Mak2fzGArGmuNvSzloQeyyX KcFg== X-Forwarded-Encrypted: i=1; AJvYcCVrtr4ILEG3LgXi3vNkRmsRl9Wm4cUpN7U8+zJy8CpHOF4OwXRdgm33UYEFB84b/k4YR2HTudlKJppN2b8uMjU0nfSJI/k= X-Gm-Message-State: AOJu0YwIj10LH6pgpTzZHx6OQ3ZkcRbgMY8XNlG74k5YFnwFs5WfryRo P297IKwArQzccfctffyvK0WbQ2b9NtZJCmIzdaYyVTPpPs08vrZoEJD5rNMaEdc= X-Received: by 2002:ac2:551b:0:b0:52c:9725:b334 with SMTP id 2adb3069b0e04-52c9725b492mr465698e87.54.1718101405948; Tue, 11 Jun 2024 03:23:25 -0700 (PDT) Received: from m1x-phil.lan (rsa59-h02-176-184-32-6.dsl.sta.abo.bbox.fr. [176.184.32.6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f0b876d80sm10294643f8f.109.2024.06.11.03.23.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Jun 2024 03:23:25 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Thomas Huth , "Dr. David Alan Gilbert" , Markus Armbruster , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH v2 3/3] monitor: Remove monitor_register_hmp() Date: Tue, 11 Jun 2024 12:23:05 +0200 Message-ID: <20240611102305.60735-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240611102305.60735-1-philmd@linaro.org> References: <20240611102305.60735-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=philmd@linaro.org; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Previous commit removed the last use of monitor_register_hmp(), remove it so new commands are implemented using monitor_register_hmp_info_hrt(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- include/monitor/monitor.h | 2 -- monitor/hmp-target.c | 16 ---------------- 2 files changed, 18 deletions(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index 965f5d5450..2199a74913 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -55,8 +55,6 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags); void monitor_fdset_dup_fd_remove(int dup_fd); int64_t monitor_fdset_dup_fd_find(int dup_fd); -void monitor_register_hmp(const char *name, bool info, - void (*cmd)(Monitor *mon, const QDict *qdict)); void monitor_register_hmp_info_hrt(const char *name, HumanReadableText *(*handler)(Error **errp)); diff --git a/monitor/hmp-target.c b/monitor/hmp-target.c index 1eb72ac1bf..86f48c613b 100644 --- a/monitor/hmp-target.c +++ b/monitor/hmp-target.c @@ -145,22 +145,6 @@ static void __attribute__((__constructor__)) sortcmdlist(void) compare_mon_cmd); } -void monitor_register_hmp(const char *name, bool info, - void (*cmd)(Monitor *mon, const QDict *qdict)) -{ - HMPCommand *table = info ? hmp_info_cmds : hmp_cmds; - - while (table->name != NULL) { - if (strcmp(table->name, name) == 0) { - g_assert(table->cmd == NULL && table->cmd_info_hrt == NULL); - table->cmd = cmd; - return; - } - table++; - } - g_assert_not_reached(); -} - void monitor_register_hmp_info_hrt(const char *name, HumanReadableText *(*handler)(Error **errp)) {