From patchwork Tue Jun 4 09:55:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 801397 Delivered-To: patch@linaro.org Received: by 2002:a5d:65c4:0:b0:35b:5a80:51b4 with SMTP id e4csp2313072wrw; Tue, 4 Jun 2024 02:59:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVnptrjPA4cMtJtcVrSZUgTVNqQobwDaaJKfUUKRIkrLYM67232KKBrscBe2wEFQCqfgjkagxqJpj99FQRPPr9o X-Google-Smtp-Source: AGHT+IFCAdHjNzxOQhTGTLRFPEWYYUOr1j/CEK5QDsyl8vv21uT8ABsVV8xRoikyaKXwzY8cpO4J X-Received: by 2002:a25:e0cf:0:b0:dd0:76e:d630 with SMTP id 3f1490d57ef6-dfa73ddb7d9mr11156513276.53.1717495173754; Tue, 04 Jun 2024 02:59:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717495173; cv=none; d=google.com; s=arc-20160816; b=ZlPEXxEjzJV849QqohtA9vfhgfq6dAK0Z2SV6mevojvmUq1JTNDNTT+lAxvDYIrwd/ 4QB/3Hw6NtxCPWKYhjegWED92elhzU7/cE6WxewUigz/VGX2TiXRDMspUr+1n5uJy2uN Zox0IeomWoONjzJ1xGNM8HhGyrN0dh90jC1To/PIkvheytR2eOFiC+tC7HfYSJWm/kg0 c6/9sbcq4dzrh5+fZNibCqDp6dM0jZWjDa9wYvJmEbx1UOoBKkvsnf8T+KNG/AGvho9l 1eeY5v3m4sWANUovpnP2qCpsNGqNiedr+6/hdOlx9T7nzifgrZ8LJfF07KnsJtpnvNL2 PORQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Maqg614wB6IQJrQoZvf0lrAnLMpTuuWUZ3NE8tvuj7U=; fh=Kwva4PF4MU0CAODI8dO98oDU5IqpAA4cnlOSgFn3sAk=; b=oKoqe9LKIS2+2u852OiQxcQKkD7RGa6wBJLk+Oks9bK3nUxtAQX3YYfEhlc3DTEYjL w7zsMOBjeQf4i5pMjhidfIKHOlA+SPWBMaCiElFAiUH8g78XOredaF/1JBxi0zCVfX9O gidSI9uz9+dQBlF8yCbKOzbGwUuU1g5A7rIlgImHyto9a+VAMXdp+RaEfDTsKSRSwbuN 49zwXjkA9QkradLBpn+H5gvqE0mqvY7HpfFFyCTDo5r7W5YDlWso/K4BqaWiHByTQrzF kMe3QMzD/DK2fjgbf1cQJB6s79Ja93ZCKPiCxH8CrgrJZuKHgjwmTqZDmMm1jGtQK3wu 9QsA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SuOeEavA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4401ad17e33si15802501cf.397.2024.06.04.02.59.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jun 2024 02:59:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SuOeEavA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEQvN-0000if-5L; Tue, 04 Jun 2024 05:57:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEQvM-0000aq-62 for qemu-devel@nongnu.org; Tue, 04 Jun 2024 05:57:48 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEQvK-0002GC-Id for qemu-devel@nongnu.org; Tue, 04 Jun 2024 05:57:47 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-354f14bd80cso664836f8f.1 for ; Tue, 04 Jun 2024 02:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717495064; x=1718099864; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Maqg614wB6IQJrQoZvf0lrAnLMpTuuWUZ3NE8tvuj7U=; b=SuOeEavAjG+sdjApvbmzVNN+BA1o6s+ZqildnXCUUgGwJA5UGE3sNbskVLIbMXaNcz BfEXHv8Far743LZ/viGzDGiLdju6QIaLBFYcecBZxFSTiN+qgFYAl0cz+BgPX4AbQZ/0 MrzLqwhihHHUo3elpHfYDzueMycsI4S84yOvfMU15Bt6uZw68erdgVeH/5N0/YbrRNTi //r2uoE3p0C6SlP6ZCcOv25/5F41JxBw0oinEN0I++aXZB+sQzn2gZFgd8KXzdBcZXjw 6XQbqRNqNmzpkV8BnplgsrPEoRG69tInLGUprYG8fzrgmjgEk1T//MJ+wnN//wzncSZb XT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717495064; x=1718099864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Maqg614wB6IQJrQoZvf0lrAnLMpTuuWUZ3NE8tvuj7U=; b=a9foHtwAT+xAoGp8J/cYCZo/IFkHiImvbxgBMpiAm/Zv2Sj63O710wblTbg0d2XqvQ i3tf0H1+hIQYm570W8Ni2ODmXMcl8kwpyx3yCUwo7XATVAbnfAVWGzygjE3SVVQLbe4Z fO7XieR6dRY0xCDVaWyruJ3YkrcinaVBG3ESWgjwkozz0qqoJfyDhYSCKWLburIRXvHs D+gAlZr+ncMndHNYJT1fLVB8nnPbBbvtv8AWRygCaKFG2VF9BzoxDBQMWsiFKVDUFFI0 tLhwb4RBkSDgMrFhW/yn77FFUWxVZh8DuG8GsmSjxKEBWlNLhyOopJyNqp7J5GiAlwEA snag== X-Gm-Message-State: AOJu0YzfGjPosnQbjHzCdxw4/e/CksER0wmX8EfDViW4Yz/2hyEaAHFK pOqpb3C1y7R0FmmgQjNQI8UaFYQMdafgZ6JYpvs6eFVqfxjugy8SEFwnQupauTnQo2+YhE4ocBz Q X-Received: by 2002:adf:e2c2:0:b0:357:ff92:ab06 with SMTP id ffacd0b85a97d-35e0f25b2e3mr8934642f8f.2.1717495064467; Tue, 04 Jun 2024 02:57:44 -0700 (PDT) Received: from m1x-phil.lan ([176.176.159.34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c0f57sm11125532f8f.12.2024.06.04.02.57.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 04 Jun 2024 02:57:44 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Subject: [PULL 17/32] cpu-target: don't set cpu->thread_id to bogus value Date: Tue, 4 Jun 2024 11:55:53 +0200 Message-ID: <20240604095609.12285-18-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240604095609.12285-1-philmd@linaro.org> References: <20240604095609.12285-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Alex Bennée The thread_id isn't valid until the threads are created. There is no point setting it here. The only thing that cares about the thread_id is qmp_query_cpus_fast. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier Message-ID: <20240530194250.1801701-4-alex.bennee@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- cpu-target.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cpu-target.c b/cpu-target.c index 5af120e8aa..499facf774 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -241,7 +241,6 @@ void cpu_exec_initfn(CPUState *cpu) cpu->num_ases = 0; #ifndef CONFIG_USER_ONLY - cpu->thread_id = qemu_get_thread_id(); cpu->memory = get_system_memory(); object_ref(OBJECT(cpu->memory)); #endif