| Message ID | 20240530145349.41309-2-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | semihosting: Restrict to TCG | expand |
On 30/05/24, Philippe Mathieu-Daudé wrote: > Semihosting currently uses the TCG probe_access API. To prepare for > encoding the TCG dependency in Kconfig, do not enable it unless TCG > is available. > > Suggested-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/mips/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) xtensa and m68k also `select SEMIHOSTING`, were these missed? Otherwise for patch 1 & 2: Reviewed-by: Anton Johansson <anjo@rev.ng>
On 7/6/24 13:08, Anton Johansson wrote: > On 30/05/24, Philippe Mathieu-Daudé wrote: >> Semihosting currently uses the TCG probe_access API. To prepare for >> encoding the TCG dependency in Kconfig, do not enable it unless TCG >> is available. >> >> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> target/mips/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > xtensa and m68k also `select SEMIHOSTING`, were these missed? TCG is the only accelerator they use, so it is kinda implicit, but you are right, I'll update for completeness. > Otherwise for patch 1 & 2: > Reviewed-by: Anton Johansson <anjo@rev.ng> Thanks!
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > On 7/6/24 13:08, Anton Johansson wrote: >> On 30/05/24, Philippe Mathieu-Daudé wrote: >>> Semihosting currently uses the TCG probe_access API. To prepare for >>> encoding the TCG dependency in Kconfig, do not enable it unless TCG >>> is available. >>> >>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> >>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >>> --- >>> target/mips/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> xtensa and m68k also `select SEMIHOSTING`, were these missed? > > TCG is the only accelerator they use, so it is kinda implicit, > but you are right, I'll update for completeness. So I'll wait for a v3? > >> Otherwise for patch 1 & 2: >> Reviewed-by: Anton Johansson <anjo@rev.ng> > > Thanks!
On 10/6/24 11:29, Alex Bennée wrote: > Philippe Mathieu-Daudé <philmd@linaro.org> writes: > >> On 7/6/24 13:08, Anton Johansson wrote: >>> On 30/05/24, Philippe Mathieu-Daudé wrote: >>>> Semihosting currently uses the TCG probe_access API. To prepare for >>>> encoding the TCG dependency in Kconfig, do not enable it unless TCG >>>> is available. >>>> >>>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> >>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >>>> --- >>>> target/mips/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> xtensa and m68k also `select SEMIHOSTING`, were these missed? >> >> TCG is the only accelerator they use, so it is kinda implicit, >> but you are right, I'll update for completeness. > > So I'll wait for a v3? Yes, on the way...
diff --git a/target/mips/Kconfig b/target/mips/Kconfig index eb19c94c7d..876048b150 100644 --- a/target/mips/Kconfig +++ b/target/mips/Kconfig @@ -1,6 +1,6 @@ config MIPS bool - select SEMIHOSTING + imply SEMIHOSTING if TCG config MIPS64 bool
Semihosting currently uses the TCG probe_access API. To prepare for encoding the TCG dependency in Kconfig, do not enable it unless TCG is available. Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/mips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)