From patchwork Tue May 28 20:30:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 799507 Delivered-To: patch@linaro.org Received: by 2002:adf:e110:0:b0:35b:5a80:51b4 with SMTP id t16csp421486wrz; Tue, 28 May 2024 13:32:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWfbtAkJkjFSMe8adu8gISun5UI/ZNQLhecMML003PcKufyIjS/DpS+53mp0TPhIEnyDyRE8wAYQfPl/OdZP2YU X-Google-Smtp-Source: AGHT+IGJIxDKy7gCve6FvjSdKNrRMiGu43O6zgAnOXYaBA5hIvpkBsAD4OzXbrI0b1cjXflBgv0v X-Received: by 2002:a05:620a:1110:b0:790:fb1f:de51 with SMTP id af79cd13be357-794ab057a79mr1372816485a.15.1716928347436; Tue, 28 May 2024 13:32:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716928347; cv=none; d=google.com; s=arc-20160816; b=yaqJGZwznZixqYdE7z2pDkPpyfQluZBuXRMglP4S7nuOtcZ4AVl8LTxWB9mMpuq9qT k2PgORPXhxoQv941d6QK7LuoDDgVtsCzQ97+XX4z4Za/Yo7MUAYAPZo4Hyy5wkcsQngA E21+kx+ceeT8Hb++K9Fx74lbF2fE9N+a+/HdOom5fgoqlyqC5q9y4zgMZUFzo5weYjjm A7VUS31FENbNwqu9axp9+wvup2T8SKjbJ+tBcsYzYhIGWMUPfDQEjdEMP6VDkB0JFjPf mkvpSahVHtezPSkIp/HI0WZmgllnpn1V7Y6aonK0nx/KPsyzLwFTTA+et70RskgQoUoC XFOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hINvuUb552QxtnFYsIP8gVHA+s4s5KaUcjBPHEb0IOw=; fh=ZhBia3nL9o1nuf7SbgdYn/0pDmAeja6gisyWXi2cqYE=; b=rZmzCdNcheWeU2wDZb1yHx2ICVYOJjJk1dnhGO7qq8UQoHL7Gqwjcow2K73oDt5xdl fPGUXK24DU4P3ADVQ6r/BcjRWwE4+ZgObLlknu57qq624FWSmeVSBSr9qGp5RTnseP8e 8xFh7KRX0pqvLHDL/r7sfyr6IY73EN5eOl6NMg+xhIIW5fsrkIbi4PaKc1IjyHgXkVmW huWMfifi1BUXXTaOI3WTHlX4eMy4vKn71BUMEYyljknymc8P+oxsTjTPLeLGw5PY9pxE Ac7fQ/Zmj2w2B570nwt3B8jdvqXsGHBItdqwN2koRPuhJT2xNyZ6JeoJElMP0T9Yi+gV bEhg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ocSHLx4m; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-794abd51119si1087511785a.613.2024.05.28.13.32.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2024 13:32:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ocSHLx4m; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sC3UB-0003pC-5Y; Tue, 28 May 2024 16:31:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sC3Tg-00035B-KM for qemu-devel@nongnu.org; Tue, 28 May 2024 16:31:24 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sC3TS-0003jL-Mp for qemu-devel@nongnu.org; Tue, 28 May 2024 16:31:24 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6f8e859eb20so1013458b3a.0 for ; Tue, 28 May 2024 13:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716928268; x=1717533068; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hINvuUb552QxtnFYsIP8gVHA+s4s5KaUcjBPHEb0IOw=; b=ocSHLx4mTeLwaXV4ChtpfBHmHekd1qfCVwpR+wpZV1aSxLVfuWYt5KXi7fI2/jfqrE xDRJjET0PWDEemQJfoJqQ2mCAWYJdq7U03uVqeUXGlY+Eeg/bAj1Bw444POkan06xbtU ztuMLS0ZanUfhepnkPwAFjz7q3kCnyiZxspzP9auB+4Pmm5qH2wf22mfQEqmgdOrzyd/ Z4WciSagQ3bdxNHwsq1m8BwkJPFMTvN56A2rQS2VXSTF8UAgvL93oHodcAt2pKh1dIao D04mRLxwSHJfPVRV/EDH8VCVZWydZAtUPZoDfmcmM4SdRcEKql4D3UOg35HJs6pvLaO9 SYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716928268; x=1717533068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hINvuUb552QxtnFYsIP8gVHA+s4s5KaUcjBPHEb0IOw=; b=KZWbK+IiCuh8ZiPDqzpI+9FNlZV6b4fami9gv2KTKADlNSX8wsHEvjr+wozLbg6R2V IAg/jgy49L4jLXPiX8vR0kwkAnWfZl5MBS9f8knJFTALfwH+gvR99msd4h0ktCcXtTd2 AYfzbughRqiHgdiz6NuVFBsBhDufbynrN+cojZeSXK450V2o8X6o1Tqqa1zhh0fb2CVO yRqoeLDCLvLtNNSHeOJsLEC5qOFN6qOVDo5tZXZkyYBZcMfjRD+onMb14VGEkz62AzQm 9KEEXY/xjcYZ3/LpQ09XLyUFRApe40WJVIgzaaZkfkHWT6f8nliY6sGWP1NsLczT08mR jYew== X-Gm-Message-State: AOJu0YwysuaW9+JEEzl8UWWUu8SjJX/Ih4rI2He/nAMOsSsk1crxwkmi 6zqqSydCOnI6iRNOz30V52KGgm7vlneJDIIusIxf2t4KUP8fdbryYtJFvrbABpXk2iHt7xxYz8F K X-Received: by 2002:a05:6a20:de14:b0:1af:ab09:c555 with SMTP id adf61e73a8af0-1b212f34c55mr10586470637.47.1716928267929; Tue, 28 May 2024 13:31:07 -0700 (PDT) Received: from stoup.. (174-21-72-5.tukw.qwest.net. [174.21.72.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fbd3dbe9sm7042036b3a.10.2024.05.28.13.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 13:31:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell Subject: [PATCH v3 25/33] target/arm: Convert SRHADD, URHADD to decodetree Date: Tue, 28 May 2024 13:30:36 -0700 Message-Id: <20240528203044.612851-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240528203044.612851-1-richard.henderson@linaro.org> References: <20240528203044.612851-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/tcg/a64.decode | 2 ++ target/arm/tcg/translate-a64.c | 11 +++-------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode index b1bbcb144e..1c448b4f7c 100644 --- a/target/arm/tcg/a64.decode +++ b/target/arm/tcg/a64.decode @@ -916,6 +916,8 @@ SHADD_v 0.00 1110 ..1 ..... 00000 1 ..... ..... @qrrr_e UHADD_v 0.10 1110 ..1 ..... 00000 1 ..... ..... @qrrr_e SHSUB_v 0.00 1110 ..1 ..... 00100 1 ..... ..... @qrrr_e UHSUB_v 0.10 1110 ..1 ..... 00100 1 ..... ..... @qrrr_e +SRHADD_v 0.00 1110 ..1 ..... 00010 1 ..... ..... @qrrr_e +URHADD_v 0.10 1110 ..1 ..... 00010 1 ..... ..... @qrrr_e ### Advanced SIMD scalar x indexed element diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 40aa7a9d57..9ef5de6755 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -5458,6 +5458,8 @@ TRANS(SHADD_v, do_gvec_fn3_no64, a, gen_gvec_shadd) TRANS(UHADD_v, do_gvec_fn3_no64, a, gen_gvec_uhadd) TRANS(SHSUB_v, do_gvec_fn3_no64, a, gen_gvec_shsub) TRANS(UHSUB_v, do_gvec_fn3_no64, a, gen_gvec_uhsub) +TRANS(SRHADD_v, do_gvec_fn3_no64, a, gen_gvec_srhadd) +TRANS(URHADD_v, do_gvec_fn3_no64, a, gen_gvec_urhadd) static bool do_cmop_v(DisasContext *s, arg_qrrr_e *a, TCGCond cond) { @@ -10923,7 +10925,6 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) return; } /* fall through */ - case 0x2: /* SRHADD, URHADD */ case 0xc: /* SMAX, UMAX */ case 0xd: /* SMIN, UMIN */ case 0xe: /* SABD, UABD */ @@ -10949,6 +10950,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) case 0x0: /* SHADD, UHADD */ case 0x01: /* SQADD, UQADD */ + case 0x02: /* SRHADD, URHADD */ case 0x04: /* SHSUB, UHSUB */ case 0x05: /* SQSUB, UQSUB */ case 0x06: /* CMGT, CMHI */ @@ -10968,13 +10970,6 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn) } switch (opcode) { - case 0x02: /* SRHADD, URHADD */ - if (u) { - gen_gvec_fn3(s, is_q, rd, rn, rm, gen_gvec_urhadd, size); - } else { - gen_gvec_fn3(s, is_q, rd, rn, rm, gen_gvec_srhadd, size); - } - return; case 0x0c: /* SMAX, UMAX */ if (u) { gen_gvec_fn3(s, is_q, rd, rn, rm, tcg_gen_gvec_umax, size);