From patchwork Thu Apr 25 00:00:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 791760 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:346:15ad:a2a with SMTP id g4csp1116190wrq; Wed, 24 Apr 2024 17:03:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXnHBi2x2fRUNXkM1OoXjVBYtz9B4RPRapZQSkG72aUoelte68dS7xxT23PdyxWfkTwO8rjNklvPxIV3TvSaFV5 X-Google-Smtp-Source: AGHT+IE/IB9BvyMp1zMz6V4tj6L1rAh49VzCyEYoxg6edGKis/N7JUyNArih8rvx4CYGIWmLGqhV X-Received: by 2002:a05:6214:1792:b0:6a0:974a:24b0 with SMTP id ct18-20020a056214179200b006a0974a24b0mr2964752qvb.34.1714003401427; Wed, 24 Apr 2024 17:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714003401; cv=none; d=google.com; s=arc-20160816; b=az2ahpMPBRWoVqflsOh6yQFdARp4eu7oLm7wUw4jOVgf2PA2rLBrEoI2uwtulKHcM9 4wY8ggXCZgSZxmNzY0prbI2y7+RCU/AmpPf+/8C5FiJimGuQ8O1e3PaQNU5lBG5eHTX0 sntNEJTQ4ZBPeXiduCi2FkfBRc+Eufzl6aYVH2ejNtOmZXkA0sisY5nNh4K9exDiZsUX fRGpkv31nj+F56MVShKIuaQYzb4NW7mPRPJvv7zyOM18GACEQyZMxsqMKys9SBJlrULg A6RBgFVtjV4JnqEvTR3WHUMVytWTHQi6hw536PvgLSopfWwDHgDKO3DO2ZZnLDIayxuv +Rug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=RnrM6xlTtlmtawC51lsQAVs42r4HEzE1iyIC+QHuURc=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=mnCKTkRxVkyIci6SgffNTGkLzwJj2VoXpxYKU2Xry9QVvHhaWjT3Pa1CYLzvmEvIMr G1hDsFxDRIxaLclUwzX4XS4J2gq5QOMWHvN+/Qsh/gl6mbzeDX0e68eM4kYTxMmpLXr3 xRBaimxZ1gLSSnYA+2aZaGQTmlaaldbzllmZ5xHHBXFER/69Wp76eGuaHotDfizXRgj0 UPI2QyTWDy0ApsGXsw3dEod1PjO01BUS6kdekhnhniebUnI1NAsGjVCd3a+mZ6BvCsoI G65cVCoB9v3KPXO94JqO7oiYAIDoUKQkV2Hhhe1VTsa9B0diUOwwKu+zN3ZTA3i+nbvJ fBGw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B5w1n5Q4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c14-20020ad45aee000000b0069b39482a16si16679826qvh.342.2024.04.24.17.03.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2024 17:03:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B5w1n5Q4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzmYO-00007S-0m; Wed, 24 Apr 2024 20:01:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzmXw-0008IZ-DJ for qemu-devel@nongnu.org; Wed, 24 Apr 2024 20:01:05 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzmXr-0006Is-0c for qemu-devel@nongnu.org; Wed, 24 Apr 2024 20:01:01 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1e3f17c6491so3355955ad.2 for ; Wed, 24 Apr 2024 17:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714003257; x=1714608057; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=RnrM6xlTtlmtawC51lsQAVs42r4HEzE1iyIC+QHuURc=; b=B5w1n5Q4bUKfTJ7WZfK+zAPQngmi1Zbn5ft/Xnk0T7+wy9TYJawPe87ehjjpI1nMIy dMnGf0lBAvXyKUfQe+H1jGw/jIUzFJznV2laqPyWnwzOs5pEJFtLkOG6R1onJ+00at3f FMwlBx8EXBZYVtCrt3vrfNkxKt5f6BahBsyEMkfm2i8nH7dMb1VwdzONcOkW56e3OtCh Z2rYHfUeuh9smJKhwzARzngc2Lp4ZnWIHrs8rZA/MUtc5haP0BYtaYnkrfdKS1JoPyxg Mffe110c4bKIDdjINNckLK0rBRfY4WgtVl2rPFdfXgmoQbzGz3EwQwfV+wfIRX5NjpH6 IDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714003257; x=1714608057; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RnrM6xlTtlmtawC51lsQAVs42r4HEzE1iyIC+QHuURc=; b=ZoM8qfoSvZ1tQj/VyfQVUnlPHcoReO+gb6KlFwwK7gU+Rlw5lcdAPzS0APdIl6g32v 5a2SmxHAYdGuN100tl+7YlF3jrCudVRAowWH8HW/nWu5IWfz6kOTdkR+HH6SrgkA+hv3 1j+CuubzdRb9QrtwrTYsKWFrxMCc99CPQUbtvHXOoNpMXGxtsxPkSQ3MaILAfHpQlsq/ PxlOTdeG580ikT6lvJpxaD+aRPHfsHkWIoQTVqyb9cDQjWESkkYCl2m6sdr9ALvuNXYO EOO1HftvzgNspjX/Hn+yZF4BXIiEe1ODqlXQl3pVDpqzcPbnEUqlBYr6dA/DHS5StLeg m9XA== X-Gm-Message-State: AOJu0YyQcHhJhxlzFGzliajUsrN6YO6IJoLkAmpkjhV9hCnLgJh8TooX 8pHQEz1FQqqoFIm90zJiaJ5EYQWR48su+H419JsR/R7m16Eo9Z304ztE9h/sZWbzZipadM6muY0 / X-Received: by 2002:a17:902:b184:b0:1e8:37ea:d10 with SMTP id s4-20020a170902b18400b001e837ea0d10mr3367321plr.56.1714003257450; Wed, 24 Apr 2024 17:00:57 -0700 (PDT) Received: from stoup.. ([156.19.246.23]) by smtp.gmail.com with ESMTPSA id t6-20020a170902e84600b001e604438791sm12465715plg.156.2024.04.24.17.00.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 17:00:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 33/45] target/hppa: Do not mask in copy_iaoq_entry Date: Wed, 24 Apr 2024 17:00:11 -0700 Message-Id: <20240425000023.1002026-34-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425000023.1002026-1-richard.henderson@linaro.org> References: <20240425000023.1002026-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org As with loads and stores, code offsets are kept intact until the full gva is formed. In qemu, this is in cpu_get_tb_cpu_state. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index cc409ffe13..fb5bc12986 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -636,15 +636,10 @@ static DisasIAQE iaqe_next_absv(DisasContext *ctx, TCGv_i64 var) static void copy_iaoq_entry(DisasContext *ctx, TCGv_i64 dest, const DisasIAQE *src) { - uint64_t mask = gva_offset_mask(ctx->tb_flags); - if (src->base == NULL) { - tcg_gen_movi_i64(dest, (ctx->iaoq_first + src->disp) & mask); - } else if (src->disp == 0) { - tcg_gen_andi_i64(dest, src->base, mask); + tcg_gen_movi_i64(dest, ctx->iaoq_first + src->disp); } else { tcg_gen_addi_i64(dest, src->base, src->disp); - tcg_gen_andi_i64(dest, dest, mask); } }