From patchwork Wed Apr 24 17:45:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 791531 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:346:15ad:a2a with SMTP id g4csp965457wrq; Wed, 24 Apr 2024 10:46:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVek0No3GnN7f2m0bpLgwyhMi3YMASG012Lpjc1egCtgAoc7u5HEsvPE6ZMwe4BU8LBX7QVycEdKwXFxCALYpn6 X-Google-Smtp-Source: AGHT+IEAc8mjg8I9iKQtokk13AEoV5Y2f3ah5Hi5egsjHU9uKCjy0faJVeGK+FeD/QijYkBvXoYE X-Received: by 2002:a05:620a:a99:b0:790:890d:7bc7 with SMTP id v25-20020a05620a0a9900b00790890d7bc7mr3357661qkg.2.1713980790632; Wed, 24 Apr 2024 10:46:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713980790; cv=none; d=google.com; s=arc-20160816; b=v/0gAZn+ZiZbnPxxrKTebkblNx+p+krAsoVLW/POXP/bezyB1w6zq7tytYtWwt2606 YQPmLoBJAWcn1K9n1f7f7/7m+Lgu6ZzThzE3gWDq3EpG2puXV/c66ZkNMFXtQzgqEpL0 RKOKkQLzbXEFBFzigK1qdmSgWAvvalYPdwCE/IDtv37Ubik//YhszKINQIS5U3Pl7nSK DGp6c0+akNJ0ryM8eh/5yl/yOjGFJChzJF9dzgHPreSqk3u9gmfm762lONDHvxRJSuRq DNwzD0mcyGjO6h8VAlea3w2YSWSDaTp0XAq4zDGSWk1EVefhT0BzMcAl9pahy5UbrVev zmtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nHy7p+TsVd61UoOXNyWftQk9Qj6gD334eWPgXT4ErEE=; fh=cxz8nMap0jiqldc4p67rXc4XZepDJBIKRl1YE8QD7uw=; b=a5oSQ1YnkD3iq6eI9x5RQkQn0rgugV2adq2ZcDiH+6vQE6stq0p7sMI7QIHgo0sXgb /EWsco9Wd0U3PizSwZQa1l5IEnf2WVBADJSisZDdQTCWX7DEW9tGBLJ8KfFFzcgupXvN 5rEukj6QqqW3G8bCmi2EDIGbVBlUSMbJOTFi9pWdzsgRpYs5GL9jVfVxQd5xzRr2eILf rA5fjma4ALYbZNqnQvukX/WBZGrGvdyL8YJ5bTy3CMwEj3wqR7xikvgBqpsm9ksj54zo X5jC4TlX9iWn5t5bVAt4cAfhqjjgP5yQgZuQYehRiHz7va/lsx4mAu9g9AV0/nM702gZ +4HQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HzZaFJIM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o7-20020a05620a0d4700b007905c9d16desi11711952qkl.398.2024.04.24.10.46.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2024 10:46:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HzZaFJIM; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzggn-0005az-Vl; Wed, 24 Apr 2024 13:45:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzggO-0005Kl-Kg for qemu-devel@nongnu.org; Wed, 24 Apr 2024 13:45:26 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzggL-0005b4-P3 for qemu-devel@nongnu.org; Wed, 24 Apr 2024 13:45:24 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-34a3e0b31e6so51111f8f.1 for ; Wed, 24 Apr 2024 10:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713980720; x=1714585520; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nHy7p+TsVd61UoOXNyWftQk9Qj6gD334eWPgXT4ErEE=; b=HzZaFJIMOFG6+ofWC9QiH/vzu/10Ps+a4kASdk0uZMLuZ7Pvwf0m5OoMyW3kZ0n5GO 6AALIpb9dt50F+6mf4JohS7zgjsZJthKxZ3kOai4WuR2dCCFtlcviXE+QxgyMcYMfz6s i2T4g/5iOJvE1m7h3+gSFVLTYx/jVUjqhL+Q8qIcY/B0Kwb9UnQCpbHKqgUSjzmVfcfO F5KNwAI25eyk0q+e0UEfNciL6s6N8qTipZbD7lGQ9GrFCUsLW0bVqUmWxRPkTji8jiGP clA2hQjSVeA8jdNbIHcQkTHFzeK9+HwLNBqhg9IVdq7jwdttVSl+UF+XJ6KXucAwyhme Kobw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713980720; x=1714585520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nHy7p+TsVd61UoOXNyWftQk9Qj6gD334eWPgXT4ErEE=; b=hEGT/hN+ycXTgfTT3daeH9yXUVTyJ01jpbj8bGLvgyop0N6Twcf/aCvwYADzXjzwEt O9ETpc18QMQ479bh5P+gP7m/AlrojpIxgASROxmU4GAAxBfxKcl5jgBkLtk2lL84oSmP qgRn+Yq8qWyCDVQOUwSIYTmIMkIkireWA0PH8lc86IuYJOelOE0P8TmwjhyyfmNOOkre 1DM+x4Xrb9HTbtG0J8rdgLXtPpkJPcXhPGT5W+pfsUDYBCUPd4+7spJbE9WCfRRFcDqW H+LFxaJen18d9vU6IMdNjzWFLRMVmxBsxY4tKCxybs66MKQHl2GzqDkaqC9U+rl+ywLN aFHw== X-Gm-Message-State: AOJu0YzloicMVn7J+zb4U0rWefSt2hxnsNdgy9wAjZmeKTIFI0V5hXaN 1OK4TjDI4/E4gW2saNxf14+YtW4gVV9HjscKoQBaTS3BfRxa9A/zDMGs5i43lHEzzaJncmabhmV O X-Received: by 2002:adf:ea8c:0:b0:34a:9adc:c37a with SMTP id s12-20020adfea8c000000b0034a9adcc37amr1924659wrm.10.1713980719950; Wed, 24 Apr 2024 10:45:19 -0700 (PDT) Received: from localhost.localdomain (mon75-h03-176-184-51-42.dsl.sta.abo.bbox.fr. [176.184.51.42]) by smtp.gmail.com with ESMTPSA id s15-20020adfe00f000000b0034b03d0b94csm9059925wrh.74.2024.04.24.10.45.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Apr 2024 10:45:19 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , Sunil Muthuswamy , Roman Bolshakov , Alexander Graf , qemu-arm@nongnu.org, Cameron Esfahani , Reinoud Zandijk , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] accel/nvmm: Use accel-specific per-vcpu @dirty field Date: Wed, 24 Apr 2024 19:45:05 +0200 Message-ID: <20240424174506.326-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240424174506.326-1-philmd@linaro.org> References: <20240424174506.326-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org NVMM has a specific use of the CPUState::vcpu_dirty field (CPUState::vcpu_dirty is not used by common code). To make this field accel-specific, add and use a new @dirty variable in the AccelCPUState structure. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index 49a3a3b916..f9cced53b3 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -30,6 +30,7 @@ struct AccelCPUState { struct nvmm_vcpu vcpu; uint8_t tpr; bool stop; + bool dirty; /* Window-exiting for INTs/NMIs. */ bool int_window_exit; @@ -507,7 +508,7 @@ nvmm_io_callback(struct nvmm_io *io) } /* Needed, otherwise infinite loop. */ - current_cpu->vcpu_dirty = false; + current_cpu->accel->dirty = false; } static void @@ -516,7 +517,7 @@ nvmm_mem_callback(struct nvmm_mem *mem) cpu_physical_memory_rw(mem->gpa, mem->data, mem->size, mem->write); /* Needed, otherwise infinite loop. */ - current_cpu->vcpu_dirty = false; + current_cpu->accel->dirty = false; } static struct nvmm_assist_callbacks nvmm_callbacks = { @@ -726,9 +727,9 @@ nvmm_vcpu_loop(CPUState *cpu) * Inner VCPU loop. */ do { - if (cpu->vcpu_dirty) { + if (cpu->accel->dirty) { nvmm_set_registers(cpu); - cpu->vcpu_dirty = false; + cpu->accel->dirty = false; } if (qcpu->stop) { @@ -826,32 +827,32 @@ static void do_nvmm_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data arg) { nvmm_get_registers(cpu); - cpu->vcpu_dirty = true; + cpu->accel->dirty = true; } static void do_nvmm_cpu_synchronize_post_reset(CPUState *cpu, run_on_cpu_data arg) { nvmm_set_registers(cpu); - cpu->vcpu_dirty = false; + cpu->accel->dirty = false; } static void do_nvmm_cpu_synchronize_post_init(CPUState *cpu, run_on_cpu_data arg) { nvmm_set_registers(cpu); - cpu->vcpu_dirty = false; + cpu->accel->dirty = false; } static void do_nvmm_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->vcpu_dirty = true; + cpu->accel->dirty = true; } void nvmm_cpu_synchronize_state(CPUState *cpu) { - if (!cpu->vcpu_dirty) { + if (!cpu->accel->dirty) { run_on_cpu(cpu, do_nvmm_cpu_synchronize_state, RUN_ON_CPU_NULL); } } @@ -981,7 +982,7 @@ nvmm_init_vcpu(CPUState *cpu) } } - cpu->vcpu_dirty = true; + cpu->accel->dirty = true; cpu->accel = qcpu; return 0;