From patchwork Thu Apr 18 20:02:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 789860 Delivered-To: patch@linaro.org Received: by 2002:adf:e6ca:0:b0:346:15ad:a2a with SMTP id y10csp748404wrm; Thu, 18 Apr 2024 13:06:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVilKSnhKVFcq9NnC6n0qT01ElQ68WqZK5KuL7qQXcMzuEvf6TuBp4WHON8S4cBmwj4R6lLdr92D71+LjBUS7Ki X-Google-Smtp-Source: AGHT+IHDvYzau06Jp2WyKfHrqCXXKC/DaVTs6OzWOx6jPxpUGsSMc26IDiD+UgN9YDGgUW2pljE/ X-Received: by 2002:a05:6808:34d:b0:3c5:fed9:ea2f with SMTP id j13-20020a056808034d00b003c5fed9ea2fmr46230oie.24.1713470769317; Thu, 18 Apr 2024 13:06:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713470769; cv=none; d=google.com; s=arc-20160816; b=gEl7kN5x7R50NVuub9nHqtElyk6UEm+IFTM85T1cxEsb+etOaxfKq8igRrP9RsYRQq B1oxVDUHmc2umu2fh87ERlGjCDyR8bKFdkzaq33YvetJgLxhpRGvi8nMZIdu3PKv2los 4Ietr4SKGoJa0b6mwy2IymVWgbUKwMupsVm6ZwEsnuYpxff9tqtqg5ugzKaEjD1YyTeq knef5GPbPccuNjSy78CiXYJooDyV1HrLc8a1dNasJIojFjKeAG0ioet/Rq9qyLkiSJoX +VknvEXhqlSN2R1hgo30h/hC9VmOgi+ejYdITO4uMr5RFCxA35bcHibyYZIXbsR8YIq1 9Ncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=Y8pZDpswLWJDvYcSo+s2beflW/ytyUxJjPHLjxCjYm4=; fh=VnQSsLJ6tU3xftJEJWuGWplserK0coOB1jCu/kfGRn4=; b=BkhxPvFTWbk7VzOaTW/Ahte8zOESeDhnlvqLaSelHqu4nKrHOwX/JQFl31H2SRVlpH 4Cz5NqeaUS03u8nboaw8tgdu10Kr+KLineYnFemwLeHv2G7k0tMznxHygZjt41FsmW/K DfM83rylP6PrhWKsXvcpnpHfMaO3tdSMQdguZ4DpBr0bjjsC59ghFi59f8+KvNA4vojD rrm4b66Cg3rFNDcV5oEFO7hOqOCkqtZ8GMeyzRO0R9UBCaWFLt4zpK3R//pCh7579kzu JEDoku7G4zxS6Lck70V3DIw4K86KvK7ggstIyeJRWnVOE7I4f8OVbbAr8R4z2//m/ZBa QKEw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z25-20020ab02259000000b007e3e7eafc48si459129uan.81.2024.04.18.13.06.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2024 13:06:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxXyg-0001ok-0n; Thu, 18 Apr 2024 16:03:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxXyA-0001ZT-Jq; Thu, 18 Apr 2024 16:02:59 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxXy6-0005LK-Nt; Thu, 18 Apr 2024 16:02:54 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id EAF275FE13; Thu, 18 Apr 2024 23:02:27 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 5668CB93F9; Thu, 18 Apr 2024 23:02:25 +0300 (MSK) Received: (nullmailer pid 952872 invoked by uid 1000); Thu, 18 Apr 2024 20:02:24 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Zheyu Ma , Peter Maydell , Michael Tokarev Subject: [Stable-7.2.11 52/59] hw/misc/applesmc: Fix memory leak in reset() handler Date: Thu, 18 Apr 2024 23:02:12 +0300 Message-Id: <20240418200224.952785-11-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé AppleSMCData is allocated with g_new0() in applesmc_add_key(): release it with g_free(). Leaked since commit 1ddda5cd36 ("AppleSMC device emulation"). Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272 Reported-by: Zheyu Ma Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20240408095217.57239-3-philmd@linaro.org> (cherry picked from commit fc09ff2979defdcf8d00c2db94022d5d610e36ba) Signed-off-by: Michael Tokarev diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 5f9c742e50..80642efc57 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -273,6 +273,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) /* Remove existing entries */ QLIST_FOREACH_SAFE(d, &s->data_def, node, next) { QLIST_REMOVE(d, node); + g_free(d); } s->status = 0x00; s->status_1e = 0x00;