From patchwork Thu Apr 18 17:49:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 789812 Delivered-To: patch@linaro.org Received: by 2002:adf:e6ca:0:b0:346:15ad:a2a with SMTP id y10csp695203wrm; Thu, 18 Apr 2024 10:52:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV/PLVVbYOxYbkn+24PTMARiGVklzJfWyhPnKBqbP3VPd9LqaQmfm/fjOAQaOUt/z13wRsctiE73pZTVsqdMIDx X-Google-Smtp-Source: AGHT+IHSgCI8av2Uf60oeyT/0evYfe5jJfdB6xQIim/9tIT0Te8nka3aIX/4U1UvVYHu9Fshmtcm X-Received: by 2002:a05:622a:34f:b0:437:a0fc:9198 with SMTP id r15-20020a05622a034f00b00437a0fc9198mr2741663qtw.12.1713462731120; Thu, 18 Apr 2024 10:52:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713462731; cv=none; d=google.com; s=arc-20160816; b=INF4GuyTmu70rBTs7s6oY5a6Z0YiaFYi+LHfpuDaQmXexjIq5LKLvgFQfoV2wEoaCH AiO+URQ5trPKOOdqLtH9ZIY6zdwwg/eJ17CnPYzMvsEO8iVOMQTO49k9FE3rgs89n+o+ 4nvOsZ6EpV7QW7j4L/35HA4FfhxIrgtkG+ImvlyvMTibSDfWtW9ZsxcnYDZKxy/h5E2M 1HuPQpFJwk3WocKB5ja0o4ycm/PfBft+9Dh/30tvfGzbgFBEapMdmhxqOJ8XnY57DeXJ j6sRj9m4Z2CE92omzJAd7b8NyBpe8YlS6cQEoY+hOZcrRSrPS6q8lWWnMkLlAeJ5VBsZ KjBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=PITDiwcEne1mvwImsIqQGnA5z4IfFwj1UMnzudlp+TQ=; fh=VnQSsLJ6tU3xftJEJWuGWplserK0coOB1jCu/kfGRn4=; b=CEgokWiM1fdW/7hXl0lEtEZVps/8Z7p5CRBU6cGJrbDE7IhVmACidlCS1DkuVtruMv JAKHMtUf1isvop24hEFsKJ9TMfdAzG4pDOJ56Cv/hYk13dzk2iTBWG0gEqeB7z4MBUjy cqlg/RldPa/FzSfTFIYPGyJ3oyqEz+c+oQopxAzOi/tbMjBldZ/R0uZJwUOWvjXDleUX 9yNDlIJfoJJMkq2zlHiwPqi1ZRHgFkY69TAv0PNz86pWP8aeEtUC28+ImvSCmroP/0YX xO1DUNCMRVl3igweXXpiRq5e/1D+MPxtEeJ7wDI7ADT0jct8Hq7IQYm4cD/vd4iov657 Q3hQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u13-20020a05620a084d00b0078f162257edsi294578qku.425.2024.04.18.10.52.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2024 10:52:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxVun-0001W3-FF; Thu, 18 Apr 2024 13:51:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxVui-0001NN-K1; Thu, 18 Apr 2024 13:51:12 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxVug-0007bW-HA; Thu, 18 Apr 2024 13:51:12 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 6F8465FD71; Thu, 18 Apr 2024 20:50:03 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id CF003B934B; Thu, 18 Apr 2024 20:50:00 +0300 (MSK) Received: (nullmailer pid 947854 invoked by uid 1000); Thu, 18 Apr 2024 17:49:55 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Zheyu Ma , Peter Maydell , Michael Tokarev Subject: [Stable-8.2.3 104/116] hw/misc/applesmc: Fix memory leak in reset() handler Date: Thu, 18 Apr 2024 20:49:34 +0300 Message-Id: <20240418174955.947730-17-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé AppleSMCData is allocated with g_new0() in applesmc_add_key(): release it with g_free(). Leaked since commit 1ddda5cd36 ("AppleSMC device emulation"). Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272 Reported-by: Zheyu Ma Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20240408095217.57239-3-philmd@linaro.org> (cherry picked from commit fc09ff2979defdcf8d00c2db94022d5d610e36ba) Signed-off-by: Michael Tokarev diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 72300d0cbc..a77fb93e7f 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -274,6 +274,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) /* Remove existing entries */ QLIST_FOREACH_SAFE(d, &s->data_def, node, next) { QLIST_REMOVE(d, node); + g_free(d); } s->status = 0x00; s->status_1e = 0x00;