From patchwork Mon Mar 25 15:28:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 782342 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:b0:33e:7753:30bd with SMTP id p1csp1235542wrt; Mon, 25 Mar 2024 08:29:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXLklK/YXSe282qo8MK/Ppj4rieL3fMtKdkYkx1F0pyz58FFcS7a8P0djuOV3HSFzk25Tn0UOG2XZCdSwTeZujt X-Google-Smtp-Source: AGHT+IF/1J05du6mu0AiRQ+LuEv1mTdw/sXNBW3cynKmt7qddU2nlqXe11tFZgStdztlHnOY+xnp X-Received: by 2002:a25:b41a:0:b0:dc7:4639:55d1 with SMTP id n26-20020a25b41a000000b00dc7463955d1mr5102943ybj.18.1711380576318; Mon, 25 Mar 2024 08:29:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711380576; cv=none; d=google.com; s=arc-20160816; b=gagubSYygvhcfE8VlzVumGy2yxDk5Y8ywVV2FsKSvrZhN/Wtizpp5s+qFd+Iaz7CDI C411dVQUiPA9GEjzZ7b4BtQ32b2wTExXbyVIyxN3X19uwZ5zmkAgP/7guhamKmcbhm6s 8zUXsTlauTPV6/U5RwODWB7edwsCOVRBwWUKEsFKgqMeBGI/x3FDgt75QTK1k/Mo2kBI buzV3Yws8koTLS9T+T/LhODuvPapCs//z4LantZYgK8AocUnHjzKrqQ+SFFIYgf8Qt7t UHkgaXM/RqVvEXJaJrrNxSqWjGLLeQJswvB+Vb2il4hY3CTPxRumaYAbQIgAUbQlJaBW uz9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=egg5Mtyn99cCwmy/P18xKwdXOjmaICInZ6LaE2Awphc=; fh=Vnpc6sAZ683hqmTcdvG596lAL6GFS9SeeG7OE8u/W1Q=; b=hI364WnKArwQv0oYjJrFOyZzK8x5rIpg0ZPVdHxzxCceL5Mcwun0MFEax/KFw6z1S5 D8uPhpitZX62TuV8bRM5Q8bJH9p+1T1cH0i4tH5DEjH69JgoaYW3/08ldIm0NnNhND9H MZ8GElFn0F5ZMrmYq13ff5/ptnD/Ygu1uXdrplF0zEv18YpLkHOnzm90jnsLWMNkLNho lVZGffCKut0t1Iekv9R44usdrbvnV0p+GRzZpJa/3uVTKqBTy7LVvWRuvBCcloc9rCh+ MeKSu1CfnprNOmxHaFt5PQ9ozAhOfq6YIxGKsh+EnjCvsSvRuDFKWlmFeHG1UBkb530j 1+uw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QAoft+Zp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q2-20020a05621419e200b0069675b1262esi5917875qvc.17.2024.03.25.08.29.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2024 08:29:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QAoft+Zp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1romFo-0002lp-NU; Mon, 25 Mar 2024 11:28:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1romFn-0002lD-6K for qemu-devel@nongnu.org; Mon, 25 Mar 2024 11:28:51 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1romFl-0000Fr-Pb for qemu-devel@nongnu.org; Mon, 25 Mar 2024 11:28:50 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-414859830f2so10021835e9.0 for ; Mon, 25 Mar 2024 08:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711380527; x=1711985327; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=egg5Mtyn99cCwmy/P18xKwdXOjmaICInZ6LaE2Awphc=; b=QAoft+ZpjFuEqdkyjeyCnyG/tB7/55Q5ZnGyqVwppwa2xdKm+ZDMzSxhIXs8t0o4SB yUmzcikKumFABwufuHZO/6db4qZNk7pD3rPHt0BA2AVDn+rqTewJ7Fh0dj3AQC488KhB aapV0dojbhBoXFZ6n9Y5GvlwR6SflnOmSOa5IF7iTsn6yk8704K9QwjrS3fTEQKXl1nm xrn/cBfMV7JALe7RtABz+s8ewZbLHVKd/5Evpk7gp72vxa8B61kqZJodjDX6U1d8iIZV eWSicqIk+1DJxVtzkMw5PGlqbz0BrspjgsRfdxm2sK+TCKaU9CD0UdGrED3Oo3WZA3Ow 00Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711380527; x=1711985327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egg5Mtyn99cCwmy/P18xKwdXOjmaICInZ6LaE2Awphc=; b=tLwqkSfKBv5Jbfq0Z7Hhe3B/xcocxiQ/xDQe1vNE4Ke/Ze2z5cFEJPRk4SMvF0Xn/V inTg5HvFkazUGkRzt2qR/WtVu32jAgpihr1L3+Fj433tx3psON+8Yw8Kc1LfcHnw5iAt eLtOks39QZZetio/cTO9E/nrMdPGtNC2TYNah/Hx4McMW5E1nX/kzoRtiPuc+NzibPZx pB8hxWSkEqSMlvy+WbAqErOQLVEDJqpQo1eFulCfs+X5Rh7ub8x4oCSsxYnLNHhuA4Vg XgH+COiPvh0blZZ1vU+WB/pElRAJ6DqwVDNtP6LA9UtYkajLAQJqJBl2mkTxNbUSCN3/ Fe8w== X-Gm-Message-State: AOJu0YzuP5XtvSzh8i7WTWugGuBJXJkga7POOWvXZauXtQ8vTW0Po4R+ ijV1Kxq2s8wKxxBEZkuN/AfDi5EkBqY7uZGmAtfjPhcAOjB2CphcT0I5GxULztD4Y43owIVcsFw ozi8= X-Received: by 2002:a05:600c:4f01:b0:414:8948:621c with SMTP id l1-20020a05600c4f0100b004148948621cmr2566601wmq.8.1711380527317; Mon, 25 Mar 2024 08:28:47 -0700 (PDT) Received: from m1x-phil.lan ([176.187.208.214]) by smtp.gmail.com with ESMTPSA id j28-20020a05600c1c1c00b004146c769c79sm8799861wms.0.2024.03.25.08.28.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 25 Mar 2024 08:28:46 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?In=C3=A8s_Varhol?= , Alistair Francis , qemu-arm@nongnu.org, Arnaud Minier , Damien Hedde , Peter Maydell , Luc Michel , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0 v3 3/3] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock Date: Mon, 25 Mar 2024 16:28:26 +0100 Message-ID: <20240325152827.73817-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240325152827.73817-1-philmd@linaro.org> References: <20240325152827.73817-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Arnaud Minier The "clock_set_mul_div" function doesn't propagate the clock period to the children if it is changed (e.g. by enabling/disabling a clock multiplexer). This was overlooked during the implementation due to late changes. This commit propagates the change if the multiplier or divider changes. Fixes: ec7d83acbd ("hw/misc/stm32l4x5_rcc: Add an internal clock multiplexer object") Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-ID: <20240317103918.44375-2-arnaud.minier@telecom-paris.fr> [PMD: Check clock_set_mul_div() return value] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/misc/stm32l4x5_rcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/stm32l4x5_rcc.c b/hw/misc/stm32l4x5_rcc.c index 49b90afdf0..ed2dbd9dc3 100644 --- a/hw/misc/stm32l4x5_rcc.c +++ b/hw/misc/stm32l4x5_rcc.c @@ -61,7 +61,7 @@ static void clock_mux_update(RccClockMuxState *mux, bool bypass_source) freq_multiplier = mux->divider; } - clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier); + clk_changed |= clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier); clk_changed |= clock_set(mux->out, clock_get(current_source)); if (clk_changed) { clock_propagate(mux->out);