From patchwork Mon Mar 4 19:13:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 777788 Delivered-To: patch@linaro.org Received: by 2002:a5d:48c8:0:b0:33e:474f:8c56 with SMTP id p8csp94533wrs; Mon, 4 Mar 2024 11:14:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVA6iaa2+n7YU4ah/qm5NMMr3fXPmFdJz4al3a96EgByaKuRxYIEc2XqKOwb8zJt46AZ0b3+TqrK22m99qNWn2D X-Google-Smtp-Source: AGHT+IE9JnSytD6OYzIsFE/NO/roffxfe2MdP2nehuKGzEqHrtEl6GmLsP5fcP4bCo3a2u6Anb3i X-Received: by 2002:a37:c44a:0:b0:788:1e80:9ea3 with SMTP id h10-20020a37c44a000000b007881e809ea3mr6190399qkm.35.1709579699336; Mon, 04 Mar 2024 11:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709579699; cv=none; d=google.com; s=arc-20160816; b=Qo0XpDRAfzEWkZJ9jSNu58u9MAOY0SeM6Y+qBJLrMi9VyWDqUiyKZvJRaP0Z0FZ1Ga 5ou+nuGU8nOwfljr/V8KouJVswABT1ahyec0z2c6LJHiO0RBH/Pj0PEGqK1tKkOf1sVU LdR7fVHHXWxooQh8Ei77yyhLsYQDAxhKyA67WuEY5sp6OxMhxawhFxVgRCCscPo0CDSI dW+jyuh/1kTsJpGDMsG4NnMcXvnhTvVRzf8GvR5x1WoGBxdvgEoi7oPDUukgjEmo/aT3 KjEJxpzV7WJwaFW0Wp/rW5DusslNt04M7fWA7BIngPgYdkxtWC7+xT9S41BLedFzJXar VrNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m0d/Phj/7yIgxNG2HYpQbbRbVtCMOAMLsAUj8z9GTaE=; fh=b/fM3Azt1fJndKkBUw6/kyP4UN6WY/kGpFR2FNJIEXM=; b=M0T+8ZmmNaC0+wF6YYzIY2eIOF8hau9VRZXlbVHT1gSVBqOW3KTTYgp/+foJidX5Ej 4OEBQB5785dtFl7ed0NWxdQhtfItp3K3rOY0u3HHkBFhKLR2ZJ5L6ZqLdkZMz6/dFMus SDeA30fDtLuQ0hZwUAajW87io56igj+XFebF+pBbjZzqlVb4yCOzad1XzFpSvcrMb0DV PdXw5ITNgyQeW+UiONcWziTpottkNwA5UYnBEv/B7VajRYAXHdFn5PqjCdHmwBPwD0RU 8YsF71sYN2tzqebbuzmEkveQb7Wa8l4EC4jTp+C9v6+/JvGwHRi7/Uc8WAqc4n3kZeiF MAsw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="q/buDX0g"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s8-20020a05620a030800b00788316f51e4si829382qkm.4.2024.03.04.11.14.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2024 11:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="q/buDX0g"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhDkt-00039L-NQ; Mon, 04 Mar 2024 14:13:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhDks-00038a-LO for qemu-devel@nongnu.org; Mon, 04 Mar 2024 14:13:42 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhDkq-0001au-FA for qemu-devel@nongnu.org; Mon, 04 Mar 2024 14:13:42 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-412e784060cso5735565e9.1 for ; Mon, 04 Mar 2024 11:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709579618; x=1710184418; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m0d/Phj/7yIgxNG2HYpQbbRbVtCMOAMLsAUj8z9GTaE=; b=q/buDX0golA1fhq4rpurn8iIdNHffew24Ace9ub4WuZstFE8TCYxej4h8oYnWxjPKG xBja1V/pjUx3sujJYBEr8dANtzGOJxjGRiQO5dS4wxd0c12EnwWg37sDESoJ45x6sz3N nypAIqWp3oixSz+ZTgQw7O5LvDzHQRM6hMQoOfxOIIOQeUyMSyttu0cx/s1GGlmCJSjv 2Qifmbep+/BtEEHQBWFDknuCSVNurTHbXQ+AMMXnuGizuN5PZfNrzDKV+IPMJuR3QDF0 aR8Az5dN+HloxLBkX0EFokbyYDPGYF8DEtcuujAG4QPutS+LaGKPx0CUxRu2S5xM6sit JZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709579618; x=1710184418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m0d/Phj/7yIgxNG2HYpQbbRbVtCMOAMLsAUj8z9GTaE=; b=Za2GVIAqePaUSevjSUNpy87l8wJL0Z3mvBZ9M+qMrXvi/96vdM/klkEcQIGNhqKKIA igZLcwMnnjlxWsqhfrq2evpXVK9YrCRVWOQ/GuS+KJ77ndz6bIAsjqM5S9m7+xrF6T+x vUZexy5NqzfqBqCsODgHZs+XGi4PBN9kniMZ40ARwfOIkIvthQ3QZ0xlymAWT7m/cTF7 EzSIZLUZtZC8pox6zot3t5kqrEoXKs5qIZV0ZslWR0Zi6r+S0dXMlf/nqv6eb9PUh2f4 uGoLD8raC4KHvk9HAe4nfpEj7uuDi27kXqPZWlJBA4jmnUR0GsX05i4WhXvzAaX3xH0l U1sA== X-Gm-Message-State: AOJu0Ywc/nkqGR74rc19gh1WijAdt9dcEtMrUFXMEhIl3fO6XjBZyxTy ENJQ1EpKpWuvnVdOHoJOTxFDT7P81LSmVpTAgi19k6pwmilGFuBVogSq8TkKtTU= X-Received: by 2002:adf:a792:0:b0:33e:4865:9ced with SMTP id j18-20020adfa792000000b0033e48659cedmr47540wrc.2.1709579617987; Mon, 04 Mar 2024 11:13:37 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id p8-20020a5d68c8000000b0033d87f61613sm12891321wrw.58.2024.03.04.11.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 11:13:37 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 364D75F8A2; Mon, 4 Mar 2024 19:13:37 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , Richard Henderson , qemu-riscv@nongnu.org, Song Gao , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH 1/4] disas: introduce no_raw_bytes Date: Mon, 4 Mar 2024 19:13:34 +0000 Message-Id: <20240304191337.3101411-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240304191337.3101411-1-alex.bennee@linaro.org> References: <20240304191337.3101411-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org For plugins we don't expect the raw bytes in the disassembly. We already deal with this by hand crafting our capstone call but for other diassemblers we need a flag. Signed-off-by: Alex Bennée --- include/disas/dis-asm.h | 7 +++++++ disas/disas.c | 1 + 2 files changed, 8 insertions(+) diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h index 2324f6b1a46..5c32e7a310c 100644 --- a/include/disas/dis-asm.h +++ b/include/disas/dis-asm.h @@ -396,6 +396,13 @@ typedef struct disassemble_info { /* Command line options specific to the target disassembler. */ char * disassembler_options; + /* + * When true instruct the disassembler to not preface opcodes with + * raw bytes. This is mainly for the benefit of the plugin + * interface. + */ + bool no_raw_bytes; + /* Field intended to be used by targets in any way they deem suitable. */ void *target_info; diff --git a/disas/disas.c b/disas/disas.c index 0d2d06c2ecc..feb5bc4b665 100644 --- a/disas/disas.c +++ b/disas/disas.c @@ -273,6 +273,7 @@ char *plugin_disas(CPUState *cpu, uint64_t addr, size_t size) s.info.buffer_vma = addr; s.info.buffer_length = size; s.info.print_address_func = plugin_print_address; + s.info.no_raw_bytes = true; if (s.info.cap_arch >= 0 && cap_disas_plugin(&s.info, addr, size)) { ; /* done */