From patchwork Wed Feb 28 11:56:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 776486 Delivered-To: patch@linaro.org Received: by 2002:adf:e94d:0:b0:33d:f458:43ce with SMTP id m13csp257980wrn; Wed, 28 Feb 2024 04:13:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU0Zsn/i3WmYDi/ZXt5rTIpBBTNeXjhppeUr3gc5S5/RuqRulYTunjGvaSUp+Ud6yi7oa9//etoICwvURp1iwW7 X-Google-Smtp-Source: AGHT+IH+pgHYfSgRCRVcJ7MfxA9PSOFESfJKC3+Zqvj/diTB7K6+2ekBQM4qjgo7uVk/xJDC09S2 X-Received: by 2002:a67:ea54:0:b0:471:e1ac:d108 with SMTP id r20-20020a67ea54000000b00471e1acd108mr8777421vso.20.1709122438959; Wed, 28 Feb 2024 04:13:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709122438; cv=none; d=google.com; s=arc-20160816; b=ryP0FN/3LE//5QbrAOi7tFVLk7MeP4SI9yqHQ3yMZmj1CBQeGlOb2SndrlD22uFaGu QZXz9ZQKyveuvAsZipRauOFGgdw1T3wrytp9WWgRHJL2tqXVemaf8zctIMfRz/HlKDbX uq8C9fi2dcRZdBwxqdKDrZMXPfSsfYYTEZ1rAgAVuXDTWv36E32iLVzOwJieBCEHn6y5 l6VO6apHE4RU2MVMzwnXqjvmuO3X2srRGVt2zvErgjfZnMvamlNWwId3MxPRQ2Yf5X7n Aij1Rj2t4Y/U5pI6KWYX9o07sonl9wpJ1XjFptZmbFk/UHWFme4JGM7w2EsJ1XPFuGcs SbRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ahM/+kL0fDsDOWiFdIDq3kYt2sIQjOO/d/8sCwn+DTM=; fh=UxbDL+1Ia/1DkenQ8TquoebiK4+BTVc52aeziOuEfXg=; b=d2Ea+xlLs4UU1SNVsdReYDSiBjLztSxw9AkVOLGdQ9kCgDz5MlgCZ5PSMoN9vlLts5 4xO6MuHwhn/xpICAb3XamYqFhwzTVvXK/Ox5WTfzP8nGmYOhyYW/mocDLuNmN6dahofs PNG+Pvf3YQHZgrB28qqoolbTOiYs7VJSAojWCgquQKYIEPQXGe5S5mYzPV0/ONP34ENm 5gN4i834T+Y0iflnUiS90xYlmgI+d1lYld2uLaihdohn+2YHu1LQXJOWq+ZDvhEhQybD hWrPdLhQDQwrjcweWsGXWhwKlwoS+/AySMCnS1iFxGd9ZPaDSkALSbXOoWZYnxInzNrV HLHA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DldCi9zT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j10-20020ac85c4a000000b0042eadf46734si978483qtj.104.2024.02.28.04.13.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2024 04:13:58 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DldCi9zT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfIeO-0004cL-8O; Wed, 28 Feb 2024 07:03:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfIeM-0004Tq-SG for qemu-devel@nongnu.org; Wed, 28 Feb 2024 07:03:02 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfIeL-000352-2S for qemu-devel@nongnu.org; Wed, 28 Feb 2024 07:03:02 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-412a9e9c776so4677275e9.0 for ; Wed, 28 Feb 2024 04:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709121779; x=1709726579; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ahM/+kL0fDsDOWiFdIDq3kYt2sIQjOO/d/8sCwn+DTM=; b=DldCi9zTmuRrc1F0D5KPvWt3Hn7TVmNGnye1cL1LBnLfsTf01nanmGYhUY+jvmVIXL GNQHEA5p+FgYEvrYY/JSD48NrPci6ypUA3Z65qSOLg7+6SZXVjpiyk2+0Ba3yUWn/rkw Gnik6Fc1er5dMRZI3MDicEYf45Xj8UGBnZNAKHsYHyymJ7ziXb+IjfRNvfImCjIjd0dJ OFk6GGhtbYkwBW4nLjcTPg2JEWSOF0nI9JFntVipIzZsFpFbg0parfPVrtwx/bPiwGEB atc8258O2Km/oklpUyWYRZB6ZttYjNjM6SpY54w9KrsFDOLzpz3wuuVJoapozXDg5LA9 6ekA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709121779; x=1709726579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ahM/+kL0fDsDOWiFdIDq3kYt2sIQjOO/d/8sCwn+DTM=; b=RNUmPgcoIYb9YMOq26bz78EZHZeeJ8Ma+eaTZeF2INDIbrV5Dys9uB9WEY5RNumGOP dxxZa5a0JjssbncTuyLJ5zOBVc7on0mm8mCabhfoJVN7zWSYj45bAKJ7le6BSJo1AhYh ZMYVxjFaFibDM0Er1ONnqDOGLetfTSYesEocH02dCLMuY+ppjKkfTPUkCtagTTLkX2o5 EwDovzrIyis4jtpvf7abJjETwZKBvUA+COjRp0AhRHsjuFOfkYLfSsfSx7odTy15uB21 BLvaHCz+GF/7h+F32Pta7++2a+VwxRInx+Lh5MwELAr/OwY8Yt5iPexNHbHXMK9dx+bJ j6tQ== X-Gm-Message-State: AOJu0Ywh6PvJTPTZ62SczoPq+a6jpADifU1fGW8KN5rV6xcV+TjtaYk7 NtCjiYGWuHUVVB2ZZ8fhBz2ZcZIZx4QGQjfUf+q1poRURbNGhB87n3aRZomwgWYEgFN+hsfP7Xu 0 X-Received: by 2002:a05:600c:4f07:b0:412:a3f2:d641 with SMTP id l7-20020a05600c4f0700b00412a3f2d641mr2185224wmq.19.1709121779173; Wed, 28 Feb 2024 04:02:59 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id jj18-20020a05600c6a1200b004129e8af6absm1873676wmb.33.2024.02.28.04.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 04:02:56 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id F08415F928; Wed, 28 Feb 2024 11:57:03 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PULL 21/29] gdbstub: expose api to find registers Date: Wed, 28 Feb 2024 11:56:53 +0000 Message-Id: <20240228115701.1416107-22-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228115701.1416107-1-alex.bennee@linaro.org> References: <20240228115701.1416107-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Expose an internal API to QEMU to return all the registers for a vCPU. The list containing the details required to called gdb_read_register(). Based-on: <20231025093128.33116-15-akihiko.odaki@daynix.com> Cc: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Alex Bennée Message-Id: <20240227144335.1196131-22-alex.bennee@linaro.org> diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index da9ddfe54c5..eb14b91139b 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -111,6 +111,34 @@ void gdb_feature_builder_end(const GDBFeatureBuilder *builder); */ const GDBFeature *gdb_find_static_feature(const char *xmlname); +/** + * gdb_read_register() - Read a register associated with a CPU. + * @cpu: The CPU associated with the register. + * @buf: The buffer that the read register will be appended to. + * @reg: The register's number returned by gdb_find_feature_register(). + * + * Return: The number of read bytes. + */ +int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); + +/** + * typedef GDBRegDesc - a register description from gdbstub + */ +typedef struct { + int gdb_reg; + const char *name; + const char *feature_name; +} GDBRegDesc; + +/** + * gdb_get_register_list() - Return list of all registers for CPU + * @cpu: The CPU being searched + * + * Returns a GArray of GDBRegDesc, caller frees array but not the + * const strings. + */ +GArray *gdb_get_register_list(CPUState *cpu); + void gdb_set_stop_cpu(CPUState *cpu); /* in gdbstub-xml.c, generated by scripts/feature_to_c.py */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index a55b5e6581a..2909bc8c69f 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -490,7 +490,32 @@ const GDBFeature *gdb_find_static_feature(const char *xmlname) g_assert_not_reached(); } -static int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg) +GArray *gdb_get_register_list(CPUState *cpu) +{ + GArray *results = g_array_new(true, true, sizeof(GDBRegDesc)); + + /* registers are only available once the CPU is initialised */ + if (!cpu->gdb_regs) { + return results; + } + + for (int f = 0; f < cpu->gdb_regs->len; f++) { + GDBRegisterState *r = &g_array_index(cpu->gdb_regs, GDBRegisterState, f); + for (int i = 0; i < r->feature->num_regs; i++) { + const char *name = r->feature->regs[i]; + GDBRegDesc desc = { + r->base_reg + i, + name, + r->feature->name + }; + g_array_append_val(results, desc); + } + } + + return results; +} + +int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg) { CPUClass *cc = CPU_GET_CLASS(cpu); GDBRegisterState *r;