From patchwork Mon Feb 26 16:56:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 775891 Delivered-To: patch@linaro.org Received: by 2002:ab3:621a:0:b0:258:3251:9e33 with SMTP id w26csp1477512lte; Mon, 26 Feb 2024 09:03:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUCHwf5+gXMiI6Vl7L8Swe3eAfDfzids91AxOl/tl44r0Z9vJAR2hfh8cwffVLKXC+eGVZADz3+GoAh2ekeAr81 X-Google-Smtp-Source: AGHT+IGWzfTMYxISIvo0RIBkiiwh58BTzzhO8/SfQA+SNu7GZfTzykyi3gWy5fwGpogrsvcy2D+T X-Received: by 2002:a05:622a:d6:b0:42e:8bb1:5ea9 with SMTP id p22-20020a05622a00d600b0042e8bb15ea9mr3227854qtw.7.1708967027481; Mon, 26 Feb 2024 09:03:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708967027; cv=none; d=google.com; s=arc-20160816; b=tZ8EgT0PC9sB49ti/fVRwu+vvaPHyu9X0N7EHt3NPDbk2u47DLygmsn9FAB97tfTmx pKKRh4cZ3BiVJ3Fx3afO6tI0e8Y1NEA//mHa8lSLbbJyLaocPQw1sSQoo2rxEh9Xiv9C oqxEwpHJ83Z4ntmBjZirRzdmetY5Ww/gHAA2ZWPQfRsVUdLZHGYTR7+Jkh3ldk2veoCt E0j0XhLLbddWwPcLd7xPxMgSh/adoQnoKlZ2h6mKOp1f2Aoc34MW+qOFRe5pmbuK3hWh nq22k884jYBdE2FH6jW5goSPQvxjYz4s+TCQI+oJ7Tc/vsIROUAsHkLflrOp8m8vrBT9 80Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pTAh5Ga1/WCguB9K86wBQIKOB8LucCe9FRfIk+dLcDE=; fh=inHz/qE9VTgeXyA0ge5D6fVYa/Mfhts5ntNvtYndEVE=; b=n2mZ7jbzFQA4vyrkMn/Lwdvu8BqEp0BBzM2rwUQE5aac5OClNZlnFTHaqs8BQc1H+l 4FWH3m/yPXIvrhT4x2fJdwmWNzES/N7fnc7vrQWGIfq16SrsnzkGd/PR286bi3H5wcTr zc3wWaW9MfGRPkigs2BLVMg8JMOfZVAQdAfYIEDpAvBD+L7XNxTqu3W9f0lmcyyqv1eG rVo1vy1EadzvyhzdsP8c9GN7ny65uP9MBMb1tIZ3M0T93zRfWF7QkOoe5m8tf4Cv50xZ gJJe6LaZmJs5mXIXK7BZyY0+biG6XYrUqeUxCCyN8Aom9C/6N7AL+TbvlGFWJX7dvmuy CZsw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gGitUSZQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u8-20020a05620a454800b00787d6677545si1849814qkp.79.2024.02.26.09.03.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2024 09:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gGitUSZQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reeO7-0004vS-Tk; Mon, 26 Feb 2024 12:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reeNT-0004Bx-GL for qemu-devel@nongnu.org; Mon, 26 Feb 2024 12:02:56 -0500 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reeNI-0000mb-VX for qemu-devel@nongnu.org; Mon, 26 Feb 2024 12:02:55 -0500 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2d288bac3caso16879551fa.2 for ; Mon, 26 Feb 2024 09:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708966963; x=1709571763; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pTAh5Ga1/WCguB9K86wBQIKOB8LucCe9FRfIk+dLcDE=; b=gGitUSZQxkr2K3+tKizn57lY8U7rHs0dLEkAsLN94FkrThrAUkNU2zv8sx4Wyfr7ax dWyc8e+ihKZcWA+8Z4hjBni4q15+he81Qw0LoQMBGsc+s9Ky4hsrTAWAG7TPDGH1rByM pqqs1FpsVQoWXn7ZLpa51GCYv0HK4Tb6Ppt7aHbwIJmuCy7mhpq5TsRtrMJecTx4DxKa JoyKMc05/m9m2/a5vw7UG+lMDTZL3z0J4+tq2c7U7xQ2mz8SiejgGkyfdvAVq7LPIC/l 45uKOipZIfFk2idwTfH7XcDjfTGI4dHB109hDl4In+LiM1isF7WTjE9ssCXBTV/pwUjn 59dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708966963; x=1709571763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pTAh5Ga1/WCguB9K86wBQIKOB8LucCe9FRfIk+dLcDE=; b=Wf/n5IX2Prwtk4YB3FBMZDWjGUYikljO17C9ryJOVE4o9Wi3bl01zZ1rY9WTrPXo7O lk3jgf/NOM0jjspc+JFeQ4ma3hb7Su5EkoI1CZK0bG1CVfShTxnn7nAOyIe+z24Bh87U FpymoQbL/hqAdW99ZlUymXmT9j3k7RbTgNsi0P/nwEdQixcVh52zwvjw1yPJ1NGYTuUB 8dcxA2XtFMnAwlIHF8aDjLt9N3vvK/hEJXsC8unU0OKC2TQV2lnVhrAKeXMgPPjeaaHx 17MNwDB5jTGeXsBnRa609Qhd6wVOVB0SR9p8ABOTP0t1owqLrZRjLVnWofTfwtMAs7RL haNw== X-Gm-Message-State: AOJu0YxQhQzTNQF44WuwqbLDhM3sGsSdgub37zfAy6nu0eNIplhtjTfo 4StMhTsZ4liBrRU9O0TL06ct90tB+b0Kgyr5u5KDW+AhhFYNOHzOC7CtkU8Dnpg= X-Received: by 2002:a2e:b8c3:0:b0:2d2:38b6:661b with SMTP id s3-20020a2eb8c3000000b002d238b6661bmr6087404ljp.33.1708966962934; Mon, 26 Feb 2024 09:02:42 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id h19-20020a05600c261300b00412a30cd127sm5212488wma.7.2024.02.26.09.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:02:41 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 9AD295F92C; Mon, 26 Feb 2024 16:56:48 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Nicholas Piggin , Liu Zhiwei , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-riscv@nongnu.org, Michael Rolnik , Song Gao , Alexandre Iooss , Marcel Apfelbaum , David Hildenbrand , Pierrick Bouvier , John Snow , Eduardo Habkost , Mahmoud Mandour , qemu-arm@nongnu.org, =?utf-8?q?Phi?= =?utf-8?q?lippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Cleber Rosa , qemu-ppc@nongnu.org, Richard Henderson , qemu-s390x@nongnu.org, Daniel Henrique Barboza , Thomas Huth , Yoshinori Sato , Yanan Wang , Brian Cain , Ilya Leoshkevich , Weiwei Li , "Edgar E. Iglesias" , Bin Meng , Laurent Vivier , Palmer Dabbelt , Daniel Henrique Barboza , Alistair Francis , Akihiko Odaki Subject: [PATCH v3 19/27] gdbstub: expose api to find registers Date: Mon, 26 Feb 2024 16:56:38 +0000 Message-Id: <20240226165646.425600-20-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240226165646.425600-1-alex.bennee@linaro.org> References: <20240226165646.425600-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::231; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Expose an internal API to QEMU to return all the registers for a vCPU. The list containing the details required to called gdb_read_register(). Based-on: <20231025093128.33116-15-akihiko.odaki@daynix.com> Cc: Akihiko Odaki Message-Id: <20240103173349.398526-38-alex.bennee@linaro.org> Signed-off-by: Alex Bennée --- v3 - rm unused api functions left over --- include/exec/gdbstub.h | 28 ++++++++++++++++++++++++++++ gdbstub/gdbstub.c | 27 ++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index da9ddfe54c5..eb14b91139b 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -111,6 +111,34 @@ void gdb_feature_builder_end(const GDBFeatureBuilder *builder); */ const GDBFeature *gdb_find_static_feature(const char *xmlname); +/** + * gdb_read_register() - Read a register associated with a CPU. + * @cpu: The CPU associated with the register. + * @buf: The buffer that the read register will be appended to. + * @reg: The register's number returned by gdb_find_feature_register(). + * + * Return: The number of read bytes. + */ +int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); + +/** + * typedef GDBRegDesc - a register description from gdbstub + */ +typedef struct { + int gdb_reg; + const char *name; + const char *feature_name; +} GDBRegDesc; + +/** + * gdb_get_register_list() - Return list of all registers for CPU + * @cpu: The CPU being searched + * + * Returns a GArray of GDBRegDesc, caller frees array but not the + * const strings. + */ +GArray *gdb_get_register_list(CPUState *cpu); + void gdb_set_stop_cpu(CPUState *cpu); /* in gdbstub-xml.c, generated by scripts/feature_to_c.py */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index a55b5e6581a..2909bc8c69f 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -490,7 +490,32 @@ const GDBFeature *gdb_find_static_feature(const char *xmlname) g_assert_not_reached(); } -static int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg) +GArray *gdb_get_register_list(CPUState *cpu) +{ + GArray *results = g_array_new(true, true, sizeof(GDBRegDesc)); + + /* registers are only available once the CPU is initialised */ + if (!cpu->gdb_regs) { + return results; + } + + for (int f = 0; f < cpu->gdb_regs->len; f++) { + GDBRegisterState *r = &g_array_index(cpu->gdb_regs, GDBRegisterState, f); + for (int i = 0; i < r->feature->num_regs; i++) { + const char *name = r->feature->regs[i]; + GDBRegDesc desc = { + r->base_reg + i, + name, + r->feature->name + }; + g_array_append_val(results, desc); + } + } + + return results; +} + +int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg) { CPUClass *cc = CPU_GET_CLASS(cpu); GDBRegisterState *r;